From: "Mitani" <mitani@ryobi.co.jp>
To: 'Garrett Cooper' <yanegomi@gmail.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] fix "hugetlb" several tests
Date: Wed, 14 Apr 2010 17:58:17 +0900 [thread overview]
Message-ID: <000601cadbb0$9fb8b5d0$df2a2170$@co.jp> (raw)
In-Reply-To: <g2p364299f41004132317v539c2b02g3eea49dc830cea0f@mail.gmail.com>
> -----Original Message-----
> From: Garrett Cooper [mailto:yanegomi@gmail.com]
> Sent: Wednesday, April 14, 2010 3:18 PM
> To: Mitani
> Cc: Randy Dunlap; ltp-list@lists.sourceforge.net
> Subject: Re: [LTP] [PATCH] fix "hugetlb" several tests
>
> On Tue, Apr 13, 2010 at 7:17 PM, Mitani <mitani@ryobi.co.jp> wrote:
> > Hi Randy,
> >
> > I couldn't notice a misspelling. Sorry.
> > I decided to use "due to" according to your advice.
> >
> > May I suggest revised patch?
> >
[...]
> >
> > Thank you--
> >
> > -Tomonori Mitani
> >
> >
> >> -----Original Message-----
> >> From: Randy Dunlap [mailto:rdunlap@xenotime.net]
> >> Sent: Wednesday, April 14, 2010 12:04 AM
> >> To: Mitani
> >> Cc: ltp-list@lists.sourceforge.net
> >> Subject: Re: [LTP] [PATCH] fix "hugetlb" several tests
> >>
> >> On 04/12/10 23:58, Mitani wrote:
> >> > ------------
> >> > a) All tests:
> >> > "TBROK : Test cannot be continued owning to sufficient
> >> availability of
> >> > Hugepages on the system"
> >> >
> >> > b) 2), 3), 5), 6), 8), 10), 11) tests:
> >> > "TWARN : tst_rmdir(): TESTDIR was NULL; no removal attempted"
> >> > ------------
> >> >
> >> > Both case a) and case b) are caused by the same reason.
> >> >
> >> > All of case a) failures occured at the following points (for
> example
> >> > hugemmap04):
> >> > ------------<hugemmap04.c - main()>
> >> > /* Check number of hugepages */
> >> > if (get_no_of_hugepages() <= 0 || hugepages_size() <=
> 0)
> >> > tst_brkm(TBROK, cleanup, "Test cannot be
> continued
> >> owning to
> >> > \
> >> > sufficient availability of
> >> Hugepages on the
> >> > system");
> >> > ------------
> >> >
> >> > I found out that "HugePages_Total" parameter of "/proc/meminfo"
> file
> >> > is set to "0". This caused above TBROK failure. It is environment
> >> problem.
> >> >
> >> > But, in this case, tests must not return with TBROK, but with TCONF,
> >> > I think.
> >>
> >> That makes sense to me.
> >>
> >> > And, in case b), these tests try to delete "TESTDIR" directory
> by
> >> > calling "tst_rmdir()" function in "cleanup()" function.
> >> > But, "TESTDIR" never set if "tst_tmpdir()" function isn't called.
> >> > I think that case b)'s tests must not call cleanup() function.
> >> >
> >> >
> >> > I want to suggest following patch.
> >> >
> >> > Signed-off-by: Tomonori Mitani <mitani@ryobi.co.jp>
> >> >
> >> > ============
> >> > --- a/testcases/kernel/mem/hugetlb/hugemmap/hugemmap04.c
> >> 2010-04-01
> >> > 15:23:09.000000000 +0900
> >> > +++ b/testcases/kernel/mem/hugetlb/hugemmap/hugemmap04.c
> >> 2010-04-13
> >> > 11:23:33.000000000 +0900
> >> > @@ -127,7 +127,7 @@
> >> >
> >> > /* Check number of hugepages */
> >> > if (get_no_of_hugepages() <= 0 || hugepages_size() <= 0)
> >> > - tst_brkm(TBROK, cleanup, "Test cannot be continued
> >> owning to
> >> > \
> >> > + tst_brkm(TCONF, cleanup, "Test cannot be continued
> >> owning to
> >> > \
> >> > sufficient availability of
> Hugepages
> >> on the
> >> > system");
> >> >
> >> > /* Perform global setup for test */
> >>
> >> Not caused by your patch, but all of those "owning to" should be
> "owing
> >> to"
> >> or even better, "due to".
>
> Sorry... it might have been better to say (more succinctly): "Not
> enough available Hugepages" ?
> Thanks,
> -Garrett
Hi,
I suggest new patch.
Signed-off-by: Tomonori Mitani <mitani@ryobi.co.jp>
============
--- a/testcases/kernel/mem/hugetlb/hugemmap/hugemmap04.c 2010-04-01
15:23:09.000000000 +0900
+++ b/testcases/kernel/mem/hugetlb/hugemmap/hugemmap04.c 2010-04-14
16:40:25.000000000 +0900
@@ -127,8 +127,7 @@
/* Check number of hugepages */
if (get_no_of_hugepages() <= 0 || hugepages_size() <= 0)
- tst_brkm(TBROK, cleanup, "Test cannot be continued owning to
\
- sufficient availability of Hugepages on the
system");
+ tst_brkm(TCONF, cleanup, "Not enough available Hugepages");
/* Perform global setup for test */
setup();
--- a/testcases/kernel/mem/hugetlb/hugeshmat/hugeshmat01.c 2010-04-01
15:23:09.000000000 +0900
+++ b/testcases/kernel/mem/hugetlb/hugeshmat/hugeshmat01.c 2010-04-14
16:48:54.000000000 +0900
@@ -105,7 +105,7 @@
}
if ( get_no_of_hugepages() <= 0 || hugepages_size() <= 0 )
- tst_brkm(TBROK, cleanup, "Test cannot be continued owning to
sufficient availability of Hugepages on the system");
+ tst_brkm(TCONF, tst_exit, "Not enough available Hugepages");
else
huge_pages_shm_to_be_allocated = ( get_no_of_hugepages() *
hugepages_size() * 1024) / 2 ;
--- a/testcases/kernel/mem/hugetlb/hugeshmat/hugeshmat02.c 2010-04-01
15:23:09.000000000 +0900
+++ b/testcases/kernel/mem/hugetlb/hugeshmat/hugeshmat02.c 2010-04-14
16:49:15.000000000 +0900
@@ -102,7 +102,7 @@
}
if ( get_no_of_hugepages() <= 0 || hugepages_size() <= 0 )
- tst_brkm(TBROK, cleanup, "Test cannot be continued owning to
sufficient availability of Hugepages on the system");
+ tst_brkm(TCONF, tst_exit, "Not enough available Hugepages");
else
huge_pages_shm_to_be_allocated = ( get_no_of_hugepages() *
hugepages_size() * 1024) / 2 ;
--- a/testcases/kernel/mem/hugetlb/hugeshmat/hugeshmat03.c 2010-04-01
15:23:09.000000000 +0900
+++ b/testcases/kernel/mem/hugetlb/hugeshmat/hugeshmat03.c 2010-04-14
16:49:31.000000000 +0900
@@ -86,7 +86,7 @@
}
if ( get_no_of_hugepages() <= 0 || hugepages_size() <= 0 )
- tst_brkm(TBROK, cleanup, "Test cannot be continued owning to
sufficient availability of Hugepages on the system");
+ tst_brkm(TCONF, cleanup, "Not enough available Hugepages");
else
huge_pages_shm_to_be_allocated = ( get_no_of_hugepages() *
hugepages_size() * 1024) / 2 ;
--- a/testcases/kernel/mem/hugetlb/hugeshmctl/hugeshmctl01.c 2010-04-01
15:23:09.000000000 +0900
+++ b/testcases/kernel/mem/hugetlb/hugeshmctl/hugeshmctl01.c 2010-04-14
16:50:16.000000000 +0900
@@ -130,7 +130,7 @@
}
if ( get_no_of_hugepages() <= 0 || hugepages_size() <= 0 )
- tst_brkm(TBROK, cleanup, "Test cannot be continued owning to
sufficient availability of Hugepages on the system");
+ tst_brkm(TCONF, tst_exit, "Not enough available Hugepages");
else
huge_pages_shm_to_be_allocated = ( get_no_of_hugepages() *
hugepages_size() * 1024) / 2 ;
--- a/testcases/kernel/mem/hugetlb/hugeshmctl/hugeshmctl02.c 2010-04-01
15:23:09.000000000 +0900
+++ b/testcases/kernel/mem/hugetlb/hugeshmctl/hugeshmctl02.c 2010-04-14
16:50:28.000000000 +0900
@@ -102,7 +102,7 @@
}
if ( get_no_of_hugepages() <= 0 || hugepages_size() <= 0 )
- tst_brkm(TBROK, cleanup, "Test cannot be continued owning to
sufficient availability of Hugepages on the system");
+ tst_brkm(TCONF, tst_exit, "Not enough available Hugepages");
else
huge_pages_shm_to_be_allocated = ( get_no_of_hugepages() *
hugepages_size() * 1024) / 2 ;
--- a/testcases/kernel/mem/hugetlb/hugeshmctl/hugeshmctl03.c 2010-04-01
15:23:09.000000000 +0900
+++ b/testcases/kernel/mem/hugetlb/hugeshmctl/hugeshmctl03.c 2010-04-14
16:50:40.000000000 +0900
@@ -105,7 +105,7 @@
}
if ( get_no_of_hugepages() <= 0 || hugepages_size() <= 0 )
- tst_brkm(TBROK, cleanup, "Test cannot be continued owning to
sufficient availability of Hugepages on the system");
+ tst_brkm(TCONF, cleanup, "Not enough available Hugepages");
else
huge_pages_shm_to_be_allocated = ( get_no_of_hugepages() *
hugepages_size() * 1024) / 2 ;
--- a/testcases/kernel/mem/hugetlb/hugeshmdt/hugeshmdt01.c 2010-04-01
15:23:09.000000000 +0900
+++ b/testcases/kernel/mem/hugetlb/hugeshmdt/hugeshmdt01.c 2010-04-14
16:51:11.000000000 +0900
@@ -87,7 +87,7 @@
}
if ( get_no_of_hugepages() <= 0 || hugepages_size() <= 0 )
- tst_brkm(TBROK, cleanup, "Test cannot be continued owning to
sufficient availability of Hugepages on the system");
+ tst_brkm(TCONF, tst_exit, "Not enough available Hugepages");
else
huge_pages_shm_to_be_allocated = ( get_no_of_hugepages() *
hugepages_size() * 1024) / 2 ;
--- a/testcases/kernel/mem/hugetlb/hugeshmget/hugeshmget01.c 2010-04-01
15:23:09.000000000 +0900
+++ b/testcases/kernel/mem/hugetlb/hugeshmget/hugeshmget01.c 2010-04-14
16:51:34.000000000 +0900
@@ -82,7 +82,7 @@
/* The following loop checks looping state if -i option given */
if ( get_no_of_hugepages() <= 0 || hugepages_size() <= 0 )
- tst_brkm(TBROK, cleanup, "Test cannot be continued owning to
sufficient availability of Hugepages on the system");
+ tst_brkm(TCONF, cleanup, "Not enough available Hugepages");
else
huge_pages_shm_to_be_allocated = ( get_no_of_hugepages() *
hugepages_size() * 1024) / 2 ;
--- a/testcases/kernel/mem/hugetlb/hugeshmget/hugeshmget02.c 2010-04-01
15:23:09.000000000 +0900
+++ b/testcases/kernel/mem/hugetlb/hugeshmget/hugeshmget02.c 2010-04-14
16:51:45.000000000 +0900
@@ -84,7 +84,7 @@
}
if ( get_no_of_hugepages() <= 0 || hugepages_size() <= 0 )
- tst_brkm(TBROK, cleanup, "Test cannot be continued owning to
sufficient availability of Hugepages on the system");
+ tst_brkm(TCONF, tst_exit, "Not enough available Hugepages");
else
huge_pages_shm_to_be_allocated = ( get_no_of_hugepages() *
hugepages_size() * 1024) / 2 ;
--- a/testcases/kernel/mem/hugetlb/hugeshmget/hugeshmget03.c 2010-04-01
15:23:09.000000000 +0900
+++ b/testcases/kernel/mem/hugetlb/hugeshmget/hugeshmget03.c 2010-04-14
16:51:55.000000000 +0900
@@ -85,7 +85,7 @@
/* The following loop checks looping state if -i option given */
if ( get_no_of_hugepages() <= 0 || hugepages_size() <= 0 )
- tst_brkm(TBROK, cleanup, "Test cannot be continued owning to
sufficient availability of Hugepages on the system");
+ tst_brkm(TCONF, tst_exit, "Not enough available Hugepages");
else
huge_pages_shm_to_be_allocated = ( get_no_of_hugepages() *
hugepages_size() * 1024) / 2 ;
--- a/testcases/kernel/mem/hugetlb/hugeshmget/hugeshmget05.c 2010-04-01
15:23:09.000000000 +0900
+++ b/testcases/kernel/mem/hugetlb/hugeshmget/hugeshmget05.c 2010-04-14
16:52:10.000000000 +0900
@@ -86,7 +86,7 @@
}
if ( get_no_of_hugepages() <= 0 || hugepages_size() <= 0 )
- tst_brkm(TBROK, cleanup, "Test cannot be continued owning to
sufficient availability of Hugepages on the system");
+ tst_brkm(TCONF, cleanup, "Not enough available Hugepages");
else
huge_pages_shm_to_be_allocated = ( get_no_of_hugepages() *
hugepages_size() * 1024) / 2 ;
============
Regards--
-Tomonori Mitani
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2010-04-14 8:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-13 6:58 [LTP] [PATCH] fix "hugetlb" several tests Mitani
2010-04-13 15:03 ` Randy Dunlap
2010-04-14 2:17 ` Mitani
2010-04-14 6:17 ` Garrett Cooper
2010-04-14 8:58 ` Mitani [this message]
2010-04-14 9:18 ` Ryan Wang
2010-04-14 9:30 ` Garrett Cooper
2010-04-15 0:56 ` Mitani
2010-04-15 6:54 ` Rishikesh K Rajak
2010-04-15 8:42 ` Garrett Cooper
2010-04-16 1:33 ` Mitani
2010-04-16 5:15 ` Garrett Cooper
2010-04-14 15:19 ` Randy Dunlap
2010-04-16 2:42 ` Mitani
2010-04-16 5:05 ` Garrett Cooper
2010-04-16 9:23 ` Mitani
2010-04-16 15:12 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000601cadbb0$9fb8b5d0$df2a2170$@co.jp' \
--to=mitani@ryobi.co.jp \
--cc=ltp-list@lists.sourceforge.net \
--cc=yanegomi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.