[PATCH v4 0/4] usb gadget: Add SuperSpeed support to the Gadget Framework

[PATCH v4 0/4] usb gadget: Add SuperSpeed support to the Gadget Framework

[Tatyana Brokhman]

This patch series adds the SuperSpeed functionality to the gadget framework.
This implementation passed both USBCV 3.0 and 2.0 test suites.

Rebased on top of v2.6.37-rc1

Tatyana Brokhman (4):
  usb: Add usb_endpoint_descriptor to be part of the struct usb_ep
  usb: Configure endpoint according to gadget speed.
  usb: Modify existing gadget drivers to use config_ep_by_speed()
    instead of ep_choose.
  usb:gadget: Add SuperSpeed support to the Gadget Framework

 drivers/usb/gadget/Kconfig          |   12 +
 drivers/usb/gadget/composite.c      |  444 +++++++++++++++++++++++++++++++++--
 drivers/usb/gadget/config.c         |   25 --
 drivers/usb/gadget/dbgp.c           |    8 +-
 drivers/usb/gadget/epautoconf.c     |    1 +
 drivers/usb/gadget/f_acm.c          |   50 ++---
 drivers/usb/gadget/f_audio.c        |    5 +-
 drivers/usb/gadget/f_ecm.c          |   54 ++---
 drivers/usb/gadget/f_eem.c          |   36 +--
 drivers/usb/gadget/f_fs.c           |    3 +-
 drivers/usb/gadget/f_hid.c          |   22 +--
 drivers/usb/gadget/f_loopback.c     |   17 +-
 drivers/usb/gadget/f_mass_storage.c |    3 +-
 drivers/usb/gadget/f_obex.c         |   32 +--
 drivers/usb/gadget/f_phonet.c       |   17 +-
 drivers/usb/gadget/f_rndis.c        |   52 ++---
 drivers/usb/gadget/f_serial.c       |   32 +--
 drivers/usb/gadget/f_sourcesink.c   |   14 +-
 drivers/usb/gadget/f_subset.c       |   33 +--
 drivers/usb/gadget/f_uvc.c          |    6 +-
 drivers/usb/gadget/file_storage.c   |    3 +-
 drivers/usb/gadget/gmidi.c          |    6 +-
 drivers/usb/gadget/inode.c          |    6 +-
 drivers/usb/gadget/printer.c        |   26 +-
 drivers/usb/gadget/u_ether.c        |   12 +-
 drivers/usb/gadget/u_ether.h        |    4 -
 drivers/usb/gadget/u_serial.c       |    4 +-
 drivers/usb/gadget/u_serial.h       |    2 -
 include/linux/usb/composite.h       |   55 ++++-
 include/linux/usb/gadget.h          |   64 ++++--
 30 files changed, 687 insertions(+), 361 deletions(-)

--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

Re: [PATCH v4 0/4] usb gadget: Add SuperSpeed support to the Gadget Framework

[Greg KH]

On Thu, Nov 18, 2010 at 02:46:16PM +0200, Tatyana Brokhman wrote:
> This patch series adds the SuperSpeed functionality to the gadget framework.
> This implementation passed both USBCV 3.0 and 2.0 test suites.

Do you have a pointer to the tests that you mentioned previously?  It
would be good to include them here as well.

> Rebased on top of v2.6.37-rc1

I would need them on top of linux-next if I were to be able to accept
them.

thanks,

greg k-h

RE: [PATCH v4 0/4] usb gadget: Add SuperSpeed support to the Gadget Framework

[Tanya Brokhman]

Hi Greg

Unfortunately I can't add a pointer to the unittest I mentioned since we
didn't release them yet. It's in our TODO list but we didn't get to it yet
since if we're about to release them we need to go over the code again as it
won't be excepted as is due to coding style issues. 
I have a question regarding sharing this test code: 
As I mentioned earlier (in another thread) the tests are written using the
GoogleTest Framework and libusb so as you already understood - it's a user
space application. If we were to share them, how is it done? It seems that
linux-usb@vger isn't the most appropriate mailing list for this. Or is it?
Also, we added several patches on top of the libusb (think the latest
version but not sure) that also need to be released for that.
Bottom line is: In order to use these test one will need the following
patches:
1. Several updates on top of the libusb branch
2. The user-space code
3. several patches on top of the v2.6.36 (or later) that implement the needs
testing functionality on the kernel side (for example: new control message
was added to dummy_hcd to perform connect/disconnect test)

How this should be released?

I'm sorry but I'm not familiar with linux-next that you mentioned. I thought
v2.6.37-rc1 is the latest. Could you please provide me with more details on
linux-next branch and a pointer to it?
I'm new at this so sorry for troubling you with extra explanations.

Thanks for your patience and guidance 
Regards,

Tanya Brokhman
Consultant for Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum



-----Original Message-----
From: Greg KH [mailto:greg@kroah.com] 
Sent: Thursday, November 18, 2010 5:49 PM
To: Tatyana Brokhman
Cc: gregkh@suse.de; linux-usb@vger.kernel.org; linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v4 0/4] usb gadget: Add SuperSpeed support to the Gadget
Framework

On Thu, Nov 18, 2010 at 02:46:16PM +0200, Tatyana Brokhman wrote:
> This patch series adds the SuperSpeed functionality to the gadget
framework.
> This implementation passed both USBCV 3.0 and 2.0 test suites.

Do you have a pointer to the tests that you mentioned previously?  It
would be good to include them here as well.

> Rebased on top of v2.6.37-rc1

I would need them on top of linux-next if I were to be able to accept
them.

thanks,

greg k-h

Re: [PATCH v4 0/4] usb gadget: Add SuperSpeed support to the Gadget Framework

[Greg KH]

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Fri, Nov 19, 2010 at 12:56:22PM +0200, Tanya Brokhman wrote:
> Hi Greg
> 
> Unfortunately I can't add a pointer to the unittest I mentioned since we
> didn't release them yet. It's in our TODO list but we didn't get to it yet
> since if we're about to release them we need to go over the code again as it
> won't be excepted as is due to coding style issues. 

Coding style issues only take a few hours to resolve, that's not a good
excuse :)

> I have a question regarding sharing this test code: 
> As I mentioned earlier (in another thread) the tests are written using the
> GoogleTest Framework and libusb so as you already understood - it's a user
> space application. If we were to share them, how is it done? It seems that
> linux-usb@vger isn't the most appropriate mailing list for this. Or is it?
> Also, we added several patches on top of the libusb (think the latest
> version but not sure) that also need to be released for that.
> Bottom line is: In order to use these test one will need the following
> patches:
> 1. Several updates on top of the libusb branch
> 2. The user-space code
> 3. several patches on top of the v2.6.36 (or later) that implement the needs
> testing functionality on the kernel side (for example: new control message
> was added to dummy_hcd to perform connect/disconnect test)
> 
> How this should be released?

How ever you can.  Seriously, point people at all of the above that you
have, and then work with the libusb people to get the needed changes
into their tree, which, if the patches are reasonable, shouldn't be hard
at all.

> I'm sorry but I'm not familiar with linux-next that you mentioned. I thought
> v2.6.37-rc1 is the latest. Could you please provide me with more details on
> linux-next branch and a pointer to it?

google linux-next to see the FAQ and find out how to download it.

Also, please read the Documentation/development_process/ files to
understand a bit more about how the kernel development process works.
If you have further questions after reading that, please let us know.

hope this helps,

greg k-h