From: "Rakesh Pillai" <pillair@codeaurora.org>
To: 'Florian Fainelli' <f.fainelli@gmail.com>, ath10k@lists.infradead.org
Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, kuba@kernel.org,
davem@davemloft.net, kvalo@codeaurora.org
Subject: RE: [PATCH v2 0/3]
Date: Sat, 1 Aug 2020 10:40:03 +0530 [thread overview]
Message-ID: <000701d667c2$0782fe70$1688fb50$@codeaurora.org> (raw)
In-Reply-To: <c6c5b3c5-f862-9cee-6863-24f666cc28f5@gmail.com>
> -----Original Message-----
> From: Florian Fainelli <f.fainelli@gmail.com>
> Sent: Saturday, August 1, 2020 12:17 AM
> To: Rakesh Pillai <pillair@codeaurora.org>; ath10k@lists.infradead.org
> Cc: linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org;
> kvalo@codeaurora.org; davem@davemloft.net; kuba@kernel.org;
> netdev@vger.kernel.org
> Subject: Re: [PATCH v2 0/3]
>
> On 7/31/20 11:27 AM, Rakesh Pillai wrote:
> > The history recording will be compiled only if
> > ATH10K_DEBUG is enabled, and also enabled via
> > the module parameter. Once the history recording
> > is enabled via module parameter, it can be enabled
> > or disabled runtime via debugfs.
>
> Why not use trace prints and retrieving them via the function tracer?
> This seems very ad-hoc.
Tracing needs to be enabled to capture the events.
But these events can be turned on in some kind of a debug build and capture the history to help us debug in case there is a crash.
It wont even allocate memory if not enabled via module parameter.
>
> >
> > ---
> > Changes from v1:
> > - Add module param and debugfs to enable/disable history recording.
> >
> > Rakesh Pillai (3):
> > ath10k: Add history for tracking certain events
> > ath10k: Add module param to enable history
> > ath10k: Add debugfs support to enable event history
> >
> > drivers/net/wireless/ath/ath10k/ce.c | 1 +
> > drivers/net/wireless/ath/ath10k/core.c | 3 +
> > drivers/net/wireless/ath/ath10k/core.h | 82 ++++++++++++
> > drivers/net/wireless/ath/ath10k/debug.c | 207
> ++++++++++++++++++++++++++++++
> > drivers/net/wireless/ath/ath10k/debug.h | 75 +++++++++++
> > drivers/net/wireless/ath/ath10k/snoc.c | 15 ++-
> > drivers/net/wireless/ath/ath10k/wmi-tlv.c | 1 +
> > drivers/net/wireless/ath/ath10k/wmi.c | 10 ++
> > 8 files changed, 393 insertions(+), 1 deletion(-)
> >
>
>
> --
> Florian
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: "Rakesh Pillai" <pillair@codeaurora.org>
To: "'Florian Fainelli'" <f.fainelli@gmail.com>,
<ath10k@lists.infradead.org>
Cc: <linux-wireless@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<kvalo@codeaurora.org>, <davem@davemloft.net>, <kuba@kernel.org>,
<netdev@vger.kernel.org>
Subject: RE: [PATCH v2 0/3]
Date: Sat, 1 Aug 2020 10:40:03 +0530 [thread overview]
Message-ID: <000701d667c2$0782fe70$1688fb50$@codeaurora.org> (raw)
In-Reply-To: <c6c5b3c5-f862-9cee-6863-24f666cc28f5@gmail.com>
> -----Original Message-----
> From: Florian Fainelli <f.fainelli@gmail.com>
> Sent: Saturday, August 1, 2020 12:17 AM
> To: Rakesh Pillai <pillair@codeaurora.org>; ath10k@lists.infradead.org
> Cc: linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org;
> kvalo@codeaurora.org; davem@davemloft.net; kuba@kernel.org;
> netdev@vger.kernel.org
> Subject: Re: [PATCH v2 0/3]
>
> On 7/31/20 11:27 AM, Rakesh Pillai wrote:
> > The history recording will be compiled only if
> > ATH10K_DEBUG is enabled, and also enabled via
> > the module parameter. Once the history recording
> > is enabled via module parameter, it can be enabled
> > or disabled runtime via debugfs.
>
> Why not use trace prints and retrieving them via the function tracer?
> This seems very ad-hoc.
Tracing needs to be enabled to capture the events.
But these events can be turned on in some kind of a debug build and capture the history to help us debug in case there is a crash.
It wont even allocate memory if not enabled via module parameter.
>
> >
> > ---
> > Changes from v1:
> > - Add module param and debugfs to enable/disable history recording.
> >
> > Rakesh Pillai (3):
> > ath10k: Add history for tracking certain events
> > ath10k: Add module param to enable history
> > ath10k: Add debugfs support to enable event history
> >
> > drivers/net/wireless/ath/ath10k/ce.c | 1 +
> > drivers/net/wireless/ath/ath10k/core.c | 3 +
> > drivers/net/wireless/ath/ath10k/core.h | 82 ++++++++++++
> > drivers/net/wireless/ath/ath10k/debug.c | 207
> ++++++++++++++++++++++++++++++
> > drivers/net/wireless/ath/ath10k/debug.h | 75 +++++++++++
> > drivers/net/wireless/ath/ath10k/snoc.c | 15 ++-
> > drivers/net/wireless/ath/ath10k/wmi-tlv.c | 1 +
> > drivers/net/wireless/ath/ath10k/wmi.c | 10 ++
> > 8 files changed, 393 insertions(+), 1 deletion(-)
> >
>
>
> --
> Florian
next prev parent reply other threads:[~2020-08-01 5:10 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-31 18:27 [PATCH v2 0/3] Rakesh Pillai
2020-07-31 18:27 ` Rakesh Pillai
2020-07-31 18:27 ` [PATCH v2 1/3] ath10k: Add history for tracking certain events Rakesh Pillai
2020-07-31 18:27 ` Rakesh Pillai
2020-07-31 18:38 ` Ben Greear
2020-07-31 18:38 ` Ben Greear
2020-08-01 5:13 ` Rakesh Pillai
2020-08-01 5:13 ` Rakesh Pillai
2020-07-31 18:27 ` [PATCH v2 2/3] ath10k: Add module param to enable history Rakesh Pillai
2020-07-31 18:27 ` Rakesh Pillai
2020-07-31 18:27 ` [PATCH v2 3/3] ath10k: Add debugfs support to enable event history Rakesh Pillai
2020-07-31 18:27 ` Rakesh Pillai
2020-07-31 18:46 ` [PATCH v2 0/3] Florian Fainelli
2020-07-31 18:46 ` Florian Fainelli
2020-08-01 5:10 ` Rakesh Pillai [this message]
2020-08-01 5:10 ` Rakesh Pillai
2020-08-01 5:24 ` Florian Fainelli
2020-08-01 5:24 ` Florian Fainelli
2020-07-31 20:31 ` Jakub Kicinski
2020-07-31 20:31 ` Jakub Kicinski
-- strict thread matches above, loose matches on Subject: below --
2021-06-28 9:19 Yifeng Zhao
2021-06-28 9:25 ` Philipp Tomsich
2021-06-28 9:32 ` Peter Robinson
2020-05-07 15:56 Gregory CLEMENT
2020-05-07 15:56 ` Gregory CLEMENT
2013-05-14 2:39 Simon Horman
2013-05-14 2:39 ` Simon Horman
2010-02-05 20:20 [PATCH 2/3] silence human readable info messages going to stderr from git push --porcelain Junio C Hamano
2010-02-05 20:49 ` [PATCH v2 0/3] Larry D'Anna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000701d667c2$0782fe70$1688fb50$@codeaurora.org' \
--to=pillair@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.