All of lore.kernel.org
 help / color / mirror / Atom feed
From: <wangweidong.a@awinic.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
	<broonie@kernel.org>, <perex@perex.cz>,
	<alsa-devel@alsa-project.org>, <tiwai@suse.com>,
	<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
	<ckeepax@opensource.cirrus.com>, <tanureal@opensource.cirrus.com>,
	<quic_potturu@quicinc.com>,
	<pierre-louis.bossart@linux.intel.com>, <cy_huang@richtek.com>
Cc: duanyibo@awinic.com, yijiangtao@awinic.com,
	zhangjianming@awinic.com, zhaolei@awinic.com,
	liweilei@awinic.com
Subject: Thanks to [PATCH V4 5/6] ASoC: dt-bindings: Add schema for "awinic, aw883xx"
Date: Tue, 15 Nov 2022 19:42:08 +0800	[thread overview]
Message-ID: <000701d8f8e7$4e01bc20$ea053460$@awinic.com> (raw)

Hi Krzysztof Kozlowski:

Thank you for your advice, I will change these questions

> Add a DT schema for describing Awinic AW883xx audio amplifiers. They 
> are controlled using I2C.
> 
> Signed-off-by: Weidong Wang <wangweidong.a@awinic.com>
> ---
>  .../bindings/sound/awinic,aw883xx.yaml        | 62 +++++++++++++++++++
>  1 file changed, 62 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml
> 
> diff --git 
> a/Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml 
> b/Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml
> new file mode 100644
> index 000000000000..04cdcf25a6d4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml
> @@ -0,0 +1,62 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/awinic,aw883xx.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Awinic AW883xx Smart Audio Amplifier
> +
> +maintainers:
> +  - Stephan Gerhold <stephan@gerhold.net>
> +
> +description:
> +  The Awinic AW883XX is an I2S/TDM input, high efficiency
> +  digital Smart K audio amplifier with an integrated 10.25V
> +  smart boost convert.
> +
> +allOf:
> +  - $ref: name-prefix.yaml#
> +
> +properties:
> +  compatible:
> +    const: awinic,aw883xx_smartpa
> +
> +  reg:
> +    description:
> +      The I2C address of the device for I2C

> What happened here? This was not present before. Drop description.

I will delete this description in patch v5

> +    maxItems: 1
> +
> +  reset-gpios:
> +    description:
> +      Reset pin of aw883xx chip

> The same case. Drop description.

> I commented only for irq-gpios that they need description.

I will delete this description in patch v5

> +    maxItems: 1
> +
> +  sound-channel:
> +    description:
> +      Number of sound channels of the aw883xx chip

> Your description does not explain me much. Number of supported sound channels is usually fixed in the hardware, thus coming from compatible.
> Therefore this might mean something else... but anyway your driver does not use it really, so just drop it.


I will delete this description in patch v5




             reply	other threads:[~2022-11-15 11:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-15 11:42 wangweidong.a [this message]
2022-11-15 12:08 ` Thanks to [PATCH V4 5/6] ASoC: dt-bindings: Add schema for "awinic,aw883xx" Krzysztof Kozlowski
  -- strict thread matches above, loose matches on Subject: below --
2022-11-15 10:08 [PATCH V4 5/6] ASoC: dt-bindings: Add schema for "awinic, aw883xx" Krzysztof Kozlowski
2022-11-16  3:38 ` Thanks to " wangweidong.a

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000701d8f8e7$4e01bc20$ea053460$@awinic.com' \
    --to=wangweidong.a@awinic.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=cy_huang@richtek.com \
    --cc=duanyibo@awinic.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=liweilei@awinic.com \
    --cc=perex@perex.cz \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=quic_potturu@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=tanureal@opensource.cirrus.com \
    --cc=tiwai@suse.com \
    --cc=yijiangtao@awinic.com \
    --cc=zhangjianming@awinic.com \
    --cc=zhaolei@awinic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.