* Thanks to [PATCH V4 5/6] ASoC: dt-bindings: Add schema for "awinic, aw883xx"
@ 2022-11-15 11:42 wangweidong.a
2022-11-15 12:08 ` Thanks to [PATCH V4 5/6] ASoC: dt-bindings: Add schema for "awinic,aw883xx" Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: wangweidong.a @ 2022-11-15 11:42 UTC (permalink / raw)
To: 'Krzysztof Kozlowski', broonie, perex, alsa-devel, tiwai,
robh+dt, krzysztof.kozlowski+dt, ckeepax, tanureal, quic_potturu,
pierre-louis.bossart, cy_huang
Cc: duanyibo, yijiangtao, zhangjianming, zhaolei, liweilei
Hi Krzysztof Kozlowski:
Thank you for your advice, I will change these questions
> Add a DT schema for describing Awinic AW883xx audio amplifiers. They
> are controlled using I2C.
>
> Signed-off-by: Weidong Wang <wangweidong.a@awinic.com>
> ---
> .../bindings/sound/awinic,aw883xx.yaml | 62 +++++++++++++++++++
> 1 file changed, 62 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml
>
> diff --git
> a/Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml
> b/Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml
> new file mode 100644
> index 000000000000..04cdcf25a6d4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml
> @@ -0,0 +1,62 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/awinic,aw883xx.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Awinic AW883xx Smart Audio Amplifier
> +
> +maintainers:
> + - Stephan Gerhold <stephan@gerhold.net>
> +
> +description:
> + The Awinic AW883XX is an I2S/TDM input, high efficiency
> + digital Smart K audio amplifier with an integrated 10.25V
> + smart boost convert.
> +
> +allOf:
> + - $ref: name-prefix.yaml#
> +
> +properties:
> + compatible:
> + const: awinic,aw883xx_smartpa
> +
> + reg:
> + description:
> + The I2C address of the device for I2C
> What happened here? This was not present before. Drop description.
I will delete this description in patch v5
> + maxItems: 1
> +
> + reset-gpios:
> + description:
> + Reset pin of aw883xx chip
> The same case. Drop description.
> I commented only for irq-gpios that they need description.
I will delete this description in patch v5
> + maxItems: 1
> +
> + sound-channel:
> + description:
> + Number of sound channels of the aw883xx chip
> Your description does not explain me much. Number of supported sound channels is usually fixed in the hardware, thus coming from compatible.
> Therefore this might mean something else... but anyway your driver does not use it really, so just drop it.
I will delete this description in patch v5
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Thanks to [PATCH V4 5/6] ASoC: dt-bindings: Add schema for "awinic,aw883xx"
2022-11-15 11:42 Thanks to [PATCH V4 5/6] ASoC: dt-bindings: Add schema for "awinic, aw883xx" wangweidong.a
@ 2022-11-15 12:08 ` Krzysztof Kozlowski
0 siblings, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-15 12:08 UTC (permalink / raw)
To: wangweidong.a, broonie, perex, alsa-devel, tiwai, robh+dt,
krzysztof.kozlowski+dt, ckeepax, tanureal, quic_potturu,
pierre-louis.bossart, cy_huang
Cc: duanyibo, yijiangtao, zhangjianming, zhaolei, liweilei
On 15/11/2022 12:42, wangweidong.a@awinic.com wrote:
> Hi Krzysztof Kozlowski:
>
> Thank you for your advice, I will change these questions
This is not a proper reply. Threading is broken.
(...)
>
>> + maxItems: 1
>> +
>> + sound-channel:
>> + description:
>> + Number of sound channels of the aw883xx chip
>
>> Your description does not explain me much. Number of supported sound channels is usually fixed in the hardware, thus coming from compatible.
>> Therefore this might mean something else... but anyway your driver does not use it really, so just drop it.
>
>
> I will delete this description in patch v5
No. Drop entire property.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V4 5/6] ASoC: dt-bindings: Add schema for "awinic, aw883xx"
@ 2022-11-15 10:08 Krzysztof Kozlowski
2022-11-16 3:38 ` Thanks to " wangweidong.a
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-15 10:08 UTC (permalink / raw)
To: wangweidong.a, broonie, perex, alsa-devel, tiwai, robh+dt,
krzysztof.kozlowski+dt, ckeepax, tanureal, quic_potturu,
pierre-louis.bossart, cy_huang
Cc: duanyibo, yijiangtao, zhangjianming, zhaolei, liweilei
On 15/11/2022 03:24, wangweidong.a@awinic.com wrote:
> From: Weidong Wang <wangweidong.a@awinic.com>
>
> Add a DT schema for describing Awinic AW883xx audio amplifiers. They are
> controlled using I2C.
>
> Signed-off-by: Weidong Wang <wangweidong.a@awinic.com>
> ---
> .../bindings/sound/awinic,aw883xx.yaml | 62 +++++++++++++++++++
> 1 file changed, 62 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml
>
> diff --git a/Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml b/Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml
> new file mode 100644
> index 000000000000..04cdcf25a6d4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml
> @@ -0,0 +1,62 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/awinic,aw883xx.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Awinic AW883xx Smart Audio Amplifier
> +
> +maintainers:
> + - Stephan Gerhold <stephan@gerhold.net>
> +
> +description:
> + The Awinic AW883XX is an I2S/TDM input, high efficiency
> + digital Smart K audio amplifier with an integrated 10.25V
> + smart boost convert.
> +
> +allOf:
> + - $ref: name-prefix.yaml#
> +
> +properties:
> + compatible:
> + const: awinic,aw883xx_smartpa
> +
> + reg:
> + description:
> + The I2C address of the device for I2C
What happened here? This was not present before. Drop description.
> + maxItems: 1
> +
> + reset-gpios:
> + description:
> + Reset pin of aw883xx chip
The same case. Drop description.
I commented only for irq-gpios that they need description.
> + maxItems: 1
> +
> + sound-channel:
> + description:
> + Number of sound channels of the aw883xx chip
Your description does not explain me much. Number of supported sound
channels is usually fixed in the hardware, thus coming from compatible.
Therefore this might mean something else... but anyway your driver does
not use it really, so just drop it.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Thanks to [PATCH V4 5/6] ASoC: dt-bindings: Add schema for "awinic, aw883xx"
2022-11-15 10:08 [PATCH V4 5/6] ASoC: dt-bindings: Add schema for "awinic, aw883xx" Krzysztof Kozlowski
@ 2022-11-16 3:38 ` wangweidong.a
0 siblings, 0 replies; 3+ messages in thread
From: wangweidong.a @ 2022-11-16 3:38 UTC (permalink / raw)
To: krzysztof.kozlowski
Cc: zhaolei, pierre-louis.bossart, alsa-devel, ckeepax, tanureal,
quic_potturu, wangweidong.a, tiwai, duanyibo, robh+dt, liweilei,
cy_huang, yijiangtao, broonie, zhangjianming,
krzysztof.kozlowski+dt
> From: Weidong Wang <wangweidong.a@awinic.com>
>
> Add a DT schema for describing Awinic AW883xx audio amplifiers. They are
> controlled using I2C.
>
> Signed-off-by: Weidong Wang <wangweidong.a@awinic.com>
> ---
> .../bindings/sound/awinic,aw883xx.yaml | 62 +++++++++++++++++++
> 1 file changed, 62 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml
>
> diff --git a/Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml b/Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml
> new file mode 100644
> index 000000000000..04cdcf25a6d4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml
> @@ -0,0 +1,62 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/awinic,aw883xx.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Awinic AW883xx Smart Audio Amplifier
> +
> +maintainers:
> + - Stephan Gerhold <stephan@gerhold.net>
> +
> +description:
> + The Awinic AW883XX is an I2S/TDM input, high efficiency
> + digital Smart K audio amplifier with an integrated 10.25V
> + smart boost convert.
> +
> +allOf:
> + - $ref: name-prefix.yaml#
> +
> +properties:
> + compatible:
> + const: awinic,aw883xx_smartpa
> +
> + reg:
> + description:
> + The I2C address of the device for I2C
> What happened here? This was not present before. Drop description.
I will delete this description in patch v5
> + maxItems: 1
> +
> + reset-gpios:
> + description:
> + Reset pin of aw883xx chip
> The same case. Drop description.
> I commented only for irq-gpios that they need description.
I will delete this description in patch v5
> + maxItems: 1
> +
> + sound-channel:
> + description:
> + Number of sound channels of the aw883xx chip
> Your description does not explain me much. Number of supported sound
> channels is usually fixed in the hardware, thus coming from compatible.
> Therefore this might mean something else... but anyway your driver does
> not use it really, so just drop it.
I will delete this property node in patch v5
Thank you very much for your advice
Best regards,
Weidong Wang
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-16 3:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-15 11:42 Thanks to [PATCH V4 5/6] ASoC: dt-bindings: Add schema for "awinic, aw883xx" wangweidong.a
2022-11-15 12:08 ` Thanks to [PATCH V4 5/6] ASoC: dt-bindings: Add schema for "awinic,aw883xx" Krzysztof Kozlowski
-- strict thread matches above, loose matches on Subject: below --
2022-11-15 10:08 [PATCH V4 5/6] ASoC: dt-bindings: Add schema for "awinic, aw883xx" Krzysztof Kozlowski
2022-11-16 3:38 ` Thanks to " wangweidong.a
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.