From: Pavel Fedin <p.fedin@samsung.com>
To: 'Peter Maydell' <peter.maydell@linaro.org>
Cc: 'Shlomo Pongratz' <shlomo.pongratz@huawei.com>,
'Shlomo Pongratz' <shlomopongratz@gmail.com>,
'QEMU Developers' <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v4] Use Aff1 with mpidr
Date: Mon, 15 Jun 2015 10:13:54 +0300 [thread overview]
Message-ID: <000801d0a73a$d6fbeac0$84f3c040$@samsung.com> (raw)
In-Reply-To: <CAFEAcA_XSZruYsKLHZCu4NoebxJEaQCUVvGeAWa9XctEC9SD8A@mail.gmail.com>
Hello!
> > +int arm_cpus_per_cluster = 8;
>
> This doesn't need to be global, it doesn't need to be exposed in
> a header file, and it definitely doesn't need to be non-constant.
> I suggest
> #define ARM_CPUS_PER_CLUSTER 8
It was a #define in v3, but i decided to change this in order to allow machine models to request different topology as Igor suggested. Of course you can revert to #define if you strictly want to.
> These are minor nits so I plan to just fix them as I apply
> this to target-arm.next, unless you object.
No, i don't object and of course i'm waiting for the PULL.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
next prev parent reply other threads:[~2015-06-15 7:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-08 12:28 [Qemu-devel] [PATCH v4] Use Aff1 with mpidr Pavel Fedin
2015-06-12 15:16 ` Peter Maydell
2015-06-15 7:13 ` Pavel Fedin [this message]
2015-06-15 7:40 ` Peter Maydell
2015-06-15 8:13 ` Pavel Fedin
2015-06-15 9:03 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000801d0a73a$d6fbeac0$84f3c040$@samsung.com' \
--to=p.fedin@samsung.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=shlomo.pongratz@huawei.com \
--cc=shlomopongratz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.