* [PATCH] cs35l56: Rename firmware for Thinkbook 16P Gen6 (17AA3921) without multiple speakers
@ 2025-09-01 14:59 Ziyu Zhou
2025-09-02 11:48 ` Josh Boyer
0 siblings, 1 reply; 3+ messages in thread
From: Ziyu Zhou @ 2025-09-01 14:59 UTC (permalink / raw)
To: linux-firmware; +Cc: Ziyu Zhou
Remove the 'spkid1' suffix from
cs35l56-b0-dsp1-misc-17aa3921-spkid1-amp*.bin and its corresponding
wmfw symlink, since Thinkbook 16P Gen6 (Subsystem ID 17AA3921) does
not have multiple speakers. The suffix prevents the kernel from
finding the correct firmware, which leads to very low speaker volume
and the error message: ".bin file required but not found".
Signed-off-by: Ziyu Zhou <jun@zzy040330.moe>
---
WHENCE | 6 +++---
...1.bin => cs35l56-b0-dsp1-misc-17aa3921-amp1.bin} | Bin
...2.bin => cs35l56-b0-dsp1-misc-17aa3921-amp2.bin} | Bin
3 files changed, 3 insertions(+), 3 deletions(-)
rename cirrus/{cs35l56-b0-dsp1-misc-17aa3921-spkid1-amp1.bin => cs35l56-b0-dsp1-misc-17aa3921-amp1.bin} (100%)
rename cirrus/{cs35l56-b0-dsp1-misc-17aa3921-spkid1-amp2.bin => cs35l56-b0-dsp1-misc-17aa3921-amp2.bin} (100%)
diff --git a/WHENCE b/WHENCE
index 2161ec89..7cd782b3 100644
--- a/WHENCE
+++ b/WHENCE
@@ -8295,9 +8295,9 @@ File: cirrus/cs35l56-b0-dsp1-misc-17aa391b-amp2.bin
Link: cirrus/cs35l56-b0-dsp1-misc-17aa391e-spkid0.wmfw -> cs35l56/CS35L56_Rev3.11.21.wmfw
File: cirrus/cs35l56-b0-dsp1-misc-17aa391e-spkid0-amp1.bin
File: cirrus/cs35l56-b0-dsp1-misc-17aa391e-spkid0-amp2.bin
-Link: cirrus/cs35l56-b0-dsp1-misc-17aa3921-spkid1.wmfw -> cs35l56/CS35L56_Rev3.11.21.wmfw
-File: cirrus/cs35l56-b0-dsp1-misc-17aa3921-spkid1-amp1.bin
-File: cirrus/cs35l56-b0-dsp1-misc-17aa3921-spkid1-amp2.bin
+Link: cirrus/cs35l56-b0-dsp1-misc-17aa3921.wmfw -> cs35l56/CS35L56_Rev3.11.21.wmfw
+File: cirrus/cs35l56-b0-dsp1-misc-17aa3921-amp1.bin
+File: cirrus/cs35l56-b0-dsp1-misc-17aa3921-amp2.bin
Link: cirrus/cs35l56-b0-dsp1-misc-17aa392c-spkid1.wmfw -> cs35l56/CS35L56_Rev3.11.21.wmfw
File: cirrus/cs35l56-b0-dsp1-misc-17aa392c-spkid1-amp1.bin
File: cirrus/cs35l56-b0-dsp1-misc-17aa392c-spkid1-amp2.bin
diff --git a/cirrus/cs35l56-b0-dsp1-misc-17aa3921-spkid1-amp1.bin b/cirrus/cs35l56-b0-dsp1-misc-17aa3921-amp1.bin
similarity index 100%
rename from cirrus/cs35l56-b0-dsp1-misc-17aa3921-spkid1-amp1.bin
rename to cirrus/cs35l56-b0-dsp1-misc-17aa3921-amp1.bin
diff --git a/cirrus/cs35l56-b0-dsp1-misc-17aa3921-spkid1-amp2.bin b/cirrus/cs35l56-b0-dsp1-misc-17aa3921-amp2.bin
similarity index 100%
rename from cirrus/cs35l56-b0-dsp1-misc-17aa3921-spkid1-amp2.bin
rename to cirrus/cs35l56-b0-dsp1-misc-17aa3921-amp2.bin
--
2.51.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] cs35l56: Rename firmware for Thinkbook 16P Gen6 (17AA3921) without multiple speakers
2025-09-01 14:59 [PATCH] cs35l56: Rename firmware for Thinkbook 16P Gen6 (17AA3921) without multiple speakers Ziyu Zhou
@ 2025-09-02 11:48 ` Josh Boyer
2025-09-02 12:36 ` Simon Trimmer
0 siblings, 1 reply; 3+ messages in thread
From: Josh Boyer @ 2025-09-02 11:48 UTC (permalink / raw)
To: Ziyu Zhou, Simon Trimmer; +Cc: linux-firmware
Simon,
Any thoughts on this one?
josh
On Mon, Sep 1, 2025 at 10:59 AM Ziyu Zhou <jun@zzy040330.moe> wrote:
>
> Remove the 'spkid1' suffix from
> cs35l56-b0-dsp1-misc-17aa3921-spkid1-amp*.bin and its corresponding
> wmfw symlink, since Thinkbook 16P Gen6 (Subsystem ID 17AA3921) does
> not have multiple speakers. The suffix prevents the kernel from
> finding the correct firmware, which leads to very low speaker volume
> and the error message: ".bin file required but not found".
>
> Signed-off-by: Ziyu Zhou <jun@zzy040330.moe>
> ---
> WHENCE | 6 +++---
> ...1.bin => cs35l56-b0-dsp1-misc-17aa3921-amp1.bin} | Bin
> ...2.bin => cs35l56-b0-dsp1-misc-17aa3921-amp2.bin} | Bin
> 3 files changed, 3 insertions(+), 3 deletions(-)
> rename cirrus/{cs35l56-b0-dsp1-misc-17aa3921-spkid1-amp1.bin => cs35l56-b0-dsp1-misc-17aa3921-amp1.bin} (100%)
> rename cirrus/{cs35l56-b0-dsp1-misc-17aa3921-spkid1-amp2.bin => cs35l56-b0-dsp1-misc-17aa3921-amp2.bin} (100%)
>
> diff --git a/WHENCE b/WHENCE
> index 2161ec89..7cd782b3 100644
> --- a/WHENCE
> +++ b/WHENCE
> @@ -8295,9 +8295,9 @@ File: cirrus/cs35l56-b0-dsp1-misc-17aa391b-amp2.bin
> Link: cirrus/cs35l56-b0-dsp1-misc-17aa391e-spkid0.wmfw -> cs35l56/CS35L56_Rev3.11.21.wmfw
> File: cirrus/cs35l56-b0-dsp1-misc-17aa391e-spkid0-amp1.bin
> File: cirrus/cs35l56-b0-dsp1-misc-17aa391e-spkid0-amp2.bin
> -Link: cirrus/cs35l56-b0-dsp1-misc-17aa3921-spkid1.wmfw -> cs35l56/CS35L56_Rev3.11.21.wmfw
> -File: cirrus/cs35l56-b0-dsp1-misc-17aa3921-spkid1-amp1.bin
> -File: cirrus/cs35l56-b0-dsp1-misc-17aa3921-spkid1-amp2.bin
> +Link: cirrus/cs35l56-b0-dsp1-misc-17aa3921.wmfw -> cs35l56/CS35L56_Rev3.11.21.wmfw
> +File: cirrus/cs35l56-b0-dsp1-misc-17aa3921-amp1.bin
> +File: cirrus/cs35l56-b0-dsp1-misc-17aa3921-amp2.bin
> Link: cirrus/cs35l56-b0-dsp1-misc-17aa392c-spkid1.wmfw -> cs35l56/CS35L56_Rev3.11.21.wmfw
> File: cirrus/cs35l56-b0-dsp1-misc-17aa392c-spkid1-amp1.bin
> File: cirrus/cs35l56-b0-dsp1-misc-17aa392c-spkid1-amp2.bin
> diff --git a/cirrus/cs35l56-b0-dsp1-misc-17aa3921-spkid1-amp1.bin b/cirrus/cs35l56-b0-dsp1-misc-17aa3921-amp1.bin
> similarity index 100%
> rename from cirrus/cs35l56-b0-dsp1-misc-17aa3921-spkid1-amp1.bin
> rename to cirrus/cs35l56-b0-dsp1-misc-17aa3921-amp1.bin
> diff --git a/cirrus/cs35l56-b0-dsp1-misc-17aa3921-spkid1-amp2.bin b/cirrus/cs35l56-b0-dsp1-misc-17aa3921-amp2.bin
> similarity index 100%
> rename from cirrus/cs35l56-b0-dsp1-misc-17aa3921-spkid1-amp2.bin
> rename to cirrus/cs35l56-b0-dsp1-misc-17aa3921-amp2.bin
> --
> 2.51.0
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [PATCH] cs35l56: Rename firmware for Thinkbook 16P Gen6 (17AA3921) without multiple speakers
2025-09-02 11:48 ` Josh Boyer
@ 2025-09-02 12:36 ` Simon Trimmer
0 siblings, 0 replies; 3+ messages in thread
From: Simon Trimmer @ 2025-09-02 12:36 UTC (permalink / raw)
To: 'Josh Boyer', 'Ziyu Zhou'; +Cc: linux-firmware, patches
Hi Josh and Ziyu
Oh dear - the ACPI source fragment that I have reviewed for this laptop does have a spk-id-gpios package.
As there may be more than one configuration of the BIOS we should probably add the non-spkid differentiated file as a symlink to the vendor differentiated file that way it would work on either version of the BIOS.
-Simon
> -----Original Message-----
> From: Josh Boyer <jwboyer@kernel.org>
> Sent: Tuesday, September 2, 2025 12:48 PM
> To: Ziyu Zhou <jun@zzy040330.moe>; Simon Trimmer
> <simont@opensource.cirrus.com>
> Cc: linux-firmware@kernel.org
> Subject: Re: [PATCH] cs35l56: Rename firmware for Thinkbook 16P Gen6
> (17AA3921) without multiple speakers
>
> Simon,
>
> Any thoughts on this one?
>
> josh
>
> On Mon, Sep 1, 2025 at 10:59 AM Ziyu Zhou <jun@zzy040330.moe> wrote:
> >
> > Remove the 'spkid1' suffix from
> > cs35l56-b0-dsp1-misc-17aa3921-spkid1-amp*.bin and its corresponding
> > wmfw symlink, since Thinkbook 16P Gen6 (Subsystem ID 17AA3921) does
> > not have multiple speakers. The suffix prevents the kernel from
> > finding the correct firmware, which leads to very low speaker volume
> > and the error message: ".bin file required but not found".
> >
> > Signed-off-by: Ziyu Zhou <jun@zzy040330.moe>
> > ---
> > WHENCE | 6 +++---
> > ...1.bin => cs35l56-b0-dsp1-misc-17aa3921-amp1.bin} | Bin
> > ...2.bin => cs35l56-b0-dsp1-misc-17aa3921-amp2.bin} | Bin
> > 3 files changed, 3 insertions(+), 3 deletions(-)
> > rename cirrus/{cs35l56-b0-dsp1-misc-17aa3921-spkid1-amp1.bin =>
> cs35l56-b0-dsp1-misc-17aa3921-amp1.bin} (100%)
> > rename cirrus/{cs35l56-b0-dsp1-misc-17aa3921-spkid1-amp2.bin =>
> cs35l56-b0-dsp1-misc-17aa3921-amp2.bin} (100%)
> >
> > diff --git a/WHENCE b/WHENCE
> > index 2161ec89..7cd782b3 100644
> > --- a/WHENCE
> > +++ b/WHENCE
> > @@ -8295,9 +8295,9 @@ File: cirrus/cs35l56-b0-dsp1-misc-17aa391b-
> amp2.bin
> > Link: cirrus/cs35l56-b0-dsp1-misc-17aa391e-spkid0.wmfw ->
> cs35l56/CS35L56_Rev3.11.21.wmfw
> > File: cirrus/cs35l56-b0-dsp1-misc-17aa391e-spkid0-amp1.bin
> > File: cirrus/cs35l56-b0-dsp1-misc-17aa391e-spkid0-amp2.bin
> > -Link: cirrus/cs35l56-b0-dsp1-misc-17aa3921-spkid1.wmfw ->
> cs35l56/CS35L56_Rev3.11.21.wmfw
> > -File: cirrus/cs35l56-b0-dsp1-misc-17aa3921-spkid1-amp1.bin
> > -File: cirrus/cs35l56-b0-dsp1-misc-17aa3921-spkid1-amp2.bin
> > +Link: cirrus/cs35l56-b0-dsp1-misc-17aa3921.wmfw ->
> cs35l56/CS35L56_Rev3.11.21.wmfw
> > +File: cirrus/cs35l56-b0-dsp1-misc-17aa3921-amp1.bin
> > +File: cirrus/cs35l56-b0-dsp1-misc-17aa3921-amp2.bin
> > Link: cirrus/cs35l56-b0-dsp1-misc-17aa392c-spkid1.wmfw ->
> cs35l56/CS35L56_Rev3.11.21.wmfw
> > File: cirrus/cs35l56-b0-dsp1-misc-17aa392c-spkid1-amp1.bin
> > File: cirrus/cs35l56-b0-dsp1-misc-17aa392c-spkid1-amp2.bin
> > diff --git a/cirrus/cs35l56-b0-dsp1-misc-17aa3921-spkid1-amp1.bin
> b/cirrus/cs35l56-b0-dsp1-misc-17aa3921-amp1.bin
> > similarity index 100%
> > rename from cirrus/cs35l56-b0-dsp1-misc-17aa3921-spkid1-amp1.bin
> > rename to cirrus/cs35l56-b0-dsp1-misc-17aa3921-amp1.bin
> > diff --git a/cirrus/cs35l56-b0-dsp1-misc-17aa3921-spkid1-amp2.bin
> b/cirrus/cs35l56-b0-dsp1-misc-17aa3921-amp2.bin
> > similarity index 100%
> > rename from cirrus/cs35l56-b0-dsp1-misc-17aa3921-spkid1-amp2.bin
> > rename to cirrus/cs35l56-b0-dsp1-misc-17aa3921-amp2.bin
> > --
> > 2.51.0
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-09-02 12:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-01 14:59 [PATCH] cs35l56: Rename firmware for Thinkbook 16P Gen6 (17AA3921) without multiple speakers Ziyu Zhou
2025-09-02 11:48 ` Josh Boyer
2025-09-02 12:36 ` Simon Trimmer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.