From: Pankaj Dubey <pankaj.dubey@samsung.com>
To: 'Bartlomiej Zolnierkiewicz' <b.zolnierkie@samsung.com>,
'Kukjin Kim' <kgene.kim@samsung.com>
Cc: 'Chanwoo Choi' <cw00.choi@samsung.com>,
'Kyungmin Park' <kyungmin.park@samsung.com>,
'Tomasz Figa' <tomasz.figa@gmail.com>,
'Vikas Sajjan' <vikas.sajjan@samsung.com>,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: RE: [PATCH v4] ARM: EXYNOS: add Exynos3250 PMU support
Date: Wed, 19 Nov 2014 16:54:10 +0530 [thread overview]
Message-ID: <000a01d003eb$79fe9630$6dfbc290$@samsung.com> (raw)
In-Reply-To: <1908469.QaqIJlesoD@amdc1032>
On Tuesday, November 18, 2014 11:05 PM, Bartlomiej Zolnierkiewicz Wrote:
> This patch prepares the PMU code for the future:
> - suspend/resume (S2R) support
> - cpuidle AFTR/W-AFTR modes support
> on Exynos3250.
>
> Cc: Pankaj Dubey <pankaj.dubey@samsung.com>
> Cc: Vikas Sajjan <vikas.sajjan@samsung.com>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Other than one small nitpick patch looks fine to me. Tested on Exynos3250
based
Espresso board and kernel booted fine.
Reviewed-by: Pankaj Dubey <pankaj.dubey@samsung.com>
>
> +static void exynos3250_pmu_init(void)
> +{
> + unsigned int value;
> +
> + /*
> + * To prevent form issuing new bus request form L2 memory system
typo: %s/form/from
> + * If core status is power down, should be set '1' to L2 power down
> + */
Thanks,
Pankaj Dubey
> --
> 1.8.2.3
WARNING: multiple messages have this Message-ID (diff)
From: pankaj.dubey@samsung.com (Pankaj Dubey)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4] ARM: EXYNOS: add Exynos3250 PMU support
Date: Wed, 19 Nov 2014 16:54:10 +0530 [thread overview]
Message-ID: <000a01d003eb$79fe9630$6dfbc290$@samsung.com> (raw)
In-Reply-To: <1908469.QaqIJlesoD@amdc1032>
On Tuesday, November 18, 2014 11:05 PM, Bartlomiej Zolnierkiewicz Wrote:
> This patch prepares the PMU code for the future:
> - suspend/resume (S2R) support
> - cpuidle AFTR/W-AFTR modes support
> on Exynos3250.
>
> Cc: Pankaj Dubey <pankaj.dubey@samsung.com>
> Cc: Vikas Sajjan <vikas.sajjan@samsung.com>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Other than one small nitpick patch looks fine to me. Tested on Exynos3250
based
Espresso board and kernel booted fine.
Reviewed-by: Pankaj Dubey <pankaj.dubey@samsung.com>
>
> +static void exynos3250_pmu_init(void)
> +{
> + unsigned int value;
> +
> + /*
> + * To prevent form issuing new bus request form L2 memory system
typo: %s/form/from
> + * If core status is power down, should be set '1' to L2 power down
> + */
Thanks,
Pankaj Dubey
> --
> 1.8.2.3
next prev parent reply other threads:[~2014-11-19 11:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-18 17:34 [PATCH v4] ARM: EXYNOS: add Exynos3250 PMU support Bartlomiej Zolnierkiewicz
2014-11-18 17:34 ` Bartlomiej Zolnierkiewicz
2014-11-19 11:24 ` Pankaj Dubey [this message]
2014-11-19 11:24 ` Pankaj Dubey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000a01d003eb$79fe9630$6dfbc290$@samsung.com' \
--to=pankaj.dubey@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=tomasz.figa@gmail.com \
--cc=vikas.sajjan@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.