From: "Alim Akhtar" <alim.akhtar@samsung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
<linux-phy@lists.infradead.org>
Cc: <devicetree@vger.kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <vkoul@kernel.org>,
<avri.altman@wdc.com>, <bvanassche@acm.org>,
<martin.petersen@oracle.com>, <chanho61.park@samsung.com>,
<pankaj.dubey@samsung.com>, <linux-fsd@tesla.com>,
"'Bharat Uppal'" <bharat.uppal@samsung.com>
Subject: RE: [PATCH 2/6] phy: samsung-ufs: move cdr offset to drvdata
Date: Fri, 3 Jun 2022 07:01:08 +0530 [thread overview]
Message-ID: <000b01d876e9$9bd36690$d37a33b0$@samsung.com> (raw)
In-Reply-To: <e92618c0-056c-5854-9bb3-5fba90a82d96@linaro.org>
>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
>Sent: Tuesday, May 31, 2022 3:26 PM
>To: Alim Akhtar <alim.akhtar@samsung.com>; linux-arm-
>kernel@lists.infradead.org; linux-kernel@vger.kernel.org; linux-
>scsi@vger.kernel.org; linux-phy@lists.infradead.org
>Cc: devicetree@vger.kernel.org; robh+dt@kernel.org;
>krzysztof.kozlowski+dt@linaro.org; vkoul@kernel.org; avri.altman@wdc.com;
>bvanassche@acm.org; martin.petersen@oracle.com;
>chanho61.park@samsung.com; pankaj.dubey@samsung.com; linux-
>fsd@tesla.com; Bharat Uppal <bharat.uppal@samsung.com>
>Subject: Re: [PATCH 2/6] phy: samsung-ufs: move cdr offset to drvdata
>
>On 31/05/2022 03:22, Alim Akhtar wrote:
>> Move CDR lock offset to drv data so that it can be extended for other
>> SoCs which are having CDR lock at different register offset.
>>
>> Cc: linux-fsd@tesla.com
>> Signed-off-by: Bharat Uppal <bharat.uppal@samsung.com>
>> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
>> ---
>> drivers/phy/samsung/phy-exynos7-ufs.c | 3 +++
>> drivers/phy/samsung/phy-exynosautov9-ufs.c | 2 ++
>> drivers/phy/samsung/phy-samsung-ufs.c | 3 ++-
>> drivers/phy/samsung/phy-samsung-ufs.h | 2 +-
>> 4 files changed, 8 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/phy/samsung/phy-exynos7-ufs.c
>> b/drivers/phy/samsung/phy-exynos7-ufs.c
>> index 7c9008e163db..d1a37273cb1f 100644
>> --- a/drivers/phy/samsung/phy-exynos7-ufs.c
>> +++ b/drivers/phy/samsung/phy-exynos7-ufs.c
>> @@ -11,6 +11,8 @@
>> #define EXYNOS7_EMBEDDED_COMBO_PHY_CTRL_MASK 0x1
>> #define EXYNOS7_EMBEDDED_COMBO_PHY_CTRL_EN BIT(0)
>>
>> +#define PHY_CDR_LOCK_STATUS 0x5e
>
>This should be now renamed to match other defines here, so
>EXYNOS7_EMBEDDED_COMBO_PHY_CDR_LOCK_STATUS
>
Sure, will update in next version
>
>Best regards,
>Krzysztof
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
WARNING: multiple messages have this Message-ID (diff)
From: "Alim Akhtar" <alim.akhtar@samsung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
<linux-phy@lists.infradead.org>
Cc: <devicetree@vger.kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <vkoul@kernel.org>,
<avri.altman@wdc.com>, <bvanassche@acm.org>,
<martin.petersen@oracle.com>, <chanho61.park@samsung.com>,
<pankaj.dubey@samsung.com>, <linux-fsd@tesla.com>,
"'Bharat Uppal'" <bharat.uppal@samsung.com>
Subject: RE: [PATCH 2/6] phy: samsung-ufs: move cdr offset to drvdata
Date: Fri, 3 Jun 2022 07:01:08 +0530 [thread overview]
Message-ID: <000b01d876e9$9bd36690$d37a33b0$@samsung.com> (raw)
In-Reply-To: <e92618c0-056c-5854-9bb3-5fba90a82d96@linaro.org>
>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
>Sent: Tuesday, May 31, 2022 3:26 PM
>To: Alim Akhtar <alim.akhtar@samsung.com>; linux-arm-
>kernel@lists.infradead.org; linux-kernel@vger.kernel.org; linux-
>scsi@vger.kernel.org; linux-phy@lists.infradead.org
>Cc: devicetree@vger.kernel.org; robh+dt@kernel.org;
>krzysztof.kozlowski+dt@linaro.org; vkoul@kernel.org; avri.altman@wdc.com;
>bvanassche@acm.org; martin.petersen@oracle.com;
>chanho61.park@samsung.com; pankaj.dubey@samsung.com; linux-
>fsd@tesla.com; Bharat Uppal <bharat.uppal@samsung.com>
>Subject: Re: [PATCH 2/6] phy: samsung-ufs: move cdr offset to drvdata
>
>On 31/05/2022 03:22, Alim Akhtar wrote:
>> Move CDR lock offset to drv data so that it can be extended for other
>> SoCs which are having CDR lock at different register offset.
>>
>> Cc: linux-fsd@tesla.com
>> Signed-off-by: Bharat Uppal <bharat.uppal@samsung.com>
>> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
>> ---
>> drivers/phy/samsung/phy-exynos7-ufs.c | 3 +++
>> drivers/phy/samsung/phy-exynosautov9-ufs.c | 2 ++
>> drivers/phy/samsung/phy-samsung-ufs.c | 3 ++-
>> drivers/phy/samsung/phy-samsung-ufs.h | 2 +-
>> 4 files changed, 8 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/phy/samsung/phy-exynos7-ufs.c
>> b/drivers/phy/samsung/phy-exynos7-ufs.c
>> index 7c9008e163db..d1a37273cb1f 100644
>> --- a/drivers/phy/samsung/phy-exynos7-ufs.c
>> +++ b/drivers/phy/samsung/phy-exynos7-ufs.c
>> @@ -11,6 +11,8 @@
>> #define EXYNOS7_EMBEDDED_COMBO_PHY_CTRL_MASK 0x1
>> #define EXYNOS7_EMBEDDED_COMBO_PHY_CTRL_EN BIT(0)
>>
>> +#define PHY_CDR_LOCK_STATUS 0x5e
>
>This should be now renamed to match other defines here, so
>EXYNOS7_EMBEDDED_COMBO_PHY_CDR_LOCK_STATUS
>
Sure, will update in next version
>
>Best regards,
>Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: "Alim Akhtar" <alim.akhtar@samsung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
<linux-phy@lists.infradead.org>
Cc: <devicetree@vger.kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <vkoul@kernel.org>,
<avri.altman@wdc.com>, <bvanassche@acm.org>,
<martin.petersen@oracle.com>, <chanho61.park@samsung.com>,
<pankaj.dubey@samsung.com>, <linux-fsd@tesla.com>,
"'Bharat Uppal'" <bharat.uppal@samsung.com>
Subject: RE: [PATCH 2/6] phy: samsung-ufs: move cdr offset to drvdata
Date: Fri, 3 Jun 2022 07:01:08 +0530 [thread overview]
Message-ID: <000b01d876e9$9bd36690$d37a33b0$@samsung.com> (raw)
In-Reply-To: <e92618c0-056c-5854-9bb3-5fba90a82d96@linaro.org>
>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
>Sent: Tuesday, May 31, 2022 3:26 PM
>To: Alim Akhtar <alim.akhtar@samsung.com>; linux-arm-
>kernel@lists.infradead.org; linux-kernel@vger.kernel.org; linux-
>scsi@vger.kernel.org; linux-phy@lists.infradead.org
>Cc: devicetree@vger.kernel.org; robh+dt@kernel.org;
>krzysztof.kozlowski+dt@linaro.org; vkoul@kernel.org; avri.altman@wdc.com;
>bvanassche@acm.org; martin.petersen@oracle.com;
>chanho61.park@samsung.com; pankaj.dubey@samsung.com; linux-
>fsd@tesla.com; Bharat Uppal <bharat.uppal@samsung.com>
>Subject: Re: [PATCH 2/6] phy: samsung-ufs: move cdr offset to drvdata
>
>On 31/05/2022 03:22, Alim Akhtar wrote:
>> Move CDR lock offset to drv data so that it can be extended for other
>> SoCs which are having CDR lock at different register offset.
>>
>> Cc: linux-fsd@tesla.com
>> Signed-off-by: Bharat Uppal <bharat.uppal@samsung.com>
>> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
>> ---
>> drivers/phy/samsung/phy-exynos7-ufs.c | 3 +++
>> drivers/phy/samsung/phy-exynosautov9-ufs.c | 2 ++
>> drivers/phy/samsung/phy-samsung-ufs.c | 3 ++-
>> drivers/phy/samsung/phy-samsung-ufs.h | 2 +-
>> 4 files changed, 8 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/phy/samsung/phy-exynos7-ufs.c
>> b/drivers/phy/samsung/phy-exynos7-ufs.c
>> index 7c9008e163db..d1a37273cb1f 100644
>> --- a/drivers/phy/samsung/phy-exynos7-ufs.c
>> +++ b/drivers/phy/samsung/phy-exynos7-ufs.c
>> @@ -11,6 +11,8 @@
>> #define EXYNOS7_EMBEDDED_COMBO_PHY_CTRL_MASK 0x1
>> #define EXYNOS7_EMBEDDED_COMBO_PHY_CTRL_EN BIT(0)
>>
>> +#define PHY_CDR_LOCK_STATUS 0x5e
>
>This should be now renamed to match other defines here, so
>EXYNOS7_EMBEDDED_COMBO_PHY_CDR_LOCK_STATUS
>
Sure, will update in next version
>
>Best regards,
>Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-03 1:31 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220531012331epcas5p23a835b3635e187ef04d4f28f0933f7c1@epcas5p2.samsung.com>
2022-05-31 1:22 ` [PATCH 0/6] Add support for UFS controller found in FSD SoC Alim Akhtar
2022-05-31 1:22 ` Alim Akhtar
2022-05-31 1:22 ` Alim Akhtar
2022-05-31 1:22 ` [PATCH 1/6] dt-bindings: phy: Add FSD UFS PHY bindings Alim Akhtar
2022-05-31 1:22 ` Alim Akhtar
2022-05-31 1:22 ` Alim Akhtar
2022-05-31 3:44 ` Bart Van Assche
2022-05-31 3:44 ` Bart Van Assche
2022-05-31 3:44 ` Bart Van Assche
2022-06-03 1:20 ` Alim Akhtar
2022-06-03 1:20 ` Alim Akhtar
2022-06-03 1:20 ` Alim Akhtar
2022-05-31 9:17 ` Krzysztof Kozlowski
2022-05-31 9:17 ` Krzysztof Kozlowski
2022-05-31 9:17 ` Krzysztof Kozlowski
2022-06-03 1:30 ` Alim Akhtar
2022-06-03 1:30 ` Alim Akhtar
2022-06-03 1:30 ` Alim Akhtar
2022-05-31 1:22 ` [PATCH 2/6] phy: samsung-ufs: move cdr offset to drvdata Alim Akhtar
2022-05-31 1:22 ` Alim Akhtar
2022-05-31 1:22 ` Alim Akhtar
2022-05-31 9:56 ` Krzysztof Kozlowski
2022-05-31 9:56 ` Krzysztof Kozlowski
2022-05-31 9:56 ` Krzysztof Kozlowski
2022-06-03 1:31 ` Alim Akhtar [this message]
2022-06-03 1:31 ` Alim Akhtar
2022-06-03 1:31 ` Alim Akhtar
2022-05-31 10:09 ` Krzysztof Kozlowski
2022-05-31 10:09 ` Krzysztof Kozlowski
2022-05-31 10:09 ` Krzysztof Kozlowski
2022-05-31 1:22 ` [PATCH 3/6] phy: samsung-ufs: add support for FSD ufs phy driver Alim Akhtar
2022-05-31 1:22 ` Alim Akhtar
2022-05-31 1:22 ` Alim Akhtar
2022-05-31 3:47 ` Bart Van Assche
2022-05-31 3:47 ` Bart Van Assche
2022-05-31 3:47 ` Bart Van Assche
2022-06-03 1:21 ` Alim Akhtar
2022-06-03 1:21 ` Alim Akhtar
2022-06-03 1:21 ` Alim Akhtar
2022-05-31 1:22 ` [PATCH 4/6] dt-bindings: ufs: exynos-ufs: add fsd compatible Alim Akhtar
2022-05-31 1:22 ` Alim Akhtar
2022-05-31 1:22 ` Alim Akhtar
2022-05-31 9:58 ` Krzysztof Kozlowski
2022-05-31 9:58 ` Krzysztof Kozlowski
2022-05-31 9:58 ` Krzysztof Kozlowski
2022-05-31 1:22 ` [PATCH 5/6] ufs: host: ufs-exynos: add support for fsd ufs hci Alim Akhtar
2022-05-31 1:22 ` Alim Akhtar
2022-05-31 1:22 ` Alim Akhtar
2022-05-31 7:37 ` Chanho Park
2022-05-31 7:37 ` Chanho Park
2022-05-31 7:37 ` Chanho Park
2022-06-03 1:42 ` Alim Akhtar
2022-06-03 1:42 ` Alim Akhtar
2022-06-03 1:42 ` Alim Akhtar
2022-05-31 10:01 ` Krzysztof Kozlowski
2022-05-31 10:01 ` Krzysztof Kozlowski
2022-05-31 10:01 ` Krzysztof Kozlowski
2022-05-31 1:22 ` [PATCH 6/6] arm64: dts: fsd: add ufs device node Alim Akhtar
2022-05-31 1:22 ` Alim Akhtar
2022-05-31 1:22 ` Alim Akhtar
2022-05-31 10:09 ` Krzysztof Kozlowski
2022-05-31 10:09 ` Krzysztof Kozlowski
2022-05-31 10:09 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000b01d876e9$9bd36690$d37a33b0$@samsung.com' \
--to=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=bharat.uppal@samsung.com \
--cc=bvanassche@acm.org \
--cc=chanho61.park@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fsd@tesla.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=pankaj.dubey@samsung.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.