From: "Shradha Todi" <shradha.t@samsung.com>
To: "'Bjorn Helgaas'" <helgaas@kernel.org>
Cc: <linux-pci@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-samsung-soc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-phy@lists.infradead.org>,
<mani@kernel.org>, <lpieralisi@kernel.org>,
<kwilczynski@kernel.org>, <robh@kernel.org>,
<bhelgaas@google.com>, <jingoohan1@gmail.com>,
<krzk+dt@kernel.org>, <conor+dt@kernel.org>,
<alim.akhtar@samsung.com>, <vkoul@kernel.org>,
<kishon@kernel.org>, <arnd@arndb.de>, <m.szyprowski@samsung.com>,
<jh80.chung@samsung.com>, <pankaj.dubey@samsung.com>
Subject: RE: [PATCH v3 05/12] PCI: exynos: Add resource ops, soc variant and device mode
Date: Mon, 18 Aug 2025 14:51:34 +0530 [thread overview]
Message-ID: <000c01dc1021$803abad0$80b03070$@samsung.com> (raw)
In-Reply-To: <20250813230733.GA299608@bhelgaas>
> > Some resources might differ based on platforms and we need platform
> > specific functions to initialize or alter them. For better code
> > re-usability, making a separate res_ops which will hold all such
> > function pointers or other resource specific data. Include ops like
> > - init_regulator (initialize the regulator data)
> > - pcie_irq_handler (interrupt handler for PCIe)
> > - set_device_mode (set device mode to EP or RC)
> >
> > Some operations maybe specific to certain SoCs and not applicable
> > to others. For such use cases, adding an SoC variant data field
> > which can be used to distinguish between the variants.
> >
> > Some SoCs may have dual-role PCIe controller which can work as
> > RC or EP. Add device_mode to store the role and take decisions
> > accordingly.
> >
> > Make enable/disable of regulator and initialization of IRQ as
> > common functions to be used by all Samsung SoCs.
>
> As hinted above, this patch ends up being a mixture of several things
> that makes this kind of hard to review. Separating these into their
> own patches would make it easier.
>
Will split into multiple patches
WARNING: multiple messages have this Message-ID (diff)
From: "Shradha Todi" <shradha.t@samsung.com>
To: "'Bjorn Helgaas'" <helgaas@kernel.org>
Cc: <linux-pci@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-samsung-soc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-phy@lists.infradead.org>,
<mani@kernel.org>, <lpieralisi@kernel.org>,
<kwilczynski@kernel.org>, <robh@kernel.org>,
<bhelgaas@google.com>, <jingoohan1@gmail.com>,
<krzk+dt@kernel.org>, <conor+dt@kernel.org>,
<alim.akhtar@samsung.com>, <vkoul@kernel.org>,
<kishon@kernel.org>, <arnd@arndb.de>, <m.szyprowski@samsung.com>,
<jh80.chung@samsung.com>, <pankaj.dubey@samsung.com>
Subject: RE: [PATCH v3 05/12] PCI: exynos: Add resource ops, soc variant and device mode
Date: Mon, 18 Aug 2025 14:51:34 +0530 [thread overview]
Message-ID: <000c01dc1021$803abad0$80b03070$@samsung.com> (raw)
In-Reply-To: <20250813230733.GA299608@bhelgaas>
> > Some resources might differ based on platforms and we need platform
> > specific functions to initialize or alter them. For better code
> > re-usability, making a separate res_ops which will hold all such
> > function pointers or other resource specific data. Include ops like
> > - init_regulator (initialize the regulator data)
> > - pcie_irq_handler (interrupt handler for PCIe)
> > - set_device_mode (set device mode to EP or RC)
> >
> > Some operations maybe specific to certain SoCs and not applicable
> > to others. For such use cases, adding an SoC variant data field
> > which can be used to distinguish between the variants.
> >
> > Some SoCs may have dual-role PCIe controller which can work as
> > RC or EP. Add device_mode to store the role and take decisions
> > accordingly.
> >
> > Make enable/disable of regulator and initialization of IRQ as
> > common functions to be used by all Samsung SoCs.
>
> As hinted above, this patch ends up being a mixture of several things
> that makes this kind of hard to review. Separating these into their
> own patches would make it easier.
>
Will split into multiple patches
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2025-08-18 18:06 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250811154648epcas5p4e55cc82e0df7d44ea55e249fef63d5fa@epcas5p4.samsung.com>
2025-08-11 15:46 ` [PATCH v3 00/12] Add PCIe support for Tesla FSD SoC Shradha Todi
2025-08-11 15:46 ` Shradha Todi
2025-08-11 15:46 ` [PATCH v3 01/12] PCI: exynos: Remove unused MACROs in exynos PCIe file Shradha Todi
2025-08-11 15:46 ` Shradha Todi
2025-08-11 15:46 ` [PATCH v3 02/12] PCI: exynos: Change macro names to exynos specific Shradha Todi
2025-08-11 15:46 ` Shradha Todi
2025-08-11 15:46 ` [PATCH v3 03/12] PCI: exynos: Reorder MACROs to maintain consistency Shradha Todi
2025-08-11 15:46 ` Shradha Todi
2025-08-11 15:46 ` [PATCH v3 04/12] PCI: exynos: Add platform device private data Shradha Todi
2025-08-11 15:46 ` Shradha Todi
2025-08-11 15:46 ` [PATCH v3 05/12] PCI: exynos: Add resource ops, soc variant and device mode Shradha Todi
2025-08-11 15:46 ` Shradha Todi
2025-08-13 23:07 ` Bjorn Helgaas
2025-08-13 23:07 ` Bjorn Helgaas
2025-08-18 9:21 ` Shradha Todi [this message]
2025-08-18 9:21 ` Shradha Todi
2025-08-11 15:46 ` [PATCH v3 06/12] dt-bindings: PCI: Split exynos host into two files Shradha Todi
2025-08-11 15:46 ` Shradha Todi
2025-08-12 6:32 ` Krzysztof Kozlowski
2025-08-12 6:32 ` Krzysztof Kozlowski
2025-08-18 8:41 ` Shradha Todi
2025-08-18 8:41 ` Shradha Todi
2025-08-11 15:46 ` [PATCH v3 07/12] dt-bindings: PCI: Add support for Tesla FSD SoC Shradha Todi
2025-08-11 15:46 ` Shradha Todi
2025-08-12 6:37 ` Krzysztof Kozlowski
2025-08-12 6:37 ` Krzysztof Kozlowski
2025-08-18 8:46 ` Shradha Todi
2025-08-18 8:46 ` Shradha Todi
2025-08-30 3:21 ` Manivannan Sadhasivam
2025-08-30 3:21 ` Manivannan Sadhasivam
2025-08-30 3:27 ` Manivannan Sadhasivam
2025-08-30 3:27 ` Manivannan Sadhasivam
2025-08-11 15:46 ` [PATCH v3 08/12] dt-bindings: phy: Add PCIe PHY support for " Shradha Todi
2025-08-11 15:46 ` Shradha Todi
2025-08-14 8:13 ` Krzysztof Kozlowski
2025-08-14 8:13 ` Krzysztof Kozlowski
2025-08-11 15:46 ` [PATCH v3 09/12] phy: exynos: Add platform device private data Shradha Todi
2025-08-11 15:46 ` Shradha Todi
2025-08-11 15:46 ` [PATCH v3 10/12] phy: exynos: Add PCIe PHY support for FSD SoC Shradha Todi
2025-08-11 15:46 ` Shradha Todi
2025-09-01 12:11 ` Vinod Koul
2025-09-01 12:11 ` Vinod Koul
2025-08-11 15:46 ` [PATCH v3 11/12] PCI: exynos: Add support for Tesla " Shradha Todi
2025-08-11 15:46 ` Shradha Todi
2025-08-13 23:07 ` Bjorn Helgaas
2025-08-13 23:07 ` Bjorn Helgaas
2025-08-18 9:30 ` Shradha Todi
2025-08-18 9:30 ` Shradha Todi
2025-08-18 18:25 ` Bjorn Helgaas
2025-08-18 18:25 ` Bjorn Helgaas
2025-08-19 6:34 ` Krzysztof Kozlowski
2025-08-19 6:34 ` Krzysztof Kozlowski
2025-08-19 11:18 ` Shradha Todi
2025-08-19 11:18 ` Shradha Todi
2025-08-19 11:39 ` Shradha Todi
2025-08-19 11:39 ` Shradha Todi
2025-08-19 15:07 ` Bjorn Helgaas
2025-08-19 15:07 ` Bjorn Helgaas
2025-08-30 3:54 ` Manivannan Sadhasivam
2025-08-30 3:54 ` Manivannan Sadhasivam
2025-08-11 15:46 ` [PATCH v3 12/12] arm64: dts: fsd: Add PCIe " Shradha Todi
2025-08-11 15:46 ` Shradha Todi
2025-08-12 6:43 ` Krzysztof Kozlowski
2025-08-12 6:43 ` Krzysztof Kozlowski
2025-08-18 8:54 ` Shradha Todi
2025-08-18 8:54 ` Shradha Todi
2025-08-30 3:58 ` Manivannan Sadhasivam
2025-08-30 3:58 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000c01dc1021$803abad0$80b03070$@samsung.com' \
--to=shradha.t@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=helgaas@kernel.org \
--cc=jh80.chung@samsung.com \
--cc=jingoohan1@gmail.com \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mani@kernel.org \
--cc=pankaj.dubey@samsung.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.