All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rune" <runner@mail.tele.dk>
To: <linux-kernel@vger.kernel.org>, <ollie@sis.com.tw>
Subject: [fix 2.5] fix sis900 <-> Crossfire 8720 (switch) auto-negotiation, please test
Date: Fri, 14 Feb 2003 00:58:01 +0100	[thread overview]
Message-ID: <000e01c2d3bb$be3c1970$0b00a8c0@runner> (raw)

[-- Attachment #1: Type: text/plain, Size: 485 bytes --]

Hi,
by accident I discovered a fix for auto-negotiation on the sis-900.

in sis900_open(), sis900_check_mode() looks redundant, and when removing it
auto-negotiation works for sis900 and Crossfire 8720 (perhaps others).

I have tested it, but I have no ideas if there is any side effects,
so please test this on non-Crossfire setups.

the patch is made against 2.5.60-bk2 but this code havent changed for a long
time.
for some reason this has no effect on kernel 2.4...

Rune Petersen

[-- Attachment #2: sis900.diff --]
[-- Type: application/octet-stream, Size: 395 bytes --]

--- sis900.c.orig	2003-02-14 05:52:06.000000000 +0100
+++ sis900.c	2003-02-14 06:16:29.000000000 +0100
@@ -937,8 +937,6 @@
 	outl(RxENA | inl(ioaddr + cr), ioaddr + cr);
 	outl(IE, ioaddr + ier);
 
-	sis900_check_mode(net_dev, sis_priv->mii);
-
 	/* Set the timer to switch to check for link beat and perhaps switch
 	   to an alternate media type. */
 	init_timer(&sis_priv->timer);

                 reply	other threads:[~2003-02-13 23:50 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000e01c2d3bb$be3c1970$0b00a8c0@runner' \
    --to=runner@mail.tele.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ollie@sis.com.tw \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.