All of lore.kernel.org
 help / color / mirror / Atom feed
* [fix 2.5] fix sis900 <-> Crossfire 8720 (switch) auto-negotiation, please test
@ 2003-02-13 23:58 Rune
  0 siblings, 0 replies; only message in thread
From: Rune @ 2003-02-13 23:58 UTC (permalink / raw)
  To: linux-kernel, ollie

[-- Attachment #1: Type: text/plain, Size: 485 bytes --]

Hi,
by accident I discovered a fix for auto-negotiation on the sis-900.

in sis900_open(), sis900_check_mode() looks redundant, and when removing it
auto-negotiation works for sis900 and Crossfire 8720 (perhaps others).

I have tested it, but I have no ideas if there is any side effects,
so please test this on non-Crossfire setups.

the patch is made against 2.5.60-bk2 but this code havent changed for a long
time.
for some reason this has no effect on kernel 2.4...

Rune Petersen

[-- Attachment #2: sis900.diff --]
[-- Type: application/octet-stream, Size: 395 bytes --]

--- sis900.c.orig	2003-02-14 05:52:06.000000000 +0100
+++ sis900.c	2003-02-14 06:16:29.000000000 +0100
@@ -937,8 +937,6 @@
 	outl(RxENA | inl(ioaddr + cr), ioaddr + cr);
 	outl(IE, ioaddr + ier);
 
-	sis900_check_mode(net_dev, sis_priv->mii);
-
 	/* Set the timer to switch to check for link beat and perhaps switch
 	   to an alternate media type. */
 	init_timer(&sis_priv->timer);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2003-02-13 23:50 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-02-13 23:58 [fix 2.5] fix sis900 <-> Crossfire 8720 (switch) auto-negotiation, please test Rune

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.