All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cho KyongHo <pullip.cho-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
To: 'Sachin Kamat' <sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: 'Linux DeviceTree'
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	'Linux Samsung SOC'
	<linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	'Prathyush' <prathyush.k-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	'Grant Grundler'
	<grundler-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	'Linux Kernel'
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	'Linux IOMMU'
	<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
	'Kukjin Kim' <kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	'Sylwester Nawrocki'
	<s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	'Varun Sethi'
	<Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
	'Antonios Motakis'
	<a.motakis-lrHrjnjw1UfHK3s98zE1ajGjJy/sRE9J@public.gmane.org>,
	'Tomasz Figa' <t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	'Linux ARM Kernel'
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	'Rahul Sharma'
	<rahul.sharma-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Subject: RE: [PATCH v11 01/27] iommu/exynos: do not include removed header
Date: Fri, 14 Mar 2014 20:49:18 +0900	[thread overview]
Message-ID: <000e01cf3f7b$6edcdfd0$4c969f70$@samsung.com> (raw)
In-Reply-To: <CAK9yfHzRasE3jroDUZgAa=DN5N=2ZDAxgNiHDCip+f2868BAVQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

> From: Sachin Kamat [mailto:sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org]
> Sent: Friday, March 14, 2014 7:00 PM
> 
> On 14 March 2014 10:31, Cho KyongHo <pullip.cho-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> > Commit 25e9d28d92 (ARM: EXYNOS: remove system mmu initialization from
> > exynos tree) removed arch/arm/mach-exynos/mach/sysmmu.h header without
> > removing remaining use of it from exynos-iommu driver, thus causing a
> > compilation error.
> >
> > This patch fixes the error by removing respective include line
> > from exynos-iommu.c.
> >
> > CC: Tomasz Figa <t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> > Signed-off-by: Cho KyongHo <pullip.cho-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> > ---
> >  drivers/iommu/exynos-iommu.c |    3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c
> > index 0740189..4876d35 100644
> > --- a/drivers/iommu/exynos-iommu.c
> > +++ b/drivers/iommu/exynos-iommu.c
> > @@ -12,6 +12,7 @@
> >  #define DEBUG
> >  #endif
> >
> > +#include <linux/kernel.h>
> 
> This change doesn't look related to the patch subject/description.
> 
Yes. But it is simply added without any side-effect.
Do you think it should be in a separate patch?.
Actually, the added line is a redundant.

Regards,

KyongHo.

WARNING: multiple messages have this Message-ID (diff)
From: pullip.cho@samsung.com (Cho KyongHo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v11 01/27] iommu/exynos: do not include removed header
Date: Fri, 14 Mar 2014 20:49:18 +0900	[thread overview]
Message-ID: <000e01cf3f7b$6edcdfd0$4c969f70$@samsung.com> (raw)
In-Reply-To: <CAK9yfHzRasE3jroDUZgAa=DN5N=2ZDAxgNiHDCip+f2868BAVQ@mail.gmail.com>

> From: Sachin Kamat [mailto:sachin.kamat at linaro.org]
> Sent: Friday, March 14, 2014 7:00 PM
> 
> On 14 March 2014 10:31, Cho KyongHo <pullip.cho@samsung.com> wrote:
> > Commit 25e9d28d92 (ARM: EXYNOS: remove system mmu initialization from
> > exynos tree) removed arch/arm/mach-exynos/mach/sysmmu.h header without
> > removing remaining use of it from exynos-iommu driver, thus causing a
> > compilation error.
> >
> > This patch fixes the error by removing respective include line
> > from exynos-iommu.c.
> >
> > CC: Tomasz Figa <t.figa@samsung.com>
> > Signed-off-by: Cho KyongHo <pullip.cho@samsung.com>
> > ---
> >  drivers/iommu/exynos-iommu.c |    3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c
> > index 0740189..4876d35 100644
> > --- a/drivers/iommu/exynos-iommu.c
> > +++ b/drivers/iommu/exynos-iommu.c
> > @@ -12,6 +12,7 @@
> >  #define DEBUG
> >  #endif
> >
> > +#include <linux/kernel.h>
> 
> This change doesn't look related to the patch subject/description.
> 
Yes. But it is simply added without any side-effect.
Do you think it should be in a separate patch?.
Actually, the added line is a redundant.

Regards,

KyongHo.

WARNING: multiple messages have this Message-ID (diff)
From: Cho KyongHo <pullip.cho@samsung.com>
To: "'Sachin Kamat'" <sachin.kamat@linaro.org>
Cc: "'Linux ARM Kernel'" <linux-arm-kernel@lists.infradead.org>,
	"'Linux DeviceTree'" <devicetree@vger.kernel.org>,
	"'Linux IOMMU'" <iommu@lists.linux-foundation.org>,
	"'Linux Kernel'" <linux-kernel@vger.kernel.org>,
	"'Linux Samsung SOC'" <linux-samsung-soc@vger.kernel.org>,
	"'Antonios Motakis'" <a.motakis@virtualopensystems.com>,
	"'Grant Grundler'" <grundler@chromium.org>,
	"'Joerg Roedel'" <joro@8bytes.org>,
	"'Kukjin Kim'" <kgene.kim@samsung.com>,
	"'Prathyush'" <prathyush.k@samsung.com>,
	"'Rahul Sharma'" <rahul.sharma@samsung.com>,
	"'Varun Sethi'" <Varun.Sethi@freescale.com>,
	"'Sylwester Nawrocki'" <s.nawrocki@samsung.com>,
	"'Tomasz Figa'" <t.figa@samsung.com>
Subject: RE: [PATCH v11 01/27] iommu/exynos: do not include removed header
Date: Fri, 14 Mar 2014 20:49:18 +0900	[thread overview]
Message-ID: <000e01cf3f7b$6edcdfd0$4c969f70$@samsung.com> (raw)
In-Reply-To: <CAK9yfHzRasE3jroDUZgAa=DN5N=2ZDAxgNiHDCip+f2868BAVQ@mail.gmail.com>

> From: Sachin Kamat [mailto:sachin.kamat@linaro.org]
> Sent: Friday, March 14, 2014 7:00 PM
> 
> On 14 March 2014 10:31, Cho KyongHo <pullip.cho@samsung.com> wrote:
> > Commit 25e9d28d92 (ARM: EXYNOS: remove system mmu initialization from
> > exynos tree) removed arch/arm/mach-exynos/mach/sysmmu.h header without
> > removing remaining use of it from exynos-iommu driver, thus causing a
> > compilation error.
> >
> > This patch fixes the error by removing respective include line
> > from exynos-iommu.c.
> >
> > CC: Tomasz Figa <t.figa@samsung.com>
> > Signed-off-by: Cho KyongHo <pullip.cho@samsung.com>
> > ---
> >  drivers/iommu/exynos-iommu.c |    3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c
> > index 0740189..4876d35 100644
> > --- a/drivers/iommu/exynos-iommu.c
> > +++ b/drivers/iommu/exynos-iommu.c
> > @@ -12,6 +12,7 @@
> >  #define DEBUG
> >  #endif
> >
> > +#include <linux/kernel.h>
> 
> This change doesn't look related to the patch subject/description.
> 
Yes. But it is simply added without any side-effect.
Do you think it should be in a separate patch?.
Actually, the added line is a redundant.

Regards,

KyongHo.


  parent reply	other threads:[~2014-03-14 11:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-14  5:01 [PATCH v11 01/27] iommu/exynos: do not include removed header Cho KyongHo
2014-03-14  5:01 ` Cho KyongHo
2014-03-14  5:01 ` Cho KyongHo
     [not found] ` <20140314140129.68a41cc1bd9e0a48a198ca13-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-03-14  9:59   ` Sachin Kamat
2014-03-14  9:59     ` Sachin Kamat
2014-03-14  9:59     ` Sachin Kamat
     [not found]     ` <CAK9yfHzRasE3jroDUZgAa=DN5N=2ZDAxgNiHDCip+f2868BAVQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-03-14 11:49       ` Cho KyongHo [this message]
2014-03-14 11:49         ` Cho KyongHo
2014-03-14 11:49         ` Cho KyongHo
2014-03-14 11:59         ` Sachin Kamat
2014-03-14 11:59           ` Sachin Kamat
2014-03-14 11:59           ` Sachin Kamat
     [not found]           ` <CAK9yfHyGfdP+0RKtdSCdU4tO=PX8GbQRQ7ar=ST5B2RenZMMsg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-03-17  0:26             ` Cho KyongHo
2014-03-17  0:26               ` Cho KyongHo
2014-03-17  0:26               ` Cho KyongHo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000e01cf3f7b$6edcdfd0$4c969f70$@samsung.com' \
    --to=pullip.cho-sze3o3uu22jbdgjk7y7tuq@public.gmane.org \
    --cc=Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
    --cc=a.motakis-lrHrjnjw1UfHK3s98zE1ajGjJy/sRE9J@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=grundler-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=prathyush.k-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=rahul.sharma-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.