All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH V2 3/7] watchdog: mv64x60_wdt: use devm_ioremap()
@ 2013-04-30  5:00 Jingoo Han
  2013-05-25 19:10 ` Wim Van Sebroeck
  0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-04-30  5:00 UTC (permalink / raw)
  To: 'Andrew Morton'
  Cc: linux-kernel, 'Wim Van Sebroeck', linux-watchdog,
	'Guenter Roeck', Jingoo Han

Use devm_ioremap() to make cleanup paths simpler.

Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
No changes since v1:

 drivers/watchdog/mv64x60_wdt.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/watchdog/mv64x60_wdt.c b/drivers/watchdog/mv64x60_wdt.c
index c7fb878..e4cf980 100644
--- a/drivers/watchdog/mv64x60_wdt.c
+++ b/drivers/watchdog/mv64x60_wdt.c
@@ -276,7 +276,7 @@ static int mv64x60_wdt_probe(struct platform_device *dev)
 	if (!r)
 		return -ENODEV;
 
-	mv64x60_wdt_regs = ioremap(r->start, resource_size(r));
+	mv64x60_wdt_regs = devm_ioremap(&dev->dev, r->start, resource_size(r));
 	if (mv64x60_wdt_regs == NULL)
 		return -ENOMEM;
 
@@ -293,8 +293,6 @@ static int mv64x60_wdt_remove(struct platform_device *dev)
 
 	mv64x60_wdt_handler_disable();
 
-	iounmap(mv64x60_wdt_regs);
-
 	return 0;
 }
 
-- 
1.7.2.5



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH V2 3/7] watchdog: mv64x60_wdt: use devm_ioremap()
  2013-04-30  5:00 [PATCH V2 3/7] watchdog: mv64x60_wdt: use devm_ioremap() Jingoo Han
@ 2013-05-25 19:10 ` Wim Van Sebroeck
  0 siblings, 0 replies; 2+ messages in thread
From: Wim Van Sebroeck @ 2013-05-25 19:10 UTC (permalink / raw)
  To: Jingoo Han
  Cc: 'Andrew Morton', linux-kernel, linux-watchdog,
	'Guenter Roeck'

Hi Jingoo,

> Use devm_ioremap() to make cleanup paths simpler.
> 
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> No changes since v1:
> 
>  drivers/watchdog/mv64x60_wdt.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
> 

Patch added to linux-watchdog-next.

Kind regards,
Wim.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-05-25 19:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-30  5:00 [PATCH V2 3/7] watchdog: mv64x60_wdt: use devm_ioremap() Jingoo Han
2013-05-25 19:10 ` Wim Van Sebroeck

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.