From: wufan <wufan@codeaurora.org>
To: 'James Morse' <james.morse@arm.com>
Cc: mchehab@kernel.org, bp@alien8.de, baicar.tyler@gmail.com,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: EDAC, ghes: use CPER module handles to locate DIMMs
Date: Thu, 30 Aug 2018 10:45:03 -0600 [thread overview]
Message-ID: <001101d44080$cd2a73d0$677f5b70$@codeaurora.org> (raw)
Hi James,
> > For ghes_edac the bank/device is informational, and nothing would go
> > wrong if the bank/device numbers are the same as another entry. But
> > the handle is now critical for DIMM lookup, thus pull it out.
>
> Is printing the handle to the kernel log critical?
>
> I'd expect something collecting errors to read from sysfs, not dmesg. I
> thought the whole point here was to update the per-dimm counters in sysfs.
No, printing out the handle is not critical. What I meant is because the
information is critical it would be nice to have it available for debugging
purpose. Otherwise it would be hard to find the handle if bank/device
is not accurate.
Thanks,
Fan
WARNING: multiple messages have this Message-ID (diff)
From: wufan@codeaurora.org (wufan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] EDAC, ghes: use CPER module handles to locate DIMMs
Date: Thu, 30 Aug 2018 10:45:03 -0600 [thread overview]
Message-ID: <001101d44080$cd2a73d0$677f5b70$@codeaurora.org> (raw)
In-Reply-To: <1ac15a80-6f9a-cf9d-8e79-37d10549a4ca@arm.com>
Hi James,
> > For ghes_edac the bank/device is informational, and nothing would go
> > wrong if the bank/device numbers are the same as another entry. But
> > the handle is now critical for DIMM lookup, thus pull it out.
>
> Is printing the handle to the kernel log critical?
>
> I'd expect something collecting errors to read from sysfs, not dmesg. I
> thought the whole point here was to update the per-dimm counters in sysfs.
No, printing out the handle is not critical. What I meant is because the
information is critical it would be nice to have it available for debugging
purpose. Otherwise it would be hard to find the handle if bank/device
is not accurate.
Thanks,
Fan
WARNING: multiple messages have this Message-ID (diff)
From: "wufan" <wufan@codeaurora.org>
To: "'James Morse'" <james.morse@arm.com>
Cc: <mchehab@kernel.org>, <bp@alien8.de>, <baicar.tyler@gmail.com>,
<linux-edac@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH] EDAC, ghes: use CPER module handles to locate DIMMs
Date: Thu, 30 Aug 2018 10:45:03 -0600 [thread overview]
Message-ID: <001101d44080$cd2a73d0$677f5b70$@codeaurora.org> (raw)
In-Reply-To: <1ac15a80-6f9a-cf9d-8e79-37d10549a4ca@arm.com>
Hi James,
> > For ghes_edac the bank/device is informational, and nothing would go
> > wrong if the bank/device numbers are the same as another entry. But
> > the handle is now critical for DIMM lookup, thus pull it out.
>
> Is printing the handle to the kernel log critical?
>
> I'd expect something collecting errors to read from sysfs, not dmesg. I
> thought the whole point here was to update the per-dimm counters in sysfs.
No, printing out the handle is not critical. What I meant is because the
information is critical it would be nice to have it available for debugging
purpose. Otherwise it would be hard to find the handle if bank/device
is not accurate.
Thanks,
Fan
next reply other threads:[~2018-08-30 16:45 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 16:45 wufan [this message]
2018-08-30 16:45 ` [PATCH] EDAC, ghes: use CPER module handles to locate DIMMs wufan
2018-08-30 16:45 ` wufan
-- strict thread matches above, loose matches on Subject: below --
2018-09-03 19:18 Borislav Petkov
2018-09-03 19:18 ` [PATCH] " Borislav Petkov
2018-09-03 19:18 ` Borislav Petkov
2018-09-03 15:05 wufan
2018-09-03 15:05 ` [PATCH] " wufan
2018-09-03 15:05 ` wufan
2018-08-31 10:06 tanxiaofei
2018-08-31 10:06 ` [PATCH] " tanxiaofei
2018-08-31 10:06 ` tanxiaofei
2018-08-30 17:11 wufan
2018-08-30 17:11 ` [PATCH] " wufan
2018-08-30 17:11 ` wufan
2018-08-30 16:50 John Garry
2018-08-30 16:50 ` [PATCH] " John Garry
2018-08-30 16:50 ` John Garry
2018-08-30 16:46 Tyler Baicar
2018-08-30 16:46 ` [PATCH] " Tyler Baicar
2018-08-30 16:46 ` Tyler Baicar
2018-08-30 16:34 James Morse
2018-08-30 16:34 ` [PATCH] " James Morse
2018-08-30 16:34 ` James Morse
2018-08-30 16:34 James Morse
2018-08-30 16:34 ` [PATCH] " James Morse
2018-08-30 16:34 ` James Morse
2018-08-30 16:32 James Morse
2018-08-30 16:32 ` [PATCH] " James Morse
2018-08-30 16:32 ` James Morse
2018-08-30 15:12 Borislav Petkov
2018-08-30 15:12 ` [PATCH] " Boris Petkov
2018-08-30 15:12 ` Boris Petkov
2018-08-30 14:40 wufan
2018-08-30 14:40 ` [PATCH] " wufan
2018-08-30 14:40 ` wufan
2018-08-30 14:20 wufan
2018-08-30 14:20 ` [PATCH] " wufan
2018-08-30 14:20 ` wufan
2018-08-30 10:48 James Morse
2018-08-30 10:48 ` [PATCH] " James Morse
2018-08-30 10:48 ` James Morse
2018-08-30 10:43 Borislav Petkov
2018-08-30 10:43 ` [PATCH] " Borislav Petkov
2018-08-30 10:43 ` Borislav Petkov
2018-08-29 18:33 wufan
2018-08-29 18:33 ` [PATCH] " Fan Wu
2018-08-29 18:33 ` Fan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001101d44080$cd2a73d0$677f5b70$@codeaurora.org' \
--to=wufan@codeaurora.org \
--cc=baicar.tyler@gmail.com \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.