From: Jingoo Han <jg1.han@samsung.com>
To: 'David Miller' <davem@davemloft.net>
Cc: dan.carpenter@oracle.com, kumargauravgupta3@gmail.com,
emilio@elopez.com.ar, mugunthanvnm@ti.com,
hsweeten@visionengravers.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, Jingoo Han <jg1.han@samsung.com>
Subject: Re: [PATCH] net:ethernet:korina.c Removed IRQF_DISABLED
Date: Fri, 09 Aug 2013 00:59:54 +0000 [thread overview]
Message-ID: <001401ce949b$c2937b10$47ba7130$@samsung.com> (raw)
In-Reply-To: <20130808.142054.1541424422807503741.davem@davemloft.net>
On Friday, August 09, 2013 6:21 AM, David Miller wrote:
> On Fri, 9 Aug 2013 00:09:18 +0300, Dan Carpenter wrote:
> > On Fri, Aug 09, 2013 at 12:50:49AM +0530, Kumar Gaurav wrote:
> >> Removed IRQF_DISABLED as it's no-op and should be removed
> >>
> >
> > What? No, that doesn't sound right.
>
> The IRQ layer completely ignores the flag for several releases
> now, it's a complete no-op as his commit message so adequately
> states.
Yes, you're right. :-)
Currently, 'IRQF_DISABLED' is deprecated as below.
(include/linux/interrupt.h)
* IRQF_DISABLED - keep irqs disabled when calling the action handler.
* DEPRECATED. This flag is a NOOP and scheduled to be removed
Best regards,
Jingoo Han
>
> So what's the problem again? :-)
WARNING: multiple messages have this Message-ID (diff)
From: Jingoo Han <jg1.han@samsung.com>
To: 'David Miller' <davem@davemloft.net>
Cc: dan.carpenter@oracle.com, kumargauravgupta3@gmail.com,
emilio@elopez.com.ar, mugunthanvnm@ti.com,
hsweeten@visionengravers.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, Jingoo Han <jg1.han@samsung.com>
Subject: Re: [PATCH] net:ethernet:korina.c Removed IRQF_DISABLED
Date: Fri, 09 Aug 2013 09:59:54 +0900 [thread overview]
Message-ID: <001401ce949b$c2937b10$47ba7130$@samsung.com> (raw)
In-Reply-To: <20130808.142054.1541424422807503741.davem@davemloft.net>
On Friday, August 09, 2013 6:21 AM, David Miller wrote:
> On Fri, 9 Aug 2013 00:09:18 +0300, Dan Carpenter wrote:
> > On Fri, Aug 09, 2013 at 12:50:49AM +0530, Kumar Gaurav wrote:
> >> Removed IRQF_DISABLED as it's no-op and should be removed
> >>
> >
> > What? No, that doesn't sound right.
>
> The IRQ layer completely ignores the flag for several releases
> now, it's a complete no-op as his commit message so adequately
> states.
Yes, you're right. :-)
Currently, 'IRQF_DISABLED' is deprecated as below.
(include/linux/interrupt.h)
* IRQF_DISABLED - keep irqs disabled when calling the action handler.
* DEPRECATED. This flag is a NOOP and scheduled to be removed
Best regards,
Jingoo Han
>
> So what's the problem again? :-)
next prev parent reply other threads:[~2013-08-09 0:59 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 19:20 [PATCH] net:ethernet:korina.c Removed IRQF_DISABLED Kumar Gaurav
2013-08-08 19:32 ` Kumar Gaurav
2013-08-08 21:09 ` Dan Carpenter
2013-08-08 21:09 ` Dan Carpenter
2013-08-08 21:11 ` Sergei Shtylyov
2013-08-08 21:11 ` Sergei Shtylyov
2013-08-08 21:20 ` David Miller
2013-08-08 21:20 ` David Miller
2013-08-08 21:23 ` Dan Carpenter
2013-08-08 21:23 ` Dan Carpenter
2013-08-08 21:33 ` Joe Perches
2013-08-08 21:33 ` Joe Perches
2013-08-09 2:24 ` Kumar Gaurav
2013-08-09 2:36 ` Kumar Gaurav
2013-08-09 2:39 ` Joe Perches
2013-08-09 2:39 ` Joe Perches
2013-08-09 2:45 ` Kumar Gaurav
2013-08-09 2:57 ` Kumar Gaurav
2013-08-09 2:54 ` Joe Perches
2013-08-09 2:54 ` Joe Perches
2013-08-09 3:00 ` Kumar Gaurav
2013-08-09 3:12 ` Kumar Gaurav
2013-08-09 3:10 ` Joe Perches
2013-08-09 3:10 ` Joe Perches
2013-08-09 3:28 ` Joe Perches
2013-08-09 3:28 ` Joe Perches
2013-08-09 3:38 ` Kumar Gaurav
2013-08-09 3:50 ` Kumar Gaurav
2013-08-09 13:15 ` Peter Senna Tschudin
2013-08-09 13:15 ` Peter Senna Tschudin
2013-08-09 15:14 ` Joe Perches
2013-08-09 15:14 ` Joe Perches
2013-08-09 15:53 ` Peter Senna Tschudin
2013-08-09 15:53 ` Peter Senna Tschudin
2013-08-09 16:28 ` Joe Perches
2013-08-09 16:28 ` Joe Perches
2013-08-09 7:11 ` walter harms
2013-08-09 7:11 ` walter harms
2013-08-09 0:59 ` Jingoo Han [this message]
2013-08-09 0:59 ` Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001401ce949b$c2937b10$47ba7130$@samsung.com' \
--to=jg1.han@samsung.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=emilio@elopez.com.ar \
--cc=hsweeten@visionengravers.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kumargauravgupta3@gmail.com \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.