Re: [dpdk-dev] [RFC] remove unused functions

["Jiawen Wu" <jiawenwu@trustnetic.com>]

On Thursday, November 19, 2020 11:53 AM, Ferruh Yigit wrote:
> Removing unused functions, reported by cppcheck.
> 
> Easy way to remove clutter, since the code is already in the git repo,
> they can be added back when needed.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
>  drivers/net/txgbe/base/txgbe_eeprom.c         |   72 -
>  drivers/net/txgbe/base/txgbe_eeprom.h         |    2 -
>
> diff --git a/drivers/net/txgbe/base/txgbe_eeprom.c
> b/drivers/net/txgbe/base/txgbe_eeprom.c
> index 72cd3ff307..fedaecf26d 100644
> --- a/drivers/net/txgbe/base/txgbe_eeprom.c
> +++ b/drivers/net/txgbe/base/txgbe_eeprom.c
> @@ -274,42 +274,6 @@ s32 txgbe_ee_read32(struct txgbe_hw *hw, u32
> addr, u32 *data)
>  	return err;
>  }
> 
> -/**
> - *  txgbe_ee_read_buffer - Read EEPROM byte(s) using hostif
> - *  @hw: pointer to hardware structure
> - *  @addr: offset of bytes in the EEPROM to read
> - *  @len: number of bytes
> - *  @data: byte(s) read from the EEPROM
> - *
> - *  Reads a 8 bit byte(s) from the EEPROM using the hostif.
> - **/
> -s32 txgbe_ee_read_buffer(struct txgbe_hw *hw,
> -				     u32 addr, u32 len, void *data)
> -{
> -	const u32 mask = TXGBE_MNGSEM_SWMBX |
> TXGBE_MNGSEM_SWFLASH;
> -	u8 *buf = (u8 *)data;
> -	int err;
> -
> -	err = hw->mac.acquire_swfw_sync(hw, mask);
> -	if (err)
> -		return err;
> -
> -	while (len) {
> -		u32 seg = (len <= TXGBE_PMMBX_DATA_SIZE
> -				? len : TXGBE_PMMBX_DATA_SIZE);
> -
> -		err = txgbe_hic_sr_read(hw, addr, buf, seg);
> -		if (err)
> -			break;
> -
> -		len -= seg;
> -		buf += seg;
> -	}
> -
> -	hw->mac.release_swfw_sync(hw, mask);
> -	return err;
> -}
> -
>  /**
>   *  txgbe_ee_write - Write EEPROM word using hostif
>   *  @hw: pointer to hardware structure
> @@ -420,42 +384,6 @@ s32 txgbe_ee_write32(struct txgbe_hw *hw, u32
> addr, u32 data)
>  	return err;
>  }
> 
> -/**
> - *  txgbe_ee_write_buffer - Write EEPROM byte(s) using hostif
> - *  @hw: pointer to hardware structure
> - *  @addr: offset of bytes in the EEPROM to write
> - *  @len: number of bytes
> - *  @data: word(s) write to the EEPROM
> - *
> - *  Write a 8 bit byte(s) to the EEPROM using the hostif.
> - **/
> -s32 txgbe_ee_write_buffer(struct txgbe_hw *hw,
> -				      u32 addr, u32 len, void *data)
> -{
> -	const u32 mask = TXGBE_MNGSEM_SWMBX |
> TXGBE_MNGSEM_SWFLASH;
> -	u8 *buf = (u8 *)data;
> -	int err;
> -
> -	err = hw->mac.acquire_swfw_sync(hw, mask);
> -	if (err)
> -		return err;
> -
> -	while (len) {
> -		u32 seg = (len <= TXGBE_PMMBX_DATA_SIZE
> -				? len : TXGBE_PMMBX_DATA_SIZE);
> -
> -		err = txgbe_hic_sr_write(hw, addr, buf, seg);
> -		if (err)
> -			break;
> -
> -		len -= seg;
> -		buf += seg;
> -	}
> -
> -	hw->mac.release_swfw_sync(hw, mask);
> -	return err;
> -}
> -
>  /**
>   *  txgbe_calc_eeprom_checksum - Calculates and returns the checksum
>   *  @hw: pointer to hardware structure
> diff --git a/drivers/net/txgbe/base/txgbe_eeprom.h
> b/drivers/net/txgbe/base/txgbe_eeprom.h
> index d0e142dba5..78b8af978b 100644
> --- a/drivers/net/txgbe/base/txgbe_eeprom.h
> +++ b/drivers/net/txgbe/base/txgbe_eeprom.h
> @@ -51,14 +51,12 @@ s32 txgbe_ee_readw_sw(struct txgbe_hw *hw, u32
> offset, u16 *data);
>  s32 txgbe_ee_readw_buffer(struct txgbe_hw *hw, u32 offset, u32 words,
>  				void *data);
>  s32 txgbe_ee_read32(struct txgbe_hw *hw, u32 addr, u32 *data);
> -s32 txgbe_ee_read_buffer(struct txgbe_hw *hw, u32 addr, u32 len, void
> *data);
> 
>  s32 txgbe_ee_write16(struct txgbe_hw *hw, u32 offset, u16 data);
>  s32 txgbe_ee_writew_sw(struct txgbe_hw *hw, u32 offset, u16 data);
>  s32 txgbe_ee_writew_buffer(struct txgbe_hw *hw, u32 offset, u32 words,
>  				void *data);
>  s32 txgbe_ee_write32(struct txgbe_hw *hw, u32 addr, u32 data);
> -s32 txgbe_ee_write_buffer(struct txgbe_hw *hw, u32 addr, u32 len, void
> *data);
> 
> 
>  #endif /* _TXGBE_EEPROM_H_ */

Reviewed-by: Jiawen Wu <jiawenwu@trustnetic.com>

Thanks.