From: Stephen Hemminger <stephen@networkplumber.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Jerin Jacob <jerinj@marvell.com>,
Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Sachin Saxena <sachin.saxena@oss.nxp.com>,
Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>,
Rosen Xu <rosen.xu@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Beilei Xing <beilei.xing@intel.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>,
Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>,
Vikas Gupta <vikas.gupta@broadcom.com>,
Gagandeep Singh <g.singh@nxp.com>,
Somalapuram Amaranath <asomalap@amd.com>,
Akhil Goyal <akhil.goyal@nxp.com>,
Jay Zhou <jianjay.zhou@huawei.com>,
Timothy McDaniel <timothy.mcdaniel@intel.com>,
Liang Ma <liang.j.ma@intel.com>,
Peter Mccarthy <peter.mccarthy@intel.com>,
Shepard Siegel <shepard.siegel@atomicrules.com>,
Ed Czeck <ed.czeck@atomicrules.com>,
John Miller <john.miller@atomicrules.com>,
Igor Russkikh <igor.russkikh@aquantia.com>,
Pavel Belous <pavel.belous@aquantia.com>,
Rasesh Mody <rmody@marvell.com>,
Shahed Shaikh <shshaikh@marvell.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Chas Williams <chas3@att.com>,
"Min Hu (Connor)" <humin29@huawei.com>,
Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
Jeff Guo <jia.guo@intel.com>, Haiyue Wang <haiyue.wang@intel.com>,
Marcin Wojtas <mw@semihalf.com>,
Michal Krawczyk <mk@semihalf.com>,
Guy Tzalik <gtzalik@amazon.com>,
Evgeny Schemeilin <evgenys@amazon.com>,
Igor Chauskin <igorch@amazon.com>,
Qi Zhang <qi.z.zhang@intel.com>,
Xiao Wang <xiao.w.wang@intel.com>,
Qiming Yang <qiming.yang@intel.com>,
Alfredo Cardigliano <cardigliano@ntop.org>,
Matan Azrad <matan@nvidia.com>,
Shahaf Shuler <shahafs@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Zyta Szpak <zr@semihalf.com>, Liron Himi <lironh@marvell.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
"K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Long Li <longli@microsoft.com>,
Heinrich Kuhn <heinrich.kuhn@netronome.com>,
Harman Kalra <hkalra@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Jasvinder Singh <jasvinder.singh@intel.com>,
Jiawen Wu <jiawenwu@trustnetic.com>,
Jian Wang <jianwang@trustnetic.com>,
Tianfei zhang <tianfei.zhang@intel.com>,
Ori Kam <orika@nvidia.com>, Guy Kaneti <guyk@marvell.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
Chenbo Xia <chenbo.xia@intel.com>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [RFC] remove unused functions
Date: Thu, 19 Nov 2020 11:01:14 -0800 [thread overview]
Message-ID: <20201119110114.3886e2a1@hermes.local> (raw)
In-Reply-To: <20201119035238.3653702-1-ferruh.yigit@intel.com>
On Thu, 19 Nov 2020 03:52:36 +0000
Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> drivers/net/netvsc/hn_rndis.c | 31 -
> drivers/net/netvsc/hn_rndis.h | 1 -
> drivers/net/netvsc/hn_var.h | 3 -
> drivers/net/netvsc/hn_vf.c | 25 -
Thanks this found some real bugs.
1. The get_supported_ptypes is wrong, the driver should just not support it.
2. VF stats need to get reset
3. VX tx_queue release call needs to be added.
Sent tentative patches off for testing.
next prev parent reply other threads:[~2020-11-19 19:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 3:52 [dpdk-dev] [RFC] remove unused functions Ferruh Yigit
2020-11-19 7:22 ` Xu, Rosen
2020-11-19 19:01 ` Stephen Hemminger [this message]
2020-11-23 2:55 ` Zhang, Tianfei
2020-11-23 9:56 ` Ferruh Yigit
2020-11-23 16:07 ` Stephen Hemminger
2020-11-24 10:01 ` Zhang, Tianfei
2020-11-24 10:00 ` Zhang, Tianfei
2020-11-24 10:26 ` Ferruh Yigit
2020-11-24 11:01 ` Zhang, Tianfei
2020-11-24 11:31 ` Ferruh Yigit
2020-11-24 12:17 ` Zhang, Tianfei
2020-11-23 16:20 ` Maxime Coquelin
2020-11-24 3:32 ` Jiawen Wu
2021-02-11 11:29 ` Burakov, Anatoly
2023-06-14 21:59 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201119110114.3886e2a1@hermes.local \
--to=stephen@networkplumber.org \
--cc=ajit.khaparde@broadcom.com \
--cc=akhil.goyal@nxp.com \
--cc=anatoly.burakov@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=asomalap@amd.com \
--cc=beilei.xing@intel.com \
--cc=cardigliano@ntop.org \
--cc=chas3@att.com \
--cc=chenbo.xia@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=ed.czeck@atomicrules.com \
--cc=evgenys@amazon.com \
--cc=ferruh.yigit@intel.com \
--cc=g.singh@nxp.com \
--cc=gtzalik@amazon.com \
--cc=guyk@marvell.com \
--cc=haiyangz@microsoft.com \
--cc=haiyue.wang@intel.com \
--cc=heinrich.kuhn@netronome.com \
--cc=hemant.agrawal@nxp.com \
--cc=hkalra@marvell.com \
--cc=humin29@huawei.com \
--cc=igor.russkikh@aquantia.com \
--cc=igorch@amazon.com \
--cc=jasvinder.singh@intel.com \
--cc=jerinj@marvell.com \
--cc=jia.guo@intel.com \
--cc=jianjay.zhou@huawei.com \
--cc=jianwang@trustnetic.com \
--cc=jiawenwu@trustnetic.com \
--cc=jingjing.wu@intel.com \
--cc=john.miller@atomicrules.com \
--cc=kirankumark@marvell.com \
--cc=kys@microsoft.com \
--cc=liang.j.ma@intel.com \
--cc=lironh@marvell.com \
--cc=longli@microsoft.com \
--cc=matan@nvidia.com \
--cc=maxime.coquelin@redhat.com \
--cc=mdr@ashroe.eu \
--cc=mk@semihalf.com \
--cc=mw@semihalf.com \
--cc=ndabilpuram@marvell.com \
--cc=nhorman@tuxdriver.com \
--cc=orika@nvidia.com \
--cc=pavel.belous@aquantia.com \
--cc=peter.mccarthy@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=rahul.lakkireddy@chelsio.com \
--cc=raveendra.padasalagi@broadcom.com \
--cc=rmody@marvell.com \
--cc=rosen.xu@intel.com \
--cc=sachin.saxena@oss.nxp.com \
--cc=shahafs@nvidia.com \
--cc=shepard.siegel@atomicrules.com \
--cc=shshaikh@marvell.com \
--cc=somnath.kotur@broadcom.com \
--cc=sthemmin@microsoft.com \
--cc=tianfei.zhang@intel.com \
--cc=timothy.mcdaniel@intel.com \
--cc=viacheslavo@nvidia.com \
--cc=vikas.gupta@broadcom.com \
--cc=xiao.w.wang@intel.com \
--cc=zr@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.