From: Jingoo Han <jg1.han@samsung.com>
To: 'Tejun Heo' <tj@kernel.org>
Cc: linux-ide@vger.kernel.org, Jingoo Han <jg1.han@samsung.com>
Subject: Re: [PATCH V2] ata: use pci_get_drvdata()
Date: Mon, 03 Jun 2013 13:55:14 +0900 [thread overview]
Message-ID: <001f01ce6016$8938c870$9baa5950$@samsung.com> (raw)
In-Reply-To: <20130603043356.GF6071@mtj.dyndns.org>
On Monday, June 03, 2013 1:34 PM, Tejun Heo wrote:
> On Mon, Jun 03, 2013 at 01:22:41PM +0900, Jingoo Han wrote:
> > Use the wrapper functions for getting the driver data using pci_dev
> > instead of using dev_get,set_drvdata() with &pdev->dev, so we can
I will fix this typo:
dev_get,set_drvdata() -> dev_get_drvdata()
> > directly pass a struct pci_dev.
> >
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> > ---
> > Changes since v1:
> > - Fix the commit message from pci_{get,set}_drvdata() to pci_get_drvdata()
>
> Ummm... wouldn't using pci_set_drvdata() make things more consistent?
Usually, both pci_set_drvdata() and pci_get_drvdata() are used.
But, I cannot find where pci_set_drvdata() can be used in ./drivers/ata/*.
> Also, what about the other comment that I made? Is this purely
> cosmetic or is there some other change which is gonna depend on it?
This is purely _cosmetic_. There are no other changes.
Best regards,
Jingoo Han
>
> Thanks.
>
> --
> tejun
prev parent reply other threads:[~2013-06-03 4:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 4:22 [PATCH V2] ata: use pci_get_drvdata() Jingoo Han
2013-06-03 4:33 ` 'Tejun Heo'
2013-06-03 4:55 ` Jingoo Han [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001f01ce6016$8938c870$9baa5950$@samsung.com' \
--to=jg1.han@samsung.com \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.