All of lore.kernel.org
 help / color / mirror / Atom feed
From: 'Tejun Heo' <tj@kernel.org>
To: Jingoo Han <jg1.han@samsung.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH V2] ata: use pci_get_drvdata()
Date: Sun, 2 Jun 2013 21:33:56 -0700	[thread overview]
Message-ID: <20130603043356.GF6071@mtj.dyndns.org> (raw)
In-Reply-To: <001b01ce6011$fcc96290$f65c27b0$@samsung.com>

On Mon, Jun 03, 2013 at 01:22:41PM +0900, Jingoo Han wrote:
> Use the wrapper functions for getting the driver data using pci_dev
> instead of using dev_get,set_drvdata() with &pdev->dev, so we can
> directly pass a struct pci_dev.
> 
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> Changes since v1:
> - Fix the commit message from pci_{get,set}_drvdata() to pci_get_drvdata()

Ummm... wouldn't using pci_set_drvdata() make things more consistent?
Also, what about the other comment that I made?  Is this purely
cosmetic or is there some other change which is gonna depend on it?

Thanks.

-- 
tejun

  reply	other threads:[~2013-06-03  4:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-03  4:22 [PATCH V2] ata: use pci_get_drvdata() Jingoo Han
2013-06-03  4:33 ` 'Tejun Heo' [this message]
2013-06-03  4:55   ` Jingoo Han

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130603043356.GF6071@mtj.dyndns.org \
    --to=tj@kernel.org \
    --cc=jg1.han@samsung.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.