[PATCH] ntb_transport: Remove unnecessary call to ntb_peer_spad_read.

[PATCH] ntb_transport: Remove unnecessary call to ntb_peer_spad_read.

[Steven Wahl]

The results were previously ignored, anyway.

Signed-off-by: Steve Wahl <Steve.Wahl@dell.com>
---
 drivers/ntb/ntb_transport.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c
index 4eb8adb..cd9a392 100644
--- a/drivers/ntb/ntb_transport.c
+++ b/drivers/ntb/ntb_transport.c
@@ -960,7 +960,6 @@ static void ntb_qp_link_work(struct work_struct *work)
        ntb_peer_spad_write(nt->ndev, QP_LINKS, val | BIT(qp->qp_num));

        /* query remote spad for qp ready bits */
-       ntb_peer_spad_read(nt->ndev, QP_LINKS);
        dev_dbg_ratelimited(&pdev->dev, "Remote QP link status = %x\n", val);

        /* See if the remote side is up */
--
2.7.4

RE: [PATCH] ntb_transport: Remove unnecessary call to ntb_peer_spad_read.

[Allen Hubbe]

From: Steven Wahl 
> The results were previously ignored, anyway.
> 
> Signed-off-by: Steve Wahl <Steve.Wahl@dell.com>

Fixes: e26a5843f7f5014ae4460030ca4de029a3ac35d3

Acked-by: Allen Hubbe <Allen.Hubbe@dell.com>

> ---
>  drivers/ntb/ntb_transport.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c
> index 4eb8adb..cd9a392 100644
> --- a/drivers/ntb/ntb_transport.c
> +++ b/drivers/ntb/ntb_transport.c
> @@ -960,7 +960,6 @@ static void ntb_qp_link_work(struct work_struct *work)
>         ntb_peer_spad_write(nt->ndev, QP_LINKS, val | BIT(qp->qp_num));
> 
>         /* query remote spad for qp ready bits */
> -       ntb_peer_spad_read(nt->ndev, QP_LINKS);
>         dev_dbg_ratelimited(&pdev->dev, "Remote QP link status = %x\n", val);
> 
>         /* See if the remote side is up */
> --
> 2.7.4

Re: [PATCH] ntb_transport: Remove unnecessary call to ntb_peer_spad_read.

[Jon Mason]

On Thu, Dec 08, 2016 at 12:16:45PM -0500, Allen Hubbe wrote:
> From: Steven Wahl 
> > The results were previously ignored, anyway.
> > 
> > Signed-off-by: Steve Wahl <Steve.Wahl@dell.com>
> 
> Fixes: e26a5843f7f5014ae4460030ca4de029a3ac35d3
> 
> Acked-by: Allen Hubbe <Allen.Hubbe@dell.com>


This patch also didn't apply cleanly.  I hand applied it, as it was a
simple patch.

Thanks,
Jon

> 
> > ---
> >  drivers/ntb/ntb_transport.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c
> > index 4eb8adb..cd9a392 100644
> > --- a/drivers/ntb/ntb_transport.c
> > +++ b/drivers/ntb/ntb_transport.c
> > @@ -960,7 +960,6 @@ static void ntb_qp_link_work(struct work_struct *work)
> >         ntb_peer_spad_write(nt->ndev, QP_LINKS, val | BIT(qp->qp_num));
> > 
> >         /* query remote spad for qp ready bits */
> > -       ntb_peer_spad_read(nt->ndev, QP_LINKS);
> >         dev_dbg_ratelimited(&pdev->dev, "Remote QP link status = %x\n", val);
> > 
> >         /* See if the remote side is up */
> > --
> > 2.7.4
> 
> -- 
> You received this message because you are subscribed to the Google Groups "linux-ntb" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-ntb+unsubscribe@googlegroups.com.
> To post to this group, send email to linux-ntb@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/linux-ntb/002001d25176%24da7cabc0%248f760340%24%40dell.com.
> For more options, visit https://groups.google.com/d/optout.