All of lore.kernel.org
 help / color / mirror / Atom feed
From: 이경택 <gt82.lee@samsung.com>
To: <lgirdwood@gmail.com>, <broonie@kernel.org>, <tiwai@suse.com>,
	<vkoul@kernel.org>
Cc: alsa-devel@alsa-project.org
Subject: [PATCH 0/1] ASoC: soc-compress: lock pcm_mutex to resolve lockdep error
Date: Mon, 30 Mar 2020 20:01:25 +0900	[thread overview]
Message-ID: <002001d60682$8e75d390$ab617ab0$@samsung.com> (raw)
In-Reply-To: 

Hi, Mark

I resend the patch and add recipient Vinod as your comment.
Thank you.


I'd like to send a patch to fix a problem using soc-compress with DPCM.
soc_compr_open_fe() and soc_compr_free_fe() call snd_soc_runtime_activate()
and snd_soc_runtime_deactivate() but don't lock card->pcm_mutex.
It can cause lockdep error, because snd_soc_runtime_activate/deactivate()
checks whether pcm_mutex is held using lockdep_assert_held().
I'd like to send a patch which adds mutex_lock/unlock() before and after of
the snd_soc_runtime_activate/deactivate() call.
If there is anything should be changed in my patch or email, please let me
know it.
I'll really appreciate it.

Lee

Gyeongtaek Lee (1):
  ASoC: soc-compress: lock pcm_mutex to resolve lockdep error

 sound/soc/soc-compress.c | 4 ++++
 1 file changed, 4 insertions(+)


base-commit: 76ccd234269bd05debdbc12c96eafe62dd9a6180
--
2.21.0



       reply	other threads:[~2020-03-30 11:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200330110126epcas2p291039a9be404c41725d3577e4cd3058f@epcas2p2.samsung.com>
2020-03-30 11:01 ` 이경택 [this message]
     [not found] <CGME20200326084556epcas2p43870d47530ef1381e52e2ca85d196298@epcas2p4.samsung.com>
2020-03-26  8:45 ` [PATCH 0/1] ASoC: soc-compress: lock pcm_mutex to resolve lockdep error 이경택

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='002001d60682$8e75d390$ab617ab0$@samsung.com' \
    --to=gt82.lee@samsung.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=tiwai@suse.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.