* [PATCH 0/1] ASoC: soc-compress: lock pcm_mutex to resolve lockdep error
[not found] <CGME20200330110126epcas2p291039a9be404c41725d3577e4cd3058f@epcas2p2.samsung.com>
@ 2020-03-30 11:01 ` 이경택
0 siblings, 0 replies; 2+ messages in thread
From: 이경택 @ 2020-03-30 11:01 UTC (permalink / raw)
To: lgirdwood, broonie, tiwai, vkoul; +Cc: alsa-devel
Hi, Mark
I resend the patch and add recipient Vinod as your comment.
Thank you.
I'd like to send a patch to fix a problem using soc-compress with DPCM.
soc_compr_open_fe() and soc_compr_free_fe() call snd_soc_runtime_activate()
and snd_soc_runtime_deactivate() but don't lock card->pcm_mutex.
It can cause lockdep error, because snd_soc_runtime_activate/deactivate()
checks whether pcm_mutex is held using lockdep_assert_held().
I'd like to send a patch which adds mutex_lock/unlock() before and after of
the snd_soc_runtime_activate/deactivate() call.
If there is anything should be changed in my patch or email, please let me
know it.
I'll really appreciate it.
Lee
Gyeongtaek Lee (1):
ASoC: soc-compress: lock pcm_mutex to resolve lockdep error
sound/soc/soc-compress.c | 4 ++++
1 file changed, 4 insertions(+)
base-commit: 76ccd234269bd05debdbc12c96eafe62dd9a6180
--
2.21.0
^ permalink raw reply [flat|nested] 2+ messages in thread
[parent not found: <CGME20200326084556epcas2p43870d47530ef1381e52e2ca85d196298@epcas2p4.samsung.com>]
* [PATCH 0/1] ASoC: soc-compress: lock pcm_mutex to resolve lockdep error
[not found] <CGME20200326084556epcas2p43870d47530ef1381e52e2ca85d196298@epcas2p4.samsung.com>
@ 2020-03-26 8:45 ` 이경택
0 siblings, 0 replies; 2+ messages in thread
From: 이경택 @ 2020-03-26 8:45 UTC (permalink / raw)
To: lgirdwood, broonie, tiwai; +Cc: alsa-devel
Hi,
I'd like to send a patch to fix a problem using soc-compress with DPCM.
soc_compr_open_fe() and soc_compr_free_fe() call snd_soc_runtime_activate()
and snd_soc_runtime_deactivate() but don't lock card->pcm_mutex.
It can cause lockdep error, because snd_soc_runtime_activate/deactivate()
checks whether pcm_mutex is held using lockdep_assert_held().
I'd like to send a patch which adds mutex_lock/unlock()
before and after of the snd_soc_runtime_activate/deactivate() call.
If there is anything should be changed in my patch or email,
please let me know it.
I'll really appreciate it.
Gyeongtaek Lee (1):
ASoC: soc-compress: lock pcm_mutex to resolve lockdep error
sound/soc/soc-compress.c | 4 ++++
1 file changed, 4 insertions(+)
base-commit: 76ccd234269bd05debdbc12c96eafe62dd9a6180
--
2.21.0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-30 11:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20200330110126epcas2p291039a9be404c41725d3577e4cd3058f@epcas2p2.samsung.com>
2020-03-30 11:01 ` [PATCH 0/1] ASoC: soc-compress: lock pcm_mutex to resolve lockdep error 이경택
[not found] <CGME20200326084556epcas2p43870d47530ef1381e52e2ca85d196298@epcas2p4.samsung.com>
2020-03-26 8:45 ` 이경택
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.