All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Chanho Park" <chanho61.park@samsung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
	"'Kishon Vijay Abraham I'" <kishon@ti.com>,
	"'Vinod Koul'" <vkoul@kernel.org>,
	"'James E . J . Bottomley'" <jejb@linux.ibm.com>,
	"'Martin K . Petersen'" <martin.petersen@oracle.com>,
	"'Alim Akhtar'" <alim.akhtar@samsung.com>,
	"'Bart Van Assche'" <bvanassche@acm.org>
Cc: <linux-phy@lists.infradead.org>, <linux-scsi@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-samsung-soc@vger.kernel.org>
Subject: RE: [PATCH 3/3] ufs: ufs-exynos: change ufs phy control sequence
Date: Wed, 6 Jul 2022 10:51:40 +0900	[thread overview]
Message-ID: <002301d890da$efc75d00$cf561700$@samsung.com> (raw)
In-Reply-To: <d23604f8-f6b3-0f2f-6ab0-418a6fb9549f@linaro.org>

> > Since commit 1599069a62c6 ("phy: core: Warn when phy_power_on is
> > called before phy_init"), below warning has been reported.
> >
> > phy_power_on was called before phy_init
> >
> > To address this, we need to remove phy_power_on from
> > exynos_ufs_phy_init and move it after phy_init. phy_power_off and
> > phy_exit are also necessary in exynos_ufs_remove.
> >
> > Signed-off-by: Chanho Park <chanho61.park@samsung.com>
> > ---
> >  drivers/ufs/host/ufs-exynos.c | 13 +++++++------
> >  1 file changed, 7 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/ufs/host/ufs-exynos.c
> > b/drivers/ufs/host/ufs-exynos.c index f971569bafc7..5718296e2521
> > 100644
> > --- a/drivers/ufs/host/ufs-exynos.c
> > +++ b/drivers/ufs/host/ufs-exynos.c
> > @@ -908,6 +908,8 @@ static int exynos_ufs_phy_init(struct exynos_ufs
> *ufs)
> >  		goto out_exit_phy;
> >  	}
> >
> > +	phy_power_on(generic_phy);
> 
> 
> What about phy_power_on() return code?

I'll back the check next patch.

Best Regards,
Chanho Park


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: "Chanho Park" <chanho61.park@samsung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
	"'Kishon Vijay Abraham I'" <kishon@ti.com>,
	"'Vinod Koul'" <vkoul@kernel.org>,
	"'James E . J . Bottomley'" <jejb@linux.ibm.com>,
	"'Martin K . Petersen'" <martin.petersen@oracle.com>,
	"'Alim Akhtar'" <alim.akhtar@samsung.com>,
	"'Bart Van Assche'" <bvanassche@acm.org>
Cc: <linux-phy@lists.infradead.org>, <linux-scsi@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-samsung-soc@vger.kernel.org>
Subject: RE: [PATCH 3/3] ufs: ufs-exynos: change ufs phy control sequence
Date: Wed, 6 Jul 2022 10:51:40 +0900	[thread overview]
Message-ID: <002301d890da$efc75d00$cf561700$@samsung.com> (raw)
In-Reply-To: <d23604f8-f6b3-0f2f-6ab0-418a6fb9549f@linaro.org>

> > Since commit 1599069a62c6 ("phy: core: Warn when phy_power_on is
> > called before phy_init"), below warning has been reported.
> >
> > phy_power_on was called before phy_init
> >
> > To address this, we need to remove phy_power_on from
> > exynos_ufs_phy_init and move it after phy_init. phy_power_off and
> > phy_exit are also necessary in exynos_ufs_remove.
> >
> > Signed-off-by: Chanho Park <chanho61.park@samsung.com>
> > ---
> >  drivers/ufs/host/ufs-exynos.c | 13 +++++++------
> >  1 file changed, 7 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/ufs/host/ufs-exynos.c
> > b/drivers/ufs/host/ufs-exynos.c index f971569bafc7..5718296e2521
> > 100644
> > --- a/drivers/ufs/host/ufs-exynos.c
> > +++ b/drivers/ufs/host/ufs-exynos.c
> > @@ -908,6 +908,8 @@ static int exynos_ufs_phy_init(struct exynos_ufs
> *ufs)
> >  		goto out_exit_phy;
> >  	}
> >
> > +	phy_power_on(generic_phy);
> 
> 
> What about phy_power_on() return code?

I'll back the check next patch.

Best Regards,
Chanho Park


WARNING: multiple messages have this Message-ID (diff)
From: "Chanho Park" <chanho61.park@samsung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
	"'Kishon Vijay Abraham I'" <kishon@ti.com>,
	"'Vinod Koul'" <vkoul@kernel.org>,
	"'James E . J . Bottomley'" <jejb@linux.ibm.com>,
	"'Martin K . Petersen'" <martin.petersen@oracle.com>,
	"'Alim Akhtar'" <alim.akhtar@samsung.com>,
	"'Bart Van Assche'" <bvanassche@acm.org>
Cc: <linux-phy@lists.infradead.org>, <linux-scsi@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-samsung-soc@vger.kernel.org>
Subject: RE: [PATCH 3/3] ufs: ufs-exynos: change ufs phy control sequence
Date: Wed, 6 Jul 2022 10:51:40 +0900	[thread overview]
Message-ID: <002301d890da$efc75d00$cf561700$@samsung.com> (raw)
In-Reply-To: <d23604f8-f6b3-0f2f-6ab0-418a6fb9549f@linaro.org>

> > Since commit 1599069a62c6 ("phy: core: Warn when phy_power_on is
> > called before phy_init"), below warning has been reported.
> >
> > phy_power_on was called before phy_init
> >
> > To address this, we need to remove phy_power_on from
> > exynos_ufs_phy_init and move it after phy_init. phy_power_off and
> > phy_exit are also necessary in exynos_ufs_remove.
> >
> > Signed-off-by: Chanho Park <chanho61.park@samsung.com>
> > ---
> >  drivers/ufs/host/ufs-exynos.c | 13 +++++++------
> >  1 file changed, 7 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/ufs/host/ufs-exynos.c
> > b/drivers/ufs/host/ufs-exynos.c index f971569bafc7..5718296e2521
> > 100644
> > --- a/drivers/ufs/host/ufs-exynos.c
> > +++ b/drivers/ufs/host/ufs-exynos.c
> > @@ -908,6 +908,8 @@ static int exynos_ufs_phy_init(struct exynos_ufs
> *ufs)
> >  		goto out_exit_phy;
> >  	}
> >
> > +	phy_power_on(generic_phy);
> 
> 
> What about phy_power_on() return code?

I'll back the check next patch.

Best Regards,
Chanho Park


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-07-06  1:51 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20220705065722epcas2p3fad39b3edf1a0fd1789de77997bf5728@epcas2p3.samsung.com>
2022-07-05  6:54 ` [PATCH 0/3] change exynos ufs phy control Chanho Park
2022-07-05  6:54   ` Chanho Park
2022-07-05  6:54   ` Chanho Park
2022-07-05  6:54   ` [PATCH 1/3] phy: samsung-ufs: convert phy clk usage to clk_bulk API Chanho Park
2022-07-05  6:54     ` Chanho Park
2022-07-05  6:54     ` Chanho Park
2022-07-05  9:30     ` Krzysztof Kozlowski
2022-07-05  9:30       ` Krzysztof Kozlowski
2022-07-05  9:30       ` Krzysztof Kozlowski
2022-07-05  6:54   ` [PATCH 2/3] phy: samsung-ufs: ufs: change phy on/off control Chanho Park
2022-07-05  6:54     ` Chanho Park
2022-07-05  6:54     ` Chanho Park
2022-07-05  9:33     ` Krzysztof Kozlowski
2022-07-05  9:33       ` Krzysztof Kozlowski
2022-07-05  9:33       ` Krzysztof Kozlowski
2022-07-05  6:54   ` [PATCH 3/3] ufs: ufs-exynos: change ufs phy control sequence Chanho Park
2022-07-05  6:54     ` Chanho Park
2022-07-05  6:54     ` Chanho Park
2022-07-05  9:36     ` Krzysztof Kozlowski
2022-07-05  9:36       ` Krzysztof Kozlowski
2022-07-05  9:36       ` Krzysztof Kozlowski
2022-07-06  1:51       ` Chanho Park [this message]
2022-07-06  1:51         ` Chanho Park
2022-07-06  1:51         ` Chanho Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='002301d890da$efc75d00$cf561700$@samsung.com' \
    --to=chanho61.park@samsung.com \
    --cc=alim.akhtar@samsung.com \
    --cc=bvanassche@acm.org \
    --cc=jejb@linux.ibm.com \
    --cc=kishon@ti.com \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.