Resume after suspend broken, reboots instead on kernel 6.1 onwards x86_64 RTW88

Resume after suspend broken, reboots instead on kernel 6.1 onwards x86_64 RTW88

[Paul Gover]

Suspend/Resume was working OK on kernel 6.0.13, broken since 6.1.1
(I've not tried kernels between those, except in the bisect below.)
All subsequent 6,1 kernels exhibit the same behaviour.

Suspend works OK, but on Resume, there's a flicker, and then it reboots.
Sometimes the screen gets restored to its contents at the time of suspend. but 
less than a second later, it starts rebooting.
To reproduce, simply boot, suspend, and resume.

Git bisect blames RTW88
commit 6bf3a083407b5d404d70efc3a5ac75b472e5efa9

I'll attach bisect log, dmesg and configs to the bug I've opened 
	https://bugzilla.kernel.org/show_bug.cgi?id=217016

dmesg from the following boot show a hardware error.
It's not there when the system resumes or reboots with 6.0.13,
and if I don't suspend & resume, there are no reported errors.

The problem occurs under both Wayland and X11, and from the command line via 
echo mem>/sys/power.state


Vanilla kernels, untainted, compiled with GCC; my system is Gentoo FWIW, but I 
do my own kernels direct from a git clone of stable.

Couldn't find anything similar with Google or the mailing lists.

**Hardware:**

HP Laptop 15-bw0xx
AMD A9-9420 RADEON R5, 5 COMPUTE CORES
Stoney [Radeon R2/R3/R4/R5 Graphics]
4 GB memory
RTL8723DE PCIe adapter

**Kernel**

Kernel command line:
psmouse.synaptics_intertouch=1 pcie_aspm=force rdrand=force rootfstype=f2fs 
root=LABEL=gentoo

CONFIG_RTW88=m
CONFIG_RTW88_CORE=m
CONFIG_RTW88_PCI=m
CONFIG_RTW88_8723D=m
# CONFIG_RTW88_8822BE is not set
# CONFIG_RTW88_8822CE is not set
CONFIG_RTW88_8723DE=m
# CONFIG_RTW88_8821CE is not set
# CONFIG_RTW88_DEBUG is not set
# CONFIG_RTW88_DEBUGFS is not set
# CONFIG_RTW89 is not set

Re: Resume after suspend broken, reboots instead on kernel 6.1 onwards x86_64 RTW88

[Linux kernel regression tracking (Thorsten Leemhuis)]

[adding Chih-Kang Chang (author), Kalle (committer) and LKML to the list
of recipients]

[anyone who replies to this: feel free to remove stable@vger.kernel.org
from the recipients, this is a mainline regression]

[TLDR: I'm adding this report to the list of tracked Linux kernel
regressions; the text you find below is based on a few templates
paragraphs you might have encountered already in similar form.
See link in footer if these mails annoy you.]

On 09.02.23 20:59, Paul Gover wrote:
> Suspend/Resume was working OK on kernel 6.0.13, broken since 6.1.1
> (I've not tried kernels between those, except in the bisect below.)
> All subsequent 6,1 kernels exhibit the same behaviour.
> 
> Suspend works OK, but on Resume, there's a flicker, and then it reboots.
> Sometimes the screen gets restored to its contents at the time of suspend. but 
> less than a second later, it starts rebooting.
> To reproduce, simply boot, suspend, and resume.
> 
> Git bisect blames RTW88
> commit 6bf3a083407b5d404d70efc3a5ac75b472e5efa9

TWIMC, that's "wifi: rtw88: add flag check before enter or leave IPS"

> I'll attach bisect log, dmesg and configs to the bug I've opened 
> 	https://bugzilla.kernel.org/show_bug.cgi?id=217016
> 
> dmesg from the following boot show a hardware error.
> It's not there when the system resumes or reboots with 6.0.13,
> and if I don't suspend & resume, there are no reported errors.
> 
> The problem occurs under both Wayland and X11, and from the command line via 
> echo mem>/sys/power.state
> 
> 
> Vanilla kernels, untainted, compiled with GCC; my system is Gentoo FWIW, but I 
> do my own kernels direct from a git clone of stable.
> 
> Couldn't find anything similar with Google or the mailing lists.
> 
> **Hardware:**
> 
> HP Laptop 15-bw0xx
> AMD A9-9420 RADEON R5, 5 COMPUTE CORES
> Stoney [Radeon R2/R3/R4/R5 Graphics]
> 4 GB memory
> RTL8723DE PCIe adapter
> 
> **Kernel**
> 
> Kernel command line:
> psmouse.synaptics_intertouch=1 pcie_aspm=force rdrand=force rootfstype=f2fs 
> root=LABEL=gentoo
> 
> CONFIG_RTW88=m
> CONFIG_RTW88_CORE=m
> CONFIG_RTW88_PCI=m
> CONFIG_RTW88_8723D=m
> # CONFIG_RTW88_8822BE is not set
> # CONFIG_RTW88_8822CE is not set
> CONFIG_RTW88_8723DE=m
> # CONFIG_RTW88_8821CE is not set
> # CONFIG_RTW88_DEBUG is not set
> # CONFIG_RTW88_DEBUGFS is not set
> # CONFIG_RTW89 is not set

Thanks for the report. To be sure the issue doesn't fall through the
cracks unnoticed, I'm adding it to regzbot, the Linux kernel regression
tracking bot:

#regzbot ^introduced 6bf3a083407b
#regzbot title wifi: rtw88: resume broken (reboot)
#regzbot ignore-activity

This isn't a regression? This issue or a fix for it are already
discussed somewhere else? It was fixed already? You want to clarify when
the regression started to happen? Or point out I got the title or
something else totally wrong? Then just reply and tell me -- ideally
while also telling regzbot about it, as explained by the page listed in
the footer of this mail.

Developers: When fixing the issue, remember to add 'Link:' tags pointing
to the report (the parent of this mail). See page linked in footer for
details.

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.

RE: Resume after suspend broken, reboots instead on kernel 6.1 onwards x86_64 RTW88

[Ping-Ke Shih]

> -----Original Message-----
> From: Linux kernel regression tracking (Thorsten Leemhuis) <regressions@leemhuis.info>
> Sent: Friday, February 10, 2023 8:25 PM
> To: Gary Chang <gary.chang@realtek.com>; Yan-Hsuan Chuang <tony0620emma@gmail.com>
> Cc: regressions@lists.linux.dev; linux-wireless@vger.kernel.org; Linux kernel regressions list
> <regressions@lists.linux.dev>; Kalle Valo <kvalo@kernel.org>; Paul Gover <pmw.gover@yahoo.co.uk>;
> stable@vger.kernel.org
> Subject: Re: Resume after suspend broken, reboots instead on kernel 6.1 onwards x86_64 RTW88
> 
> [adding Chih-Kang Chang (author), Kalle (committer) and LKML to the list
> of recipients]
> 
> [anyone who replies to this: feel free to remove stable@vger.kernel.org
> from the recipients, this is a mainline regression]
> 
> [TLDR: I'm adding this report to the list of tracked Linux kernel
> regressions; the text you find below is based on a few templates
> paragraphs you might have encountered already in similar form.
> See link in footer if these mails annoy you.]
> 
> On 09.02.23 20:59, Paul Gover wrote:
> > Suspend/Resume was working OK on kernel 6.0.13, broken since 6.1.1
> > (I've not tried kernels between those, except in the bisect below.)
> > All subsequent 6,1 kernels exhibit the same behaviour.
> >
> > Suspend works OK, but on Resume, there's a flicker, and then it reboots.
> > Sometimes the screen gets restored to its contents at the time of suspend. but
> > less than a second later, it starts rebooting.
> > To reproduce, simply boot, suspend, and resume.
> >
> > Git bisect blames RTW88
> > commit 6bf3a083407b5d404d70efc3a5ac75b472e5efa9
> 
> TWIMC, that's "wifi: rtw88: add flag check before enter or leave IPS"
> 
> > I'll attach bisect log, dmesg and configs to the bug I've opened
> > 	https://bugzilla.kernel.org/show_bug.cgi?id=217016
> >
> > dmesg from the following boot show a hardware error.
> > It's not there when the system resumes or reboots with 6.0.13,
> > and if I don't suspend & resume, there are no reported errors.
> >
> > The problem occurs under both Wayland and X11, and from the command line via
> > echo mem>/sys/power.state
> >
> >
> > Vanilla kernels, untainted, compiled with GCC; my system is Gentoo FWIW, but I
> > do my own kernels direct from a git clone of stable.
> >
> > Couldn't find anything similar with Google or the mailing lists.
> >
> > **Hardware:**
> >
> > HP Laptop 15-bw0xx
> > AMD A9-9420 RADEON R5, 5 COMPUTE CORES
> > Stoney [Radeon R2/R3/R4/R5 Graphics]
> > 4 GB memory
> > RTL8723DE PCIe adapter
> >
> > **Kernel**
> >
> > Kernel command line:
> > psmouse.synaptics_intertouch=1 pcie_aspm=force rdrand=force rootfstype=f2fs
> > root=LABEL=gentoo
> >
> > CONFIG_RTW88=m
> > CONFIG_RTW88_CORE=m
> > CONFIG_RTW88_PCI=m
> > CONFIG_RTW88_8723D=m
> > # CONFIG_RTW88_8822BE is not set
> > # CONFIG_RTW88_8822CE is not set
> > CONFIG_RTW88_8723DE=m
> > # CONFIG_RTW88_8821CE is not set
> > # CONFIG_RTW88_DEBUG is not set
> > # CONFIG_RTW88_DEBUGFS is not set
> > # CONFIG_RTW89 is not set
> 
> Thanks for the report. To be sure the issue doesn't fall through the
> cracks unnoticed, I'm adding it to regzbot, the Linux kernel regression
> tracking bot:
> 
> #regzbot ^introduced 6bf3a083407b
> #regzbot title wifi: rtw88: resume broken (reboot)
> #regzbot ignore-activity
> 
> This isn't a regression? This issue or a fix for it are already
> discussed somewhere else? It was fixed already? You want to clarify when
> the regression started to happen? Or point out I got the title or
> something else totally wrong? Then just reply and tell me -- ideally
> while also telling regzbot about it, as explained by the page listed in
> the footer of this mail.
> 
> Developers: When fixing the issue, remember to add 'Link:' tags pointing
> to the report (the parent of this mail). See page linked in footer for
> details.
> 
> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)

Since rtw88 can support 8723DE, 8821CE, 8822BE and 8822CE, do you have chip other
than 8723DE to give a try? Or, install 8723DE to another platform? 

I have added myself to kernel Bugzilla, so we can discuss further there.
We will try to reproduce this problem, and will update to Bugzilla if any finding.

Ping-Ke

Re: Resume after suspend broken, reboots instead on kernel 6.1 onwards x86_64 RTW88

[Paul Gover]

Ping-Ke,

Thanks for responding. My answers embedded below.

On Monday, 13 February 2023 03:42:14 GMT you wrote:
> > -----Original Message-----
> > From: Linux kernel regression tracking (Thorsten Leemhuis)
> > <regressions@leemhuis.info>
 Sent: Friday, February 10, 2023 8:25 PM
> > To: Gary Chang <gary.chang@realtek.com>; Yan-Hsuan Chuang
> > <tony0620emma@gmail.com>
 Cc: regressions@lists.linux.dev;
> > linux-wireless@vger.kernel.org; Linux kernel regressions list
> > <regressions@lists.linux.dev>; Kalle Valo <kvalo@kernel.org>; Paul Gover
> > <pmw.gover@yahoo.co.uk>; stable@vger.kernel.org
> > Subject: Re: Resume after suspend broken, reboots instead on kernel 6.1
> > onwards x86_64 RTW88
 
> > [adding Chih-Kang Chang (author), Kalle (committer) and LKML to the list
> > of recipients]
> > 
> > [anyone who replies to this: feel free to remove stable@vger.kernel.org
> > from the recipients, this is a mainline regression]
> > 
> > [TLDR: I'm adding this report to the list of tracked Linux kernel
> > regressions; the text you find below is based on a few templates
> > paragraphs you might have encountered already in similar form.
> > See link in footer if these mails annoy you.]
> > 
> > On 09.02.23 20:59, Paul Gover wrote:
> > 
> > > Suspend/Resume was working OK on kernel 6.0.13, broken since 6.1.1
> > > (I've not tried kernels between those, except in the bisect below.)
> > > All subsequent 6,1 kernels exhibit the same behaviour.
> > >
> > >
> > >
> > > Suspend works OK, but on Resume, there's a flicker, and then it
> > > reboots.
> > > Sometimes the screen gets restored to its contents at the time of
> > > suspend. but
 less than a second later, it starts rebooting.
> > > To reproduce, simply boot, suspend, and resume.
> > >
> > >
> > >
> > > Git bisect blames RTW88
> > > commit 6bf3a083407b5d404d70efc3a5ac75b472e5efa9
> > 
> > 
> > TWIMC, that's "wifi: rtw88: add flag check before enter or leave IPS"
> > 
> > 
> > > I'll attach bisect log, dmesg and configs to the bug I've opened
> > > 
> > > 	https://bugzilla.kernel.org/show_bug.cgi?id=217016
> > >
> > >
> > >
> > > dmesg from the following boot show a hardware error.
> > > It's not there when the system resumes or reboots with 6.0.13,
> > > and if I don't suspend & resume, there are no reported errors.
> > >
> > >
> > >
> > > The problem occurs under both Wayland and X11, and from the command line
> > > via
 echo mem>/sys/power.state
> > >
> > >
> > >
> > >
> > > Vanilla kernels, untainted, compiled with GCC; my system is Gentoo FWIW,
> > > but I
 do my own kernels direct from a git clone of stable.
> > >
> > >
> > >
> > > Couldn't find anything similar with Google or the mailing lists.
> > >
> > >
> > >
> > > **Hardware:**
> > >
> > >
> > >
> > > HP Laptop 15-bw0xx
> > > AMD A9-9420 RADEON R5, 5 COMPUTE CORES
> > > Stoney [Radeon R2/R3/R4/R5 Graphics]
> > > 4 GB memory
> > > RTL8723DE PCIe adapter
> > >
> > >
> > >
> > > **Kernel**
> > >
> > >
> > >
> > > Kernel command line:
> > > psmouse.synaptics_intertouch=1 pcie_aspm=force rdrand=force
> > > rootfstype=f2fs
 root=LABEL=gentoo
> > >
> > >
> > >
> > > CONFIG_RTW88=m
> > > CONFIG_RTW88_CORE=m
> > > CONFIG_RTW88_PCI=m
> > > CONFIG_RTW88_8723D=m
> > > # CONFIG_RTW88_8822BE is not set
> > > # CONFIG_RTW88_8822CE is not set
> > > CONFIG_RTW88_8723DE=m
> > > # CONFIG_RTW88_8821CE is not set
> > > # CONFIG_RTW88_DEBUG is not set
> > > # CONFIG_RTW88_DEBUGFS is not set
> > > # CONFIG_RTW89 is not set
> > 
> > 
> > Thanks for the report. To be sure the issue doesn't fall through the
> > cracks unnoticed, I'm adding it to regzbot, the Linux kernel regression
> > tracking bot:
> > 
> > #regzbot ^introduced 6bf3a083407b
> > #regzbot title wifi: rtw88: resume broken (reboot)
> > #regzbot ignore-activity
> > 
> > This isn't a regression? This issue or a fix for it are already
> > discussed somewhere else? It was fixed already? You want to clarify when
> > the regression started to happen? Or point out I got the title or
> > something else totally wrong? Then just reply and tell me -- ideally
> > while also telling regzbot about it, as explained by the page listed in
> > the footer of this mail.
> > 
> > Developers: When fixing the issue, remember to add 'Link:' tags pointing
> > to the report (the parent of this mail). See page linked in footer for
> > details.
> > 
> > Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> 
> 
> Since rtw88 can support 8723DE, 8821CE, 8822BE and 8822CE, do you have chip
> other
> than 8723DE to give a try? Or, install 8723DE to another platform? 
Sorry, I'm afraid I only have the one laptop with that device built-in; my 
other PC is a big desktop with a different chipset.

> I have added myself to kernel Bugzilla, so we can discuss further there.
> We will try to reproduce this problem, and will update to Bugzilla if any
> finding.

Thanks.  I'll respond there.
 
> Ping-Ke
> 

Re: Resume after suspend broken, reboots instead on kernel 6.1 onwards x86_64 RTW88

[Linux regression tracking #update (Thorsten Leemhuis)]

[TLDR: This mail in primarily relevant for Linux kernel regression
tracking. See link in footer if these mails annoy you.]

On 10.02.23 13:24, Linux kernel regression tracking (Thorsten Leemhuis)
wrote:
> On 09.02.23 20:59, Paul Gover wrote:
>> Suspend/Resume was working OK on kernel 6.0.13, broken since 6.1.1
>> (I've not tried kernels between those, except in the bisect below.)
>> All subsequent 6,1 kernels exhibit the same behaviour.
>>
>> Suspend works OK, but on Resume, there's a flicker, and then it reboots.
>> Sometimes the screen gets restored to its contents at the time of suspend. but 
>> less than a second later, it starts rebooting.
>> To reproduce, simply boot, suspend, and resume.
>>
>> Git bisect blames RTW88
>> commit 6bf3a083407b5d404d70efc3a5ac75b472e5efa9
> 
> TWIMC, that's "wifi: rtw88: add flag check before enter or leave IPS"
> 
>> I'll attach bisect log, dmesg and configs to the bug I've opened 
>> 	https://bugzilla.kernel.org/show_bug.cgi?id=217016

#regzbot monitor:
https://lore.kernel.org/linux-wireless/20230216053633.20366-1-pkshih@realtek.com/T/#u
#regzbot fix: wifi: rtw88: use RTW_FLAG_POWERON flag to prevent to power
on/off twice
#regzbot ignore-activity

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
That page also explains what to do if mails like this annoy you.