From: "Gao Feng" <gfree.wind@foxmail.com>
To: 'Sven Eckelmann' <sven@narfation.org>, b.a.t.m.a.n@lists.open-mesh.org
Cc: mareklindner@neomailbox.ch, netdev@vger.kernel.org,
a@unstable.cc, 'Gao Feng' <fgao@ikuai8.com>,
davem@davemloft.net
Subject: Re: [B.A.T.M.A.N.] [PATCH net] net: batman-adv: Fix possible memleaks when fail to register_netdevice
Date: Wed, 26 Apr 2017 08:41:30 +0800 [thread overview]
Message-ID: <002901d2be25$d9092bd0$8b1b8370$@foxmail.com> (raw)
In-Reply-To: <1756616.320MP6AHYH@bentobox>
> From: Sven Eckelmann [mailto:sven@narfation.org]
> Sent: Tuesday, April 25, 2017 9:53 PM
> On Dienstag, 25. April 2017 20:03:20 CEST gfree.wind@foxmail.com wrote:
> > From: Gao Feng <fgao@ikuai8.com>
> >
> > Because the func batadv_softif_init_late allocate some resources and
> > it would be invoked in register_netdevice. So we need to invoke the
> > func batadv_softif_free instead of free_netdev to cleanup when fail to
> > register_netdevice.
>
> I could be wrong, but shouldn't the destructor be replaced with
free_netdevice
> and the batadv_softif_free (without the free_netdev) used as ndo_uninit?
The
> line you've changed should then be kept as free_netdevice.
>
> At least this seems to be important when using rtnl_newlink() instead of
the
> legacy sysfs netdev stuff from batman-adv. rtnl_newlink() would also only
call
> free_netdevice and thus also not run batadv_softif_free. This seems to be
only
> fixable by calling ndo_uninit.
>
> Kind regards,
> Sven
Sorry, I don't get you.
The net_dev is created in this func batadv_softif_create.
Why couldn't invoke batadv_softif_free to cleanup when fail to
register_netdevice?
Best Regards
Feng
WARNING: multiple messages have this Message-ID (diff)
From: "Gao Feng" <gfree.wind-H32Fclmsjq1BDgjK7y7TUQ@public.gmane.org>
To: "'Sven Eckelmann'" <sven-KaDOiPu9UxWEi8DpZVb4nw@public.gmane.org>,
<b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org>
Cc: mareklindner-rVWd3aGhH2z5bpWLKbzFeg@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, a@unstable.cc,
'Gao Feng' <fgao-KlmEoCYek3zQT0dZR+AlfA@public.gmane.org>,
davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org
Subject: Re: [PATCH net] net: batman-adv: Fix possible memleaks when fail to register_netdevice
Date: Wed, 26 Apr 2017 08:41:30 +0800 [thread overview]
Message-ID: <002901d2be25$d9092bd0$8b1b8370$@foxmail.com> (raw)
In-Reply-To: <1756616.320MP6AHYH@bentobox>
> From: Sven Eckelmann [mailto:sven-KaDOiPu9UxWEi8DpZVb4nw@public.gmane.org]
> Sent: Tuesday, April 25, 2017 9:53 PM
> On Dienstag, 25. April 2017 20:03:20 CEST gfree.wind-H32Fclmsjq1BDgjK7y7TUQ@public.gmane.org wrote:
> > From: Gao Feng <fgao-KlmEoCYek3zQT0dZR+AlfA@public.gmane.org>
> >
> > Because the func batadv_softif_init_late allocate some resources and
> > it would be invoked in register_netdevice. So we need to invoke the
> > func batadv_softif_free instead of free_netdev to cleanup when fail to
> > register_netdevice.
>
> I could be wrong, but shouldn't the destructor be replaced with
free_netdevice
> and the batadv_softif_free (without the free_netdev) used as ndo_uninit?
The
> line you've changed should then be kept as free_netdevice.
>
> At least this seems to be important when using rtnl_newlink() instead of
the
> legacy sysfs netdev stuff from batman-adv. rtnl_newlink() would also only
call
> free_netdevice and thus also not run batadv_softif_free. This seems to be
only
> fixable by calling ndo_uninit.
>
> Kind regards,
> Sven
Sorry, I don't get you.
The net_dev is created in this func batadv_softif_create.
Why couldn't invoke batadv_softif_free to cleanup when fail to
register_netdevice?
Best Regards
Feng
next prev parent reply other threads:[~2017-04-26 0:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 12:03 [B.A.T.M.A.N.] [PATCH net] net: batman-adv: Fix possible memleaks when fail to register_netdevice gfree.wind
2017-04-25 12:03 ` gfree.wind
2017-04-25 13:53 ` [B.A.T.M.A.N.] " Sven Eckelmann
2017-04-25 13:53 ` Sven Eckelmann
2017-04-26 0:41 ` Gao Feng [this message]
2017-04-26 0:41 ` Gao Feng
2017-04-26 5:57 ` [B.A.T.M.A.N.] " Sven Eckelmann
2017-04-26 5:57 ` Sven Eckelmann
2017-04-26 6:44 ` [B.A.T.M.A.N.] " Gao Feng
2017-04-26 6:44 ` Gao Feng
2017-04-26 7:16 ` [B.A.T.M.A.N.] " Sven Eckelmann
2017-04-26 7:16 ` Sven Eckelmann
2017-04-26 7:28 ` [B.A.T.M.A.N.] " Gao Feng
2017-04-26 7:28 ` Gao Feng
2017-06-09 7:23 ` [B.A.T.M.A.N.] " Sven Eckelmann
2017-06-09 7:26 ` 高峰
2017-06-09 7:26 ` 高峰
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002901d2be25$d9092bd0$8b1b8370$@foxmail.com' \
--to=gfree.wind@foxmail.com \
--cc=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=fgao@ikuai8.com \
--cc=mareklindner@neomailbox.ch \
--cc=netdev@vger.kernel.org \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.