* [PATCH] ALSA: hda: add MODULE_FIRMWARE for cs35l41/cs35l56 @ 2025-06-23 14:00 GalaxySnail 2025-06-24 3:56 ` kernel test robot 0 siblings, 1 reply; 10+ messages in thread From: GalaxySnail @ 2025-06-23 14:00 UTC (permalink / raw) To: linux-sound Cc: linux-kernel, patches, David Rhodes, Richard Fitzgerald, Jaroslav Kysela, Takashi Iwai, GalaxySnail add firmware information in the .modinfo section, so that userspace tools can find out firmware required by cs35l41/cs32l56 kernel module Signed-off-by: GalaxySnail <me@glxys.nl> --- sound/pci/hda/cs35l41_hda.c | 2 ++ sound/pci/hda/cs35l56_hda.c | 4 ++++ 2 files changed, 6 insertions(+) diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c index d5bc81099d0d..90e994b79481 100644 --- a/sound/pci/hda/cs35l41_hda.c +++ b/sound/pci/hda/cs35l41_hda.c @@ -2085,3 +2085,5 @@ MODULE_IMPORT_NS("SND_SOC_CS_AMP_LIB"); MODULE_AUTHOR("Lucas Tanure, Cirrus Logic Inc, <tanureal@opensource.cirrus.com>"); MODULE_LICENSE("GPL"); MODULE_IMPORT_NS("FW_CS_DSP"); +MODULE_FIRMWARE("cirrus/cs35l41-*.wmfw") +MODULE_FIRMWARE("cirrus/cs35l41-*.bin") diff --git a/sound/pci/hda/cs35l56_hda.c b/sound/pci/hda/cs35l56_hda.c index 3f2fd32f4ad9..c393fc0c7339 100644 --- a/sound/pci/hda/cs35l56_hda.c +++ b/sound/pci/hda/cs35l56_hda.c @@ -1122,3 +1122,7 @@ MODULE_IMPORT_NS("SND_SOC_CS_AMP_LIB"); MODULE_AUTHOR("Richard Fitzgerald <rf@opensource.cirrus.com>"); MODULE_AUTHOR("Simon Trimmer <simont@opensource.cirrus.com>"); MODULE_LICENSE("GPL"); +MODULE_FIRMWARE("cirrus/cs35l54-*.wmfw") +MODULE_FIRMWARE("cirrus/cs35l54-*.bin") +MODULE_FIRMWARE("cirrus/cs35l56-*.wmfw") +MODULE_FIRMWARE("cirrus/cs35l56-*.bin") -- 2.50.0 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] ALSA: hda: add MODULE_FIRMWARE for cs35l41/cs35l56 2025-06-23 14:00 [PATCH] ALSA: hda: add MODULE_FIRMWARE for cs35l41/cs35l56 GalaxySnail @ 2025-06-24 3:56 ` kernel test robot 2025-06-24 4:31 ` [PATCH v2] " GalaxySnail 0 siblings, 1 reply; 10+ messages in thread From: kernel test robot @ 2025-06-24 3:56 UTC (permalink / raw) To: GalaxySnail, linux-sound Cc: oe-kbuild-all, linux-kernel, patches, David Rhodes, Richard Fitzgerald, Jaroslav Kysela, Takashi Iwai, GalaxySnail Hi GalaxySnail, kernel test robot noticed the following build errors: [auto build test ERROR on tiwai-sound/for-next] [also build test ERROR on tiwai-sound/for-linus linus/master v6.16-rc3 next-20250623] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/GalaxySnail/ALSA-hda-add-MODULE_FIRMWARE-for-cs35l41-cs35l56/20250623-220657 base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next patch link: https://lore.kernel.org/r/20250623140030.1539477-2-me%40glxys.nl patch subject: [PATCH] ALSA: hda: add MODULE_FIRMWARE for cs35l41/cs35l56 config: x86_64-rhel-9.4 (https://download.01.org/0day-ci/archive/20250624/202506241158.kxrazQoo-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250624/202506241158.kxrazQoo-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202506241158.kxrazQoo-lkp@intel.com/ All errors (new ones prefixed by >>): In file included from include/linux/module.h:22, from include/linux/device/driver.h:21, from include/linux/device.h:32, from include/linux/acpi.h:14, from sound/pci/hda/cs35l41_hda.c:9: >> include/linux/moduleparam.h:24:9: error: expected ',' or ';' before 'static' 24 | static const char __UNIQUE_ID(name)[] \ | ^~~~~~ include/linux/module.h:168:32: note: in expansion of macro '__MODULE_INFO' 168 | #define MODULE_INFO(tag, info) __MODULE_INFO(tag, tag, info) | ^~~~~~~~~~~~~ include/linux/module.h:299:36: note: in expansion of macro 'MODULE_INFO' 299 | #define MODULE_FIRMWARE(_firmware) MODULE_INFO(firmware, _firmware) | ^~~~~~~~~~~ sound/pci/hda/cs35l41_hda.c:2116:1: note: in expansion of macro 'MODULE_FIRMWARE' 2116 | MODULE_FIRMWARE("cirrus/cs35l41-*.bin") | ^~~~~~~~~~~~~~~ -- In file included from include/linux/module.h:22, from include/linux/device/driver.h:21, from include/linux/device.h:32, from include/linux/acpi.h:14, from sound/pci/hda/cs35l56_hda.c:9: >> include/linux/moduleparam.h:24:9: error: expected ',' or ';' before 'static' 24 | static const char __UNIQUE_ID(name)[] \ | ^~~~~~ include/linux/module.h:168:32: note: in expansion of macro '__MODULE_INFO' 168 | #define MODULE_INFO(tag, info) __MODULE_INFO(tag, tag, info) | ^~~~~~~~~~~~~ include/linux/module.h:299:36: note: in expansion of macro 'MODULE_INFO' 299 | #define MODULE_FIRMWARE(_firmware) MODULE_INFO(firmware, _firmware) | ^~~~~~~~~~~ sound/pci/hda/cs35l56_hda.c:1126:1: note: in expansion of macro 'MODULE_FIRMWARE' 1126 | MODULE_FIRMWARE("cirrus/cs35l54-*.bin") | ^~~~~~~~~~~~~~~ -- In file included from include/linux/module.h:22, from include/linux/device/driver.h:21, from include/linux/device.h:32, from include/linux/acpi.h:14, from cs35l41_hda.c:9: >> include/linux/moduleparam.h:24:9: error: expected ',' or ';' before 'static' 24 | static const char __UNIQUE_ID(name)[] \ | ^~~~~~ include/linux/module.h:168:32: note: in expansion of macro '__MODULE_INFO' 168 | #define MODULE_INFO(tag, info) __MODULE_INFO(tag, tag, info) | ^~~~~~~~~~~~~ include/linux/module.h:299:36: note: in expansion of macro 'MODULE_INFO' 299 | #define MODULE_FIRMWARE(_firmware) MODULE_INFO(firmware, _firmware) | ^~~~~~~~~~~ cs35l41_hda.c:2116:1: note: in expansion of macro 'MODULE_FIRMWARE' 2116 | MODULE_FIRMWARE("cirrus/cs35l41-*.bin") | ^~~~~~~~~~~~~~~ -- In file included from include/linux/module.h:22, from include/linux/device/driver.h:21, from include/linux/device.h:32, from include/linux/acpi.h:14, from cs35l56_hda.c:9: >> include/linux/moduleparam.h:24:9: error: expected ',' or ';' before 'static' 24 | static const char __UNIQUE_ID(name)[] \ | ^~~~~~ include/linux/module.h:168:32: note: in expansion of macro '__MODULE_INFO' 168 | #define MODULE_INFO(tag, info) __MODULE_INFO(tag, tag, info) | ^~~~~~~~~~~~~ include/linux/module.h:299:36: note: in expansion of macro 'MODULE_INFO' 299 | #define MODULE_FIRMWARE(_firmware) MODULE_INFO(firmware, _firmware) | ^~~~~~~~~~~ cs35l56_hda.c:1126:1: note: in expansion of macro 'MODULE_FIRMWARE' 1126 | MODULE_FIRMWARE("cirrus/cs35l54-*.bin") | ^~~~~~~~~~~~~~~ vim +24 include/linux/moduleparam.h 730b69d2252595 Rusty Russell 2008-10-22 22 ^1da177e4c3f41 Linus Torvalds 2005-04-16 23 #define __MODULE_INFO(tag, name, info) \ 34182eea36fc1d Rusty Russell 2012-11-22 @24 static const char __UNIQUE_ID(name)[] \ 2aec389e19150e Johan Hovold 2020-11-23 25 __used __section(".modinfo") __aligned(1) \ 898490c010b5d2 Alexey Gladkov 2019-04-29 26 = __MODULE_INFO_PREFIX __stringify(tag) "=" info 898490c010b5d2 Alexey Gladkov 2019-04-29 27 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2] ALSA: hda: add MODULE_FIRMWARE for cs35l41/cs35l56 2025-06-24 3:56 ` kernel test robot @ 2025-06-24 4:31 ` GalaxySnail 2025-06-24 10:04 ` Simon Trimmer 0 siblings, 1 reply; 10+ messages in thread From: GalaxySnail @ 2025-06-24 4:31 UTC (permalink / raw) To: lkp Cc: david.rhodes, linux-kernel, linux-sound, me, oe-kbuild-all, patches, perex, rf, tiwai add firmware information in the .modinfo section, so that userspace tools can find out firmware required by cs35l41/cs32l56 kernel module Signed-off-by: GalaxySnail <me@glxys.nl> --- v1 -> v2: fixed missing ';' in the previous patch sound/pci/hda/cs35l41_hda.c | 2 ++ sound/pci/hda/cs35l56_hda.c | 4 ++++ 2 files changed, 6 insertions(+) diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c index d5bc81099d0d..f71f6aca0601 100644 --- a/sound/pci/hda/cs35l41_hda.c +++ b/sound/pci/hda/cs35l41_hda.c @@ -2085,3 +2085,5 @@ MODULE_IMPORT_NS("SND_SOC_CS_AMP_LIB"); MODULE_AUTHOR("Lucas Tanure, Cirrus Logic Inc, <tanureal@opensource.cirrus.com>"); MODULE_LICENSE("GPL"); MODULE_IMPORT_NS("FW_CS_DSP"); +MODULE_FIRMWARE("cirrus/cs35l41-*.wmfw"); +MODULE_FIRMWARE("cirrus/cs36l41-*.bin"); diff --git a/sound/pci/hda/cs35l56_hda.c b/sound/pci/hda/cs35l56_hda.c index 3f2fd32f4ad9..eedd8fdd3b8b 100644 --- a/sound/pci/hda/cs35l56_hda.c +++ b/sound/pci/hda/cs35l56_hda.c @@ -1122,3 +1122,7 @@ MODULE_IMPORT_NS("SND_SOC_CS_AMP_LIB"); MODULE_AUTHOR("Richard Fitzgerald <rf@opensource.cirrus.com>"); MODULE_AUTHOR("Simon Trimmer <simont@opensource.cirrus.com>"); MODULE_LICENSE("GPL"); +MODULE_FIRMWARE("cirrus/cs35l54-*.wmfw"); +MODULE_FIRMWARE("cirrus/cs35l54-*.bin"); +MODULE_FIRMWARE("cirrus/cs35l56-*.wmfw"); +MODULE_FIRMWARE("cirrus/cs35l56-*.bin"); -- 2.50.0 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* RE: [PATCH v2] ALSA: hda: add MODULE_FIRMWARE for cs35l41/cs35l56 2025-06-24 4:31 ` [PATCH v2] " GalaxySnail @ 2025-06-24 10:04 ` Simon Trimmer 2025-06-24 10:17 ` [PATCH v3] " GalaxySnail 0 siblings, 1 reply; 10+ messages in thread From: Simon Trimmer @ 2025-06-24 10:04 UTC (permalink / raw) To: 'GalaxySnail', lkp Cc: david.rhodes, linux-kernel, linux-sound, oe-kbuild-all, patches, perex, rf, tiwai On Tue, Jun 24, 2025 at 05:31:21AM +0100, GalaxySnail wrote: > add firmware information in the .modinfo section, so that userspace > tools can find out firmware required by cs35l41/cs32l56 kernel module Typo in part number cs32l56 -> cs35l56 > > Signed-off-by: GalaxySnail <me@glxys.nl> > --- > v1 -> v2: fixed missing ';' in the previous patch > > sound/pci/hda/cs35l41_hda.c | 2 ++ > sound/pci/hda/cs35l56_hda.c | 4 ++++ > 2 files changed, 6 insertions(+) > > diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c > index d5bc81099d0d..f71f6aca0601 100644 > --- a/sound/pci/hda/cs35l41_hda.c > +++ b/sound/pci/hda/cs35l41_hda.c > @@ -2085,3 +2085,5 @@ MODULE_IMPORT_NS("SND_SOC_CS_AMP_LIB"); > MODULE_AUTHOR("Lucas Tanure, Cirrus Logic Inc, > <tanureal@opensource.cirrus.com>"); > MODULE_LICENSE("GPL"); > MODULE_IMPORT_NS("FW_CS_DSP"); > +MODULE_FIRMWARE("cirrus/cs35l41-*.wmfw"); > +MODULE_FIRMWARE("cirrus/cs36l41-*.bin"); Typo in part number cs36l41 -> cs35l41 > diff --git a/sound/pci/hda/cs35l56_hda.c b/sound/pci/hda/cs35l56_hda.c > index 3f2fd32f4ad9..eedd8fdd3b8b 100644 > --- a/sound/pci/hda/cs35l56_hda.c > +++ b/sound/pci/hda/cs35l56_hda.c > @@ -1122,3 +1122,7 @@ MODULE_IMPORT_NS("SND_SOC_CS_AMP_LIB"); > MODULE_AUTHOR("Richard Fitzgerald <rf@opensource.cirrus.com>"); > MODULE_AUTHOR("Simon Trimmer <simont@opensource.cirrus.com>"); > MODULE_LICENSE("GPL"); > +MODULE_FIRMWARE("cirrus/cs35l54-*.wmfw"); > +MODULE_FIRMWARE("cirrus/cs35l54-*.bin"); > +MODULE_FIRMWARE("cirrus/cs35l56-*.wmfw"); > +MODULE_FIRMWARE("cirrus/cs35l56-*.bin"); > -- > 2.50.0 ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v3] ALSA: hda: add MODULE_FIRMWARE for cs35l41/cs35l56 2025-06-24 10:04 ` Simon Trimmer @ 2025-06-24 10:17 ` GalaxySnail 2025-06-24 10:44 ` Takashi Iwai ` (3 more replies) 0 siblings, 4 replies; 10+ messages in thread From: GalaxySnail @ 2025-06-24 10:17 UTC (permalink / raw) To: simont Cc: david.rhodes, linux-kernel, linux-sound, lkp, me, oe-kbuild-all, patches, perex, rf, tiwai add firmware information in the .modinfo section, so that userspace tools can find out firmware required by cs35l41/cs35l56 kernel module Signed-off-by: GalaxySnail <me@glxys.nl> --- Thanks for your review! v2 -> v3: fixed typo v1 -> v2: fixed missing ';' in the previous patch sound/pci/hda/cs35l41_hda.c | 2 ++ sound/pci/hda/cs35l56_hda.c | 4 ++++ 2 files changed, 6 insertions(+) diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c index d5bc81099d0d..17cdce91fdbf 100644 --- a/sound/pci/hda/cs35l41_hda.c +++ b/sound/pci/hda/cs35l41_hda.c @@ -2085,3 +2085,5 @@ MODULE_IMPORT_NS("SND_SOC_CS_AMP_LIB"); MODULE_AUTHOR("Lucas Tanure, Cirrus Logic Inc, <tanureal@opensource.cirrus.com>"); MODULE_LICENSE("GPL"); MODULE_IMPORT_NS("FW_CS_DSP"); +MODULE_FIRMWARE("cirrus/cs35l41-*.wmfw"); +MODULE_FIRMWARE("cirrus/cs35l41-*.bin"); diff --git a/sound/pci/hda/cs35l56_hda.c b/sound/pci/hda/cs35l56_hda.c index 3f2fd32f4ad9..eedd8fdd3b8b 100644 --- a/sound/pci/hda/cs35l56_hda.c +++ b/sound/pci/hda/cs35l56_hda.c @@ -1122,3 +1122,7 @@ MODULE_IMPORT_NS("SND_SOC_CS_AMP_LIB"); MODULE_AUTHOR("Richard Fitzgerald <rf@opensource.cirrus.com>"); MODULE_AUTHOR("Simon Trimmer <simont@opensource.cirrus.com>"); MODULE_LICENSE("GPL"); +MODULE_FIRMWARE("cirrus/cs35l54-*.wmfw"); +MODULE_FIRMWARE("cirrus/cs35l54-*.bin"); +MODULE_FIRMWARE("cirrus/cs35l56-*.wmfw"); +MODULE_FIRMWARE("cirrus/cs35l56-*.bin"); -- 2.50.0 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v3] ALSA: hda: add MODULE_FIRMWARE for cs35l41/cs35l56 2025-06-24 10:17 ` [PATCH v3] " GalaxySnail @ 2025-06-24 10:44 ` Takashi Iwai 2025-06-24 11:25 ` GalaxySnail 2025-07-04 12:02 ` Takashi Iwai ` (2 subsequent siblings) 3 siblings, 1 reply; 10+ messages in thread From: Takashi Iwai @ 2025-06-24 10:44 UTC (permalink / raw) To: GalaxySnail Cc: simont, david.rhodes, linux-kernel, linux-sound, lkp, oe-kbuild-all, patches, perex, rf, tiwai On Tue, 24 Jun 2025 12:17:17 +0200, GalaxySnail wrote: > > add firmware information in the .modinfo section, so that userspace > tools can find out firmware required by cs35l41/cs35l56 kernel module > > Signed-off-by: GalaxySnail <me@glxys.nl> Signed-off-by is a legal requirement, and it must be a known identity, no anonymity. Could you resubmit with a proper name? thanks, Takashi > --- > Thanks for your review! > > v2 -> v3: fixed typo > v1 -> v2: fixed missing ';' in the previous patch > > sound/pci/hda/cs35l41_hda.c | 2 ++ > sound/pci/hda/cs35l56_hda.c | 4 ++++ > 2 files changed, 6 insertions(+) > > diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c > index d5bc81099d0d..17cdce91fdbf 100644 > --- a/sound/pci/hda/cs35l41_hda.c > +++ b/sound/pci/hda/cs35l41_hda.c > @@ -2085,3 +2085,5 @@ MODULE_IMPORT_NS("SND_SOC_CS_AMP_LIB"); > MODULE_AUTHOR("Lucas Tanure, Cirrus Logic Inc, <tanureal@opensource.cirrus.com>"); > MODULE_LICENSE("GPL"); > MODULE_IMPORT_NS("FW_CS_DSP"); > +MODULE_FIRMWARE("cirrus/cs35l41-*.wmfw"); > +MODULE_FIRMWARE("cirrus/cs35l41-*.bin"); > diff --git a/sound/pci/hda/cs35l56_hda.c b/sound/pci/hda/cs35l56_hda.c > index 3f2fd32f4ad9..eedd8fdd3b8b 100644 > --- a/sound/pci/hda/cs35l56_hda.c > +++ b/sound/pci/hda/cs35l56_hda.c > @@ -1122,3 +1122,7 @@ MODULE_IMPORT_NS("SND_SOC_CS_AMP_LIB"); > MODULE_AUTHOR("Richard Fitzgerald <rf@opensource.cirrus.com>"); > MODULE_AUTHOR("Simon Trimmer <simont@opensource.cirrus.com>"); > MODULE_LICENSE("GPL"); > +MODULE_FIRMWARE("cirrus/cs35l54-*.wmfw"); > +MODULE_FIRMWARE("cirrus/cs35l54-*.bin"); > +MODULE_FIRMWARE("cirrus/cs35l56-*.wmfw"); > +MODULE_FIRMWARE("cirrus/cs35l56-*.bin"); > -- > 2.50.0 > > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3] ALSA: hda: add MODULE_FIRMWARE for cs35l41/cs35l56 2025-06-24 10:44 ` Takashi Iwai @ 2025-06-24 11:25 ` GalaxySnail 0 siblings, 0 replies; 10+ messages in thread From: GalaxySnail @ 2025-06-24 11:25 UTC (permalink / raw) To: Takashi Iwai Cc: simont, david.rhodes, linux-kernel, linux-sound, lkp, oe-kbuild-all, patches, perex, rf, tiwai, me On 2025/6/24 18:44, Takashi Iwai wrote: > On Tue, 24 Jun 2025 12:17:17 +0200, > GalaxySnail wrote: >> >> add firmware information in the .modinfo section, so that userspace >> tools can find out firmware required by cs35l41/cs35l56 kernel module >> >> Signed-off-by: GalaxySnail <me@glxys.nl> > > Signed-off-by is a legal requirement, and it must be a known identity, > no anonymity. Could you resubmit with a proper name? GalaxySnail is not an anonymous identity, it's the consistent name I use for all my open-source contributions. Here's my GitHub account: https://github.com/GalaxySnail and here's my AUR account: https://aur.archlinux.org/account/GalaxySnail > thanks, > > Takashi ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3] ALSA: hda: add MODULE_FIRMWARE for cs35l41/cs35l56 2025-06-24 10:17 ` [PATCH v3] " GalaxySnail 2025-06-24 10:44 ` Takashi Iwai @ 2025-07-04 12:02 ` Takashi Iwai 2025-07-04 12:33 ` Richard Fitzgerald 2025-07-06 8:23 ` Takashi Iwai 3 siblings, 0 replies; 10+ messages in thread From: Takashi Iwai @ 2025-07-04 12:02 UTC (permalink / raw) To: patches Cc: GalaxySnail, simont, david.rhodes, linux-kernel, linux-sound, lkp, oe-kbuild-all, perex, rf, tiwai On Tue, 24 Jun 2025 12:17:17 +0200, GalaxySnail wrote: > > add firmware information in the .modinfo section, so that userspace > tools can find out firmware required by cs35l41/cs35l56 kernel module > > Signed-off-by: GalaxySnail <me@glxys.nl> > --- > Thanks for your review! > > v2 -> v3: fixed typo > v1 -> v2: fixed missing ';' in the previous patch Cirrus people, can you review this before I merge? thanks, Takashi > > sound/pci/hda/cs35l41_hda.c | 2 ++ > sound/pci/hda/cs35l56_hda.c | 4 ++++ > 2 files changed, 6 insertions(+) > > diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c > index d5bc81099d0d..17cdce91fdbf 100644 > --- a/sound/pci/hda/cs35l41_hda.c > +++ b/sound/pci/hda/cs35l41_hda.c > @@ -2085,3 +2085,5 @@ MODULE_IMPORT_NS("SND_SOC_CS_AMP_LIB"); > MODULE_AUTHOR("Lucas Tanure, Cirrus Logic Inc, <tanureal@opensource.cirrus.com>"); > MODULE_LICENSE("GPL"); > MODULE_IMPORT_NS("FW_CS_DSP"); > +MODULE_FIRMWARE("cirrus/cs35l41-*.wmfw"); > +MODULE_FIRMWARE("cirrus/cs35l41-*.bin"); > diff --git a/sound/pci/hda/cs35l56_hda.c b/sound/pci/hda/cs35l56_hda.c > index 3f2fd32f4ad9..eedd8fdd3b8b 100644 > --- a/sound/pci/hda/cs35l56_hda.c > +++ b/sound/pci/hda/cs35l56_hda.c > @@ -1122,3 +1122,7 @@ MODULE_IMPORT_NS("SND_SOC_CS_AMP_LIB"); > MODULE_AUTHOR("Richard Fitzgerald <rf@opensource.cirrus.com>"); > MODULE_AUTHOR("Simon Trimmer <simont@opensource.cirrus.com>"); > MODULE_LICENSE("GPL"); > +MODULE_FIRMWARE("cirrus/cs35l54-*.wmfw"); > +MODULE_FIRMWARE("cirrus/cs35l54-*.bin"); > +MODULE_FIRMWARE("cirrus/cs35l56-*.wmfw"); > +MODULE_FIRMWARE("cirrus/cs35l56-*.bin"); > -- > 2.50.0 > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3] ALSA: hda: add MODULE_FIRMWARE for cs35l41/cs35l56 2025-06-24 10:17 ` [PATCH v3] " GalaxySnail 2025-06-24 10:44 ` Takashi Iwai 2025-07-04 12:02 ` Takashi Iwai @ 2025-07-04 12:33 ` Richard Fitzgerald 2025-07-06 8:23 ` Takashi Iwai 3 siblings, 0 replies; 10+ messages in thread From: Richard Fitzgerald @ 2025-07-04 12:33 UTC (permalink / raw) To: GalaxySnail, simont Cc: david.rhodes, linux-kernel, linux-sound, lkp, oe-kbuild-all, patches, perex, tiwai On 24/06/2025 11:17 am, GalaxySnail wrote: > add firmware information in the .modinfo section, so that userspace > tools can find out firmware required by cs35l41/cs35l56 kernel module > > Signed-off-by: GalaxySnail <me@glxys.nl> > --- > Thanks for your review! > > v2 -> v3: fixed typo > v1 -> v2: fixed missing ';' in the previous patch > > sound/pci/hda/cs35l41_hda.c | 2 ++ > sound/pci/hda/cs35l56_hda.c | 4 ++++ > 2 files changed, 6 insertions(+) > > diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c > index d5bc81099d0d..17cdce91fdbf 100644 > --- a/sound/pci/hda/cs35l41_hda.c > +++ b/sound/pci/hda/cs35l41_hda.c > @@ -2085,3 +2085,5 @@ MODULE_IMPORT_NS("SND_SOC_CS_AMP_LIB"); > MODULE_AUTHOR("Lucas Tanure, Cirrus Logic Inc, <tanureal@opensource.cirrus.com>"); > MODULE_LICENSE("GPL"); > MODULE_IMPORT_NS("FW_CS_DSP"); > +MODULE_FIRMWARE("cirrus/cs35l41-*.wmfw"); > +MODULE_FIRMWARE("cirrus/cs35l41-*.bin"); > diff --git a/sound/pci/hda/cs35l56_hda.c b/sound/pci/hda/cs35l56_hda.c > index 3f2fd32f4ad9..eedd8fdd3b8b 100644 > --- a/sound/pci/hda/cs35l56_hda.c > +++ b/sound/pci/hda/cs35l56_hda.c > @@ -1122,3 +1122,7 @@ MODULE_IMPORT_NS("SND_SOC_CS_AMP_LIB"); > MODULE_AUTHOR("Richard Fitzgerald <rf@opensource.cirrus.com>"); > MODULE_AUTHOR("Simon Trimmer <simont@opensource.cirrus.com>"); > MODULE_LICENSE("GPL"); > +MODULE_FIRMWARE("cirrus/cs35l54-*.wmfw"); > +MODULE_FIRMWARE("cirrus/cs35l54-*.bin"); > +MODULE_FIRMWARE("cirrus/cs35l56-*.wmfw"); > +MODULE_FIRMWARE("cirrus/cs35l56-*.bin"); Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com> ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3] ALSA: hda: add MODULE_FIRMWARE for cs35l41/cs35l56 2025-06-24 10:17 ` [PATCH v3] " GalaxySnail ` (2 preceding siblings ...) 2025-07-04 12:33 ` Richard Fitzgerald @ 2025-07-06 8:23 ` Takashi Iwai 3 siblings, 0 replies; 10+ messages in thread From: Takashi Iwai @ 2025-07-06 8:23 UTC (permalink / raw) To: GalaxySnail Cc: simont, david.rhodes, linux-kernel, linux-sound, lkp, oe-kbuild-all, patches, perex, rf, tiwai On Tue, 24 Jun 2025 12:17:17 +0200, GalaxySnail wrote: > > add firmware information in the .modinfo section, so that userspace > tools can find out firmware required by cs35l41/cs35l56 kernel module > > Signed-off-by: GalaxySnail <me@glxys.nl> > --- > Thanks for your review! > > v2 -> v3: fixed typo > v1 -> v2: fixed missing ';' in the previous patch Applied now to for-next branch. Thanks. Takashi ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2025-07-06 8:34 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-06-23 14:00 [PATCH] ALSA: hda: add MODULE_FIRMWARE for cs35l41/cs35l56 GalaxySnail 2025-06-24 3:56 ` kernel test robot 2025-06-24 4:31 ` [PATCH v2] " GalaxySnail 2025-06-24 10:04 ` Simon Trimmer 2025-06-24 10:17 ` [PATCH v3] " GalaxySnail 2025-06-24 10:44 ` Takashi Iwai 2025-06-24 11:25 ` GalaxySnail 2025-07-04 12:02 ` Takashi Iwai 2025-07-04 12:33 ` Richard Fitzgerald 2025-07-06 8:23 ` Takashi Iwai
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.