toshiba_acpi.c

toshiba_acpi.c

[Tom Mannerhagen]

Hi

My name is Tom Mannerhagen.
I am writing to you because I can see you're somehow involved in the
last version of toshiba_acpi.c

I have some issues / suggestions to the driver, but since I am no coder,
my ideas won't bear any fruit unless I get some help.

Can I send my thoughts this way?

BR Tom

Re: toshiba_acpi.c

[Azael Avalos]

Hi there,

2015-02-18 13:27 GMT-07:00 Tom Mannerhagen <tom.mannerhagen@gmail.com>:
> Hi
>
> My name is Tom Mannerhagen.
> I am writing to you because I can see you're somehow involved in the
> last version of toshiba_acpi.c

Well, right now I'm taking care of the driver (adding features, cleaning,
etc.), so I guess I'm the "maintainer" as of now ;-)

>
> I have some issues / suggestions to the driver, but since I am no coder,
> my ideas won't bear any fruit unless I get some help.
>
> Can I send my thoughts this way?

I have no problem, tho' I'm not sure if the mailing list is the right place
for this.
Darren, any input here?

As per your ideas/suggestions, it will depend if it is feasible/possible.
I any case, just send me your ideas/suggestions, and we can try to
work something out (again, if feasible/possible).

>
> BR Tom
>

Cheers
Azael

-- 
-- El mundo apesta y vosotros apestais tambien --

Re: toshiba_acpi.c

[Darren Hart]

On Wed, Feb 18, 2015 at 02:07:43PM -0700, Azael Avalos wrote:
> Hi there,
> 
> 2015-02-18 13:27 GMT-07:00 Tom Mannerhagen <tom.mannerhagen@gmail.com>:
> > Hi
> >
> > My name is Tom Mannerhagen.
> > I am writing to you because I can see you're somehow involved in the
> > last version of toshiba_acpi.c
> 
> Well, right now I'm taking care of the driver (adding features, cleaning,
> etc.), so I guess I'm the "maintainer" as of now ;-)
> 
> >
> > I have some issues / suggestions to the driver, but since I am no coder,
> > my ideas won't bear any fruit unless I get some help.
> >
> > Can I send my thoughts this way?
> 
> I have no problem, tho' I'm not sure if the mailing list is the right place
> for this.
> Darren, any input here?

Yup, this is the place. Everything happens on the mailing list :-) (I pointed
Tom here).

> 
> As per your ideas/suggestions, it will depend if it is feasible/possible.
> I any case, just send me your ideas/suggestions, and we can try to
> work something out (again, if feasible/possible).
> 

Yup, don't ask, just say what you have to say and we'll discuss it.
-- 
Darren Hart
Intel Open Source Technology Center

RE: toshiba_acpi.c

[Tom Mannerhagen]

Thanks!

I think I need to rephrase a bit.

How is the driver distinguishing which mapping to apply depending on which model it is running on?

Why I am asking:
I'm since 26 years involved in technical support of Toshiba notebooks, a happy Linux-user also trying to help other Toshiba owners using Linux on Toshiba's.
In that scope I can see that some features (Hotkeys), probably provided by the toshiba_acpi-driver, does not work on every platform.
More in detail - mappings are not always correct.
It lies more in my personal interest than my profession to see this improved.

BR Tom

-----Original Message-----
From: Azael Avalos [mailto:coproscefalo@gmail.com] 
Sent: den 18 februari 2015 22:08
To: Tom Mannerhagen
Cc: Darren Hart; platform-driver-x86@vger.kernel.org
Subject: Re: toshiba_acpi.c

Hi there,

2015-02-18 13:27 GMT-07:00 Tom Mannerhagen <tom.mannerhagen@gmail.com>:
> Hi
>
> My name is Tom Mannerhagen.
> I am writing to you because I can see you're somehow involved in the 
> last version of toshiba_acpi.c

Well, right now I'm taking care of the driver (adding features, cleaning, etc.), so I guess I'm the "maintainer" as of now ;-)

>
> I have some issues / suggestions to the driver, but since I am no 
> coder, my ideas won't bear any fruit unless I get some help.
>
> Can I send my thoughts this way?

I have no problem, tho' I'm not sure if the mailing list is the right place for this.
Darren, any input here?

As per your ideas/suggestions, it will depend if it is feasible/possible.
I any case, just send me your ideas/suggestions, and we can try to work something out (again, if feasible/possible).

>
> BR Tom
>

Cheers
Azael

--
-- El mundo apesta y vosotros apestais tambien --

Re: toshiba_acpi.c

[Azael Avalos]

Hi Tom,

2015-02-25 13:42 GMT-07:00 Tom Mannerhagen <tom.mannerhagen@gmail.com>:
> Thanks!
>
> I think I need to rephrase a bit.
>
> How is the driver distinguishing which mapping to apply depending on which model it is running on?

Currently we use the "toshiba_alt_keymap_dmi" list, but only 3 models
have been added to it,
Satellite M840, Qosmio X75-A and TECRA A50-A.

I know that there are a lot more out there, but these are the ones
that the driver currently know of...

>
> Why I am asking:
> I'm since 26 years involved in technical support of Toshiba notebooks, a happy Linux-user also trying to help other Toshiba owners using Linux on Toshiba's.
> In that scope I can see that some features (Hotkeys), probably provided by the toshiba_acpi-driver, does not work on every platform.
> More in detail - mappings are not always correct.
> It lies more in my personal interest than my profession to see this improved.

Without propper documentation from Toshiba, we are left in the blind
and only rely on what we
(or other people, bug reports, etc.) know of, however, I made some
progress on identifying the
HCI call for the hotkey event type (patch comming soon), needed for
some laptops supporting
the "Special Functions", which happens to be those affected by the new
keymap layout.

If you are a Toshiba laptop owner and/or have access to more hardware
than I do (currently
2 laptops, Qosmio X505 and Qosmio X75), I could use some testing ;-)

>
> BR Tom
>

Cheers
Azael


-- 
-- El mundo apesta y vosotros apestais tambien --

RE: toshiba_acpi.c

[Tom Mannerhagen]

Hi Azael

I see, but that concerns the alternative map, correct?
How does the driver tell if it should use the "standard" or alternative mapping?

I think I can see some checks are made in the beginning of the driver, it checks for certain ACPI ID's (TOS6200, TOS6207, TOS6028, TOS1900).
Are they used to identify the system as a Toshiba or are they used to distinguish which Toshiba-platform it runs on?
Perhaps both?

If used to tell which Toshiba it runs on, is this somehow used to select mapping of the function-keys?

BTW - I have access to a bunch of units and will happily test as time allow.
You may need to hand-hold me through the building of the driver and using it in a distro.

BR Tom

-----Original Message-----
From: Azael Avalos [mailto:coproscefalo@gmail.com] 
Sent: den 25 februari 2015 22:05
To: Tom Mannerhagen
Cc: Darren Hart; platform-driver-x86@vger.kernel.org
Subject: Re: toshiba_acpi.c

Hi Tom,

2015-02-25 13:42 GMT-07:00 Tom Mannerhagen <tom.mannerhagen@gmail.com>:
> Thanks!
>
> I think I need to rephrase a bit.
>
> How is the driver distinguishing which mapping to apply depending on which model it is running on?

Currently we use the "toshiba_alt_keymap_dmi" list, but only 3 models have been added to it, Satellite M840, Qosmio X75-A and TECRA A50-A.

I know that there are a lot more out there, but these are the ones that the driver currently know of...

>
> Why I am asking:
> I'm since 26 years involved in technical support of Toshiba notebooks, a happy Linux-user also trying to help other Toshiba owners using Linux on Toshiba's.
> In that scope I can see that some features (Hotkeys), probably provided by the toshiba_acpi-driver, does not work on every platform.
> More in detail - mappings are not always correct.
> It lies more in my personal interest than my profession to see this improved.

Without propper documentation from Toshiba, we are left in the blind and only rely on what we (or other people, bug reports, etc.) know of, however, I made some progress on identifying the HCI call for the hotkey event type (patch comming soon), needed for some laptops supporting the "Special Functions", which happens to be those affected by the new keymap layout.

If you are a Toshiba laptop owner and/or have access to more hardware than I do (currently
2 laptops, Qosmio X505 and Qosmio X75), I could use some testing ;-)

>
> BR Tom
>

Cheers
Azael


--
-- El mundo apesta y vosotros apestais tambien --

Re: toshiba_acpi.c

[Azael Avalos]

Hi Tom,

2015-02-26 0:42 GMT-07:00 Tom Mannerhagen <tom.mannerhagen@gmail.com>:
> Hi Azael
>
> I see, but that concerns the alternative map, correct?

Yes

> How does the driver tell if it should use the "standard" or alternative mapping?

On the patches that I will send (hopefully later today),
a call to an HCI function is made, which tells us the hotkey
events type, so far, there are two types "normal" and "special",
where "normal" covers all the old key mappings and the
"special" covers the new one.

>
> I think I can see some checks are made in the beginning of the driver, it checks for certain ACPI ID's (TOS6200, TOS6207, TOS6028, TOS1900).
> Are they used to identify the system as a Toshiba or are they used to distinguish which Toshiba-platform it runs on?
> Perhaps both?

I'm not sure what you men by platform, but those HIDs represent the
Toshiba Configuration Interface devices (or TVAP - Toshiba Value
Added Package), and yes, they are used to identify the system
as a Toshiba laptop, at least as hotkeys, backlight and some other
system stuff concerns, as there are more IDs on the system, but they
cover Bluetooth (TOS6205) and Accelerometer (TOS620A).

>
> If used to tell which Toshiba it runs on, is this somehow used to select mapping of the function-keys?
>
> BTW - I have access to a bunch of units and will happily test as time allow.
> You may need to hand-hold me through the building of the driver and using it in a distro.

Well, as long as you have installed the kernel sources, make and gcc,
we are fine, I can provide you with a Makefile and the source to test,
and a simple:

make
sudo make install
sudo make load

Will do the trick ;-)

>
> BR Tom
>

Cheers
Azael


-- 
-- El mundo apesta y vosotros apestais tambien --