All of lore.kernel.org
 help / color / mirror / Atom feed
From: <lukasz.michalski@onet.pl>
To: <linux-wireless@vger.kernel.org>, <nbd@nbd.name>, <lorenzo@kernel.org>
Subject: wifi: mt76: mt7915: fix broken background radar implementation
Date: Fri, 21 Feb 2025 16:35:11 +0100	[thread overview]
Message-ID: <003401db8476$348684c0$9d938e40$@onet.pl> (raw)

Currently enabling background radar in hostapd results in unreachable AP.
There is because of mistake in enabling background radar implementation for
mt7915 mcu driver - 3rd and 4th parameters are swapped.
mt76_connac_mcu_rdd_cmd requires rx_sel as a fourth parameter but this
parameter is provided as third argument.
Fix was tested on mt7981 and background radar works now correctly. Other
mt76 drivers do not have similar issues.
The issue was also described here:
https://github.com/openwrt/mt76/issues/958

Signed-off-by: Lukasz Michalski <lukasz.michalski@onet.pl>
---
 drivers/net/wireless/mt76/mt7915/mcu.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/wireless/mt76/mt7915/mcu.c
b/drivers/net/wireless/mt76/mt7915/mcu.c
index 9d790f23..a2bad361 100644
--- a/drivers/net/wireless/mt76/mt7915/mcu.c
+++ b/ drivers/net/wireless/mt76/mt7915/mcu.c
@@ -2718,8 +2718,8 @@ int mt7915_mcu_rdd_background_enable(str
 	int err, region;
 
 	if (!chandef) { /* disable offchain */
-		err = mt76_connac_mcu_rdd_cmd(&dev->mt76, RDD_STOP,
MT_RX_SEL2,
-					      0, 0);
+		err = mt76_connac_mcu_rdd_cmd(&dev->mt76, RDD_STOP, 0,
+					      MT_RX_SEL2, 0);
 		if (err)
 			return err;
 
@@ -2745,8 +2745,8 @@ int mt7915_mcu_rdd_background_enable(str
 		break;
 	}
 
-	return mt76_connac_mcu_rdd_cmd(&dev->mt76, RDD_START, MT_RX_SEL2,
-				       0, region);
+	return mt76_connac_mcu_rdd_cmd(&dev->mt76, RDD_START, 0,
+				       MT_RX_SEL2, region);
 }
 
 int mt7915_mcu_set_chan_info(struct mt7915_phy *phy, int cmd)


             reply	other threads:[~2025-02-21 15:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-21 15:35 lukasz.michalski [this message]
2025-02-25 20:30 ` wifi: mt76: mt7915: fix broken background radar implementation Felix Fietkau
2025-02-26 15:23   ` lukasz.michalski
2025-02-26 15:41     ` Felix Fietkau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='003401db8476$348684c0$9d938e40$@onet.pl' \
    --to=lukasz.michalski@onet.pl \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=nbd@nbd.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.