All of lore.kernel.org
 help / color / mirror / Atom feed
From: <lukasz.michalski@onet.pl>
To: "'Felix Fietkau'" <nbd@nbd.name>
Cc: <linux-wireless@vger.kernel.org>, <lorenzo@kernel.org>
Subject: RE: wifi: mt76: mt7915: fix broken background radar implementation
Date: Wed, 26 Feb 2025 16:23:29 +0100	[thread overview]
Message-ID: <003601db8862$65a75800$30f60800$@onet.pl> (raw)
In-Reply-To: <da6e61d7-0457-43d6-8ce9-a5a94ecf431a@nbd.name>

Hi Felix, thanks for the info.

Is it only about mt7981 or mt7986 too?
Strange that patched code works flawlessly (or maybe firmware just sliently ignores scan requests?).

Lukasz Michalski

-----Original Message-----
From: Felix Fietkau <nbd@nbd.name> 
Sent: Tuesday, February 25, 2025 9:30 PM
To: lukasz.michalski@onet.pl; linux-wireless@vger.kernel.org; lorenzo@kernel.org
Subject: Re: wifi: mt76: mt7915: fix broken background radar implementation

Hi Lukasz,

On 21.02.25 16:35, lukasz.michalski@onet.pl wrote:
> Currently enabling background radar in hostapd results in unreachable AP.
> There is because of mistake in enabling background radar 
> implementation for
> mt7915 mcu driver - 3rd and 4th parameters are swapped.
> mt76_connac_mcu_rdd_cmd requires rx_sel as a fourth parameter but this 
> parameter is provided as third argument.
> Fix was tested on mt7981 and background radar works now correctly. 
> Other
> mt76 drivers do not have similar issues.
> The issue was also described here:
> https://github.com/openwrt/mt76/issues/958
> 
> Signed-off-by: Lukasz Michalski <lukasz.michalski@onet.pl>

MediaTek informed me that MT7981 does not actually have background radar detection in hardware, so this patch can't be merged.
We should instead change the driver code to refuse attempts to enable background radar detection on this chip.

- Felix


  reply	other threads:[~2025-02-26 15:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-21 15:35 wifi: mt76: mt7915: fix broken background radar implementation lukasz.michalski
2025-02-25 20:30 ` Felix Fietkau
2025-02-26 15:23   ` lukasz.michalski [this message]
2025-02-26 15:41     ` Felix Fietkau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='003601db8862$65a75800$30f60800$@onet.pl' \
    --to=lukasz.michalski@onet.pl \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=nbd@nbd.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.