[KJ] drivers\char\pcmcia\synclink_cs.c

[KJ] drivers\char\pcmcia\synclink_cs.c

[Christophe Jaillet]

[-- Attachment #1.1: Type: text/plain, Size: 416 bytes --]

In file :            \drivers\char\pcmcia\synclink_cs.c
In function :    line_info(char *buf, MGSLPC_INFO *info)

The buffer *stat_buf* could be defined smaller.

It is used to build a string that can not be longer than "|RTS|CTS|DTR|DSR|CD|RI", that is to say 21 + 1 chars so :

     char stat_buf[22];
instead of
    char stat_buf[30];
would be enough and would save a few bytes on the stack.

CJ



[-- Attachment #1.2: Type: text/html, Size: 1419 bytes --]

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] drivers\char\pcmcia\synclink_cs.c

[Nish Aravamudan]

On 11/25/05, Christophe Jaillet <christophe.jaillet@wanadoo.fr> wrote:
>
> In file :            \drivers\char\pcmcia\synclink_cs.c
> In function :    line_info(char *buf, MGSLPC_INFO *info)
>
> The buffer *stat_buf* could be defined smaller.

Where's the patch?

Thanks,
Nish

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors