All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Allen Hubbe" <Allen.Hubbe@dell.com>
To: 'Allen Hubbe' <Allen.Hubbe@dell.com>,
	'Serge Semin' <fancer.lancer@gmail.com>,
	jdmason@kudzu.us, dave.jiang@intel.com, Xiangliang.Yu@amd.com
Cc: Sergey.Semin@t-platforms.ru, linux-ntb@googlegroups.com,
	linux-kernel@vger.kernel.org
Subject: RE: [PATCH 02/22] NTB: Add peer indexed ports NTB API
Date: Wed, 7 Dec 2016 17:56:02 -0500	[thread overview]
Message-ID: <003f01d250dd$16de5630$449b0290$@dell.com> (raw)
In-Reply-To: <003d01d24dc1$f5ba4d60$e12ee820$@dell.com>

From: Allen Hubbe
> From: Serge Semin
> > Add new port-index NTB API. Additionally lets get rid of Primary and
> > Secondary topologies, since port-number can be effectively used instead.
> 
> Split into two patches please.
> 
> I see no harm to the TOPO changes, though I wonder if they are necessary.
> 

I am leaning more toward recommending that the topo api be left alone.

The topo changes to the ntb api complicate the Intel driver:
 - The changes add second branches where there had been just one before (need to check topo AND port now).
 - The changes also cause some complicated merge conflicts with https://github.com/davejiang/linux.git ntb.

See RE: [PATCH 10/22] NTB Intel: Add port-related NTB API callback methods

If we leave the ntb topo api as it was, then on multiport devices, if the local port is not the primary port, let it be one of potentially many secondary ports.  Or, if there is no distinction between primary/secondary on some hardware, let them all be primary.

This topo api doesn't have much value for existing drivers (that I know of), except for informative purposes.  So, my preference for changing it would be, only if necessary, and to minimize changes otherwise.

Allen


WARNING: multiple messages have this Message-ID (diff)
From: "Allen Hubbe" <Allen.Hubbe@dell.com>
To: "'Allen Hubbe'" <Allen.Hubbe@dell.com>,
	"'Serge Semin'" <fancer.lancer@gmail.com>, <jdmason@kudzu.us>,
	<dave.jiang@intel.com>, <Xiangliang.Yu@amd.com>
Cc: <Sergey.Semin@t-platforms.ru>, <linux-ntb@googlegroups.com>,
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 02/22] NTB: Add peer indexed ports NTB API
Date: Wed, 7 Dec 2016 17:56:02 -0500	[thread overview]
Message-ID: <003f01d250dd$16de5630$449b0290$@dell.com> (raw)
In-Reply-To: <003d01d24dc1$f5ba4d60$e12ee820$@dell.com>

From: Allen Hubbe
> From: Serge Semin
> > Add new port-index NTB API. Additionally lets get rid of Primary and
> > Secondary topologies, since port-number can be effectively used instead.
> 
> Split into two patches please.
> 
> I see no harm to the TOPO changes, though I wonder if they are necessary.
> 

I am leaning more toward recommending that the topo api be left alone.

The topo changes to the ntb api complicate the Intel driver:
 - The changes add second branches where there had been just one before (need to check topo AND port now).
 - The changes also cause some complicated merge conflicts with https://github.com/davejiang/linux.git ntb.

See RE: [PATCH 10/22] NTB Intel: Add port-related NTB API callback methods

If we leave the ntb topo api as it was, then on multiport devices, if the local port is not the primary port, let it be one of potentially many secondary ports.  Or, if there is no distinction between primary/secondary on some hardware, let them all be primary.

This topo api doesn't have much value for existing drivers (that I know of), except for informative purposes.  So, my preference for changing it would be, only if necessary, and to minimize changes otherwise.

Allen

  reply	other threads:[~2016-12-07 22:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-04  0:04 [PATCH 02/22] NTB: Add peer indexed ports NTB API Allen Hubbe
2016-12-04  0:04 ` Allen Hubbe
2016-12-07 22:56 ` Allen Hubbe [this message]
2016-12-07 22:56   ` Allen Hubbe
  -- strict thread matches above, loose matches on Subject: below --
2016-11-29 17:15 [PATCH 00/22] NTB: Alter kernel API to support multi-port devices Serge Semin
2016-11-29 17:15 ` [PATCH 02/22] NTB: Add peer indexed ports NTB API Serge Semin
2016-11-30 18:40   ` kbuild test robot
2016-11-30 19:12   ` kbuild test robot
2016-11-30 20:04   ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='003f01d250dd$16de5630$449b0290$@dell.com' \
    --to=allen.hubbe@dell.com \
    --cc=Sergey.Semin@t-platforms.ru \
    --cc=Xiangliang.Yu@amd.com \
    --cc=dave.jiang@intel.com \
    --cc=fancer.lancer@gmail.com \
    --cc=jdmason@kudzu.us \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-ntb@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.