From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Patil, Shubham Sanjay" <shubpati@amd.com>,
Shubham Patil <shubhamsanjay.patil@amd.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Frank Li <Frank.Li@nxp.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-i3c@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, "git (AMD-Xilinx)" <git@amd.com>
Subject: Re: [PATCH 1/3] dt-bindings: i3c: xlnx: Add IBI and hot-join capability properties
Date: Tue, 18 Aug 2026 20:36:16 +0200 [thread overview]
Message-ID: <003fbd61-2e3d-4a31-9b92-60dfeb3bee34@kernel.org> (raw)
In-Reply-To: <372395b9-be14-40c5-984d-3d725f20cec9@amd.com>
On 18/08/2026 14:02, Patil, Shubham Sanjay wrote:
> Hi Krzysztof,
>
> On 8/17/2026 2:20 PM, Krzysztof Kozlowski wrote:
>> [You don't often get email from krzk@kernel.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>>
>> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>>
>>
>> On Fri, Aug 14, 2026 at 05:21:53PM +0530, Shubham Patil wrote:
>>> In-Band Interrupt and Hot-Join are synthesis-time options of the AXI I3C
>>> IP. Describe them with two boolean properties.
>>>
>>> A Hot-Join request is acknowledged by the IBI machinery, so a hot-join
>>> capable design is always IBI capable as well. Both events are reported
>>> through the controller interrupt, which is therefore required whenever
>>> the capability is present.
>>>
>>> Signed-off-by: Shubham Patil <shubhamsanjay.patil@amd.com>
>>> ---
>>> .../bindings/i3c/xlnx,axi-i3c-1.0.yaml | 23 +++++++++++++++++++
>>> 1 file changed, 23 insertions(+)
>>>
>>
>> So the same SoC using this core will have different synthesis options?
>> IOW, why isn't this implied by a specific compatible?
>
> Yes. This core is not part of the SoC's fixed hardware: it is a design
> compiled into the FPGA fabric. When the core is added to a design in
> Vivado, IBI and Hot-Join are options that are turned on or off, so two
> builds -- or two instances in the same build -- can use the identical IP
> version and still differ in which features are present.
>
> The compatible string identifies the IP core and its version. It says
Well, you miss SoC compatibles so you cannot use argument of IP core.
Although I do accept argument of two instances in a SoC having this
different.
> nothing about which options were selected when
> that instance was built, so it cannot imply the capability.
>
> Thanks,
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Patil, Shubham Sanjay" <shubpati@amd.com>,
Shubham Patil <shubhamsanjay.patil@amd.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Frank Li <Frank.Li@nxp.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-i3c@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, "git (AMD-Xilinx)" <git@amd.com>
Subject: Re: [PATCH 1/3] dt-bindings: i3c: xlnx: Add IBI and hot-join capability properties
Date: Tue, 18 Aug 2026 20:36:16 +0200 [thread overview]
Message-ID: <003fbd61-2e3d-4a31-9b92-60dfeb3bee34@kernel.org> (raw)
In-Reply-To: <372395b9-be14-40c5-984d-3d725f20cec9@amd.com>
On 18/08/2026 14:02, Patil, Shubham Sanjay wrote:
> Hi Krzysztof,
>
> On 8/17/2026 2:20 PM, Krzysztof Kozlowski wrote:
>> [You don't often get email from krzk@kernel.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>>
>> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>>
>>
>> On Fri, Aug 14, 2026 at 05:21:53PM +0530, Shubham Patil wrote:
>>> In-Band Interrupt and Hot-Join are synthesis-time options of the AXI I3C
>>> IP. Describe them with two boolean properties.
>>>
>>> A Hot-Join request is acknowledged by the IBI machinery, so a hot-join
>>> capable design is always IBI capable as well. Both events are reported
>>> through the controller interrupt, which is therefore required whenever
>>> the capability is present.
>>>
>>> Signed-off-by: Shubham Patil <shubhamsanjay.patil@amd.com>
>>> ---
>>> .../bindings/i3c/xlnx,axi-i3c-1.0.yaml | 23 +++++++++++++++++++
>>> 1 file changed, 23 insertions(+)
>>>
>>
>> So the same SoC using this core will have different synthesis options?
>> IOW, why isn't this implied by a specific compatible?
>
> Yes. This core is not part of the SoC's fixed hardware: it is a design
> compiled into the FPGA fabric. When the core is added to a design in
> Vivado, IBI and Hot-Join are options that are turned on or off, so two
> builds -- or two instances in the same build -- can use the identical IP
> version and still differ in which features are present.
>
> The compatible string identifies the IP core and its version. It says
Well, you miss SoC compatibles so you cannot use argument of IP core.
Although I do accept argument of two instances in a SoC having this
different.
> nothing about which options were selected when
> that instance was built, so it cannot imply the capability.
>
> Thanks,
Best regards,
Krzysztof
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2026-08-18 18:36 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 11:51 [PATCH 0/3] i3c: master: amd: Add IBI and hot-join support Shubham Patil
2026-08-14 11:51 ` Shubham Patil
2026-08-14 11:51 ` [PATCH 1/3] dt-bindings: i3c: xlnx: Add IBI and hot-join capability properties Shubham Patil
2026-08-14 11:51 ` Shubham Patil
2026-08-14 15:38 ` Conor Dooley
2026-08-14 15:38 ` Conor Dooley
2026-08-18 10:38 ` Patil, Shubham Sanjay
2026-08-18 10:38 ` Patil, Shubham Sanjay
2026-08-14 17:07 ` Frank Li
2026-08-14 17:07 ` Frank Li
2026-08-18 11:59 ` Patil, Shubham Sanjay
2026-08-18 11:59 ` Patil, Shubham Sanjay
2026-08-18 16:51 ` Frank Li
2026-08-18 16:51 ` Frank Li
2026-08-17 8:50 ` Krzysztof Kozlowski
2026-08-17 8:50 ` Krzysztof Kozlowski
2026-08-18 12:02 ` Patil, Shubham Sanjay
2026-08-18 12:02 ` Patil, Shubham Sanjay
2026-08-18 18:36 ` Krzysztof Kozlowski [this message]
2026-08-18 18:36 ` Krzysztof Kozlowski
2026-08-18 23:29 ` Conor Dooley
2026-08-14 11:51 ` [PATCH 2/3] i3c: master: amd: Add support for in-band interrupts Shubham Patil
2026-08-14 11:51 ` Shubham Patil
2026-08-14 12:05 ` sashiko-bot
2026-08-14 12:05 ` sashiko-bot
2026-08-14 11:51 ` [PATCH 3/3] i3c: master: amd: Add hot-join support Shubham Patil
2026-08-14 11:51 ` Shubham Patil
2026-08-14 12:05 ` sashiko-bot
2026-08-14 12:05 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=003fbd61-2e3d-4a31-9b92-60dfeb3bee34@kernel.org \
--to=krzk@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=git@amd.com \
--cc=krzk+dt@kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=shubhamsanjay.patil@amd.com \
--cc=shubpati@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.