From: "Steve Wise" <swise@opengridcomputing.com>
To: 'Baoyou Xie' <baoyou.xie@linaro.org>,
dledford@redhat.com, sean.hefty@intel.com,
hal.rosenstock@gmail.com
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
arnd@linaro.org, xie.baoyou@zte.com.cn
Subject: RE: [PATCH v3] IB/cxgb4: Mark symbols static for _free_qp
Date: Mon, 29 Aug 2016 09:26:01 -0500 [thread overview]
Message-ID: <004001d20201$448119e0$cd834da0$@opengridcomputing.com> (raw)
In-Reply-To: <1472396231-16937-1-git-send-email-baoyou.xie@linaro.org>
> Subject: [PATCH v3] IB/cxgb4: Mark symbols static for _free_qp
>
> We get 1 warning when build kernel with W=1:
> drivers/infiniband/hw/cxgb4/qp.c:686:6: warning: no previous prototype for
> '_free_qp' [-Wmissing-prototypes]
>
> In fact, this function is only used in the file in which it is declared
> and don't need a declaration, but can be made static.
> so this patch marks it 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
> Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Ignore my comment on v2...
Acked-by: Steve Wise <swise@opengridcomputing.com>
WARNING: multiple messages have this Message-ID (diff)
From: "Steve Wise" <swise@opengridcomputing.com>
To: "'Baoyou Xie'" <baoyou.xie@linaro.org>, <dledford@redhat.com>,
<sean.hefty@intel.com>, <hal.rosenstock@gmail.com>
Cc: <linux-rdma@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<arnd@linaro.org>, <xie.baoyou@zte.com.cn>
Subject: RE: [PATCH v3] IB/cxgb4: Mark symbols static for _free_qp
Date: Mon, 29 Aug 2016 09:26:01 -0500 [thread overview]
Message-ID: <004001d20201$448119e0$cd834da0$@opengridcomputing.com> (raw)
In-Reply-To: <1472396231-16937-1-git-send-email-baoyou.xie@linaro.org>
> Subject: [PATCH v3] IB/cxgb4: Mark symbols static for _free_qp
>
> We get 1 warning when build kernel with W=1:
> drivers/infiniband/hw/cxgb4/qp.c:686:6: warning: no previous prototype for
> '_free_qp' [-Wmissing-prototypes]
>
> In fact, this function is only used in the file in which it is declared
> and don't need a declaration, but can be made static.
> so this patch marks it 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
> Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Ignore my comment on v2...
Acked-by: Steve Wise <swise@opengridcomputing.com>
next prev parent reply other threads:[~2016-08-29 14:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-28 14:57 [PATCH v3] IB/cxgb4: Mark symbols static for _free_qp Baoyou Xie
2016-08-28 14:57 ` Baoyou Xie
2016-08-29 14:26 ` Steve Wise [this message]
2016-08-29 14:26 ` Steve Wise
2016-09-02 17:23 ` Doug Ledford
2016-09-02 17:23 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='004001d20201$448119e0$cd834da0$@opengridcomputing.com' \
--to=swise@opengridcomputing.com \
--cc=arnd@linaro.org \
--cc=baoyou.xie@linaro.org \
--cc=dledford@redhat.com \
--cc=hal.rosenstock@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sean.hefty@intel.com \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.