From: "Steve Wise" <swise@opengridcomputing.com>
To: 'Dan Carpenter' <dan.carpenter@oracle.com>,
'Steve Wise' <swise@chelsio.com>
Cc: 'Doug Ledford' <dledford@redhat.com>,
'Sean Hefty' <sean.hefty@intel.com>,
'Hal Rosenstock' <hal.rosenstock@gmail.com>,
linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: RE: [PATCH] IB/cxgb3: Fix error codes in iwch_alloc_mr()
Date: Thu, 13 Jul 2017 14:35:48 +0000 [thread overview]
Message-ID: <005801d2fbe5$5193d0d0$f4bb7270$@opengridcomputing.com> (raw)
In-Reply-To: <20170713074800.dlzwroi4jmuv5xfk@mwanda>
> We accidentally don't set the error code on some error paths. It means
> return ERR_PTR(0) which is NULL and results in a NULL dereference in the
> caller.
>
> Fixes: 13a239330abd ("RDMA/cxgb3: Don't ignore insert_handle() failures")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Acked-by: Steve Wise <swise@opengridcomputing.com>
WARNING: multiple messages have this Message-ID (diff)
From: "Steve Wise" <swise@opengridcomputing.com>
To: 'Dan Carpenter' <dan.carpenter@oracle.com>,
'Steve Wise' <swise@chelsio.com>
Cc: 'Doug Ledford' <dledford@redhat.com>,
'Sean Hefty' <sean.hefty@intel.com>,
'Hal Rosenstock' <hal.rosenstock@gmail.com>,
linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: RE: [PATCH] IB/cxgb3: Fix error codes in iwch_alloc_mr()
Date: Thu, 13 Jul 2017 09:35:48 -0500 [thread overview]
Message-ID: <005801d2fbe5$5193d0d0$f4bb7270$@opengridcomputing.com> (raw)
In-Reply-To: <20170713074800.dlzwroi4jmuv5xfk@mwanda>
> We accidentally don't set the error code on some error paths. It means
> return ERR_PTR(0) which is NULL and results in a NULL dereference in the
> caller.
>
> Fixes: 13a239330abd ("RDMA/cxgb3: Don't ignore insert_handle() failures")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Acked-by: Steve Wise <swise@opengridcomputing.com>
next prev parent reply other threads:[~2017-07-13 14:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 7:48 [PATCH] IB/cxgb3: Fix error codes in iwch_alloc_mr() Dan Carpenter
2017-07-13 7:48 ` Dan Carpenter
2017-07-13 14:35 ` Steve Wise [this message]
2017-07-13 14:35 ` Steve Wise
2017-07-22 17:28 ` Doug Ledford
2017-07-22 17:28 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='005801d2fbe5$5193d0d0$f4bb7270$@opengridcomputing.com' \
--to=swise@opengridcomputing.com \
--cc=dan.carpenter@oracle.com \
--cc=dledford@redhat.com \
--cc=hal.rosenstock@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sean.hefty@intel.com \
--cc=swise@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.