* [PATCH 0256/1285] Replace numeric parameter like 0444 with macro
@ 2016-08-02 10:53 Baole Ni
[not found] ` <20160802105352.30808-1-baolex.ni-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Baole Ni @ 2016-08-02 10:53 UTC (permalink / raw)
To: swise, dledford, sean.hefty, hal.rosenstock, airlied, kgene,
k.kozlowski, dougthompson, bp
Cc: linux-rdma, linux-kernel, chuansheng.liu, baolex.ni, hch, matanb,
markb, jgunthorpe, dean.luick
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
drivers/infiniband/hw/cxgb4/mem.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/cxgb4/mem.c b/drivers/infiniband/hw/cxgb4/mem.c
index 55d0651..73fccdc 100644
--- a/drivers/infiniband/hw/cxgb4/mem.c
+++ b/drivers/infiniband/hw/cxgb4/mem.c
@@ -39,7 +39,7 @@
#include "iw_cxgb4.h"
int use_dsgl = 0;
-module_param(use_dsgl, int, 0644);
+module_param(use_dsgl, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(use_dsgl, "Use DSGL for PBL/FastReg (default=0)");
#define T4_ULPTX_MIN_IO 32
@@ -48,7 +48,7 @@ MODULE_PARM_DESC(use_dsgl, "Use DSGL for PBL/FastReg (default=0)");
#define C4IW_INLINE_THRESHOLD 128
static int inline_threshold = C4IW_INLINE_THRESHOLD;
-module_param(inline_threshold, int, 0644);
+module_param(inline_threshold, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(inline_threshold, "inline vs dsgl threshold (default=128)");
static int mr_exceeds_hw_limits(struct c4iw_dev *dev, u64 length)
--
2.9.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH 0256/1285] Replace numeric parameter like 0444 with macro
2016-08-02 10:53 [PATCH 0256/1285] Replace numeric parameter like 0444 with macro Baole Ni
@ 2016-08-02 14:12 ` Steve Wise
0 siblings, 0 replies; 3+ messages in thread
From: Steve Wise @ 2016-08-02 14:12 UTC (permalink / raw)
To: 'Baole Ni', swise-ut6Up61K2wZBDgjK7y7TUQ,
dledford-H+wXaHxf7aLQT0dZR+AlfA,
sean.hefty-ral2JQCrhuEAvxtiuMwx3w,
hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w, airlied-cv59FeDIM0c,
kgene-DgEjT+Ai2ygdnm+yROfE0A, k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ,
dougthompson-aS9lmoZGLiVWk0Htik3J/w, bp-Gina5bIWoIWzQB+pC5nmwQ
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
chuansheng.liu-ral2JQCrhuEAvxtiuMwx3w, hch-wEGCiKHe2LqWVfeAwA7xHQ,
matanb-VPRAkNaXOzVWk0Htik3J/w, markb-VPRAkNaXOzVWk0Htik3J/w,
jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/,
dean.luick-ral2JQCrhuEAvxtiuMwx3w
Acked-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH 0256/1285] Replace numeric parameter like 0444 with macro
@ 2016-08-02 14:12 ` Steve Wise
0 siblings, 0 replies; 3+ messages in thread
From: Steve Wise @ 2016-08-02 14:12 UTC (permalink / raw)
To: 'Baole Ni', swise, dledford, sean.hefty, hal.rosenstock,
airlied, kgene, k.kozlowski, dougthompson, bp
Cc: linux-rdma, linux-kernel, chuansheng.liu, hch, matanb, markb,
jgunthorpe, dean.luick
Acked-by: Steve Wise <swise@opengridcomputing.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-02 14:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-02 10:53 [PATCH 0256/1285] Replace numeric parameter like 0444 with macro Baole Ni
[not found] ` <20160802105352.30808-1-baolex.ni-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-08-02 14:12 ` Steve Wise
2016-08-02 14:12 ` Steve Wise
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.