* [PATCH 19/22] mmc: sdhci-spear: remove unnecessary platform_set_drvdata()
@ 2013-05-06 6:37 Jingoo Han
2013-05-12 15:05 ` Viresh Kumar
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-05-06 6:37 UTC (permalink / raw)
To: 'Chris Ball'; +Cc: linux-mmc, Jingoo Han, Viresh Kumar
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mmc/host/sdhci-spear.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c
index 7ae5b3a..2dba9f8 100644
--- a/drivers/mmc/host/sdhci-spear.c
+++ b/drivers/mmc/host/sdhci-spear.c
@@ -258,7 +258,6 @@ static int sdhci_probe(struct platform_device *pdev)
return 0;
set_drvdata:
- platform_set_drvdata(pdev, NULL);
sdhci_remove_host(host, 1);
free_host:
sdhci_free_host(host);
@@ -278,7 +277,6 @@ static int sdhci_remove(struct platform_device *pdev)
int dead = 0;
u32 scratch;
- platform_set_drvdata(pdev, NULL);
scratch = readl(host->ioaddr + SDHCI_INT_STATUS);
if (scratch == (u32)-1)
dead = 1;
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 19/22] mmc: sdhci-spear: remove unnecessary platform_set_drvdata()
2013-05-06 6:37 [PATCH 19/22] mmc: sdhci-spear: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-05-12 15:05 ` Viresh Kumar
0 siblings, 0 replies; 2+ messages in thread
From: Viresh Kumar @ 2013-05-12 15:05 UTC (permalink / raw)
To: Jingoo Han; +Cc: Chris Ball, linux-mmc
On Mon, May 6, 2013 at 12:07 PM, Jingoo Han <jg1.han@samsung.com> wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/mmc/host/sdhci-spear.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c
> index 7ae5b3a..2dba9f8 100644
> --- a/drivers/mmc/host/sdhci-spear.c
> +++ b/drivers/mmc/host/sdhci-spear.c
> @@ -258,7 +258,6 @@ static int sdhci_probe(struct platform_device *pdev)
> return 0;
>
> set_drvdata:
> - platform_set_drvdata(pdev, NULL);
> sdhci_remove_host(host, 1);
> free_host:
> sdhci_free_host(host);
> @@ -278,7 +277,6 @@ static int sdhci_remove(struct platform_device *pdev)
> int dead = 0;
> u32 scratch;
>
> - platform_set_drvdata(pdev, NULL);
> scratch = readl(host->ioaddr + SDHCI_INT_STATUS);
> if (scratch == (u32)-1)
> dead = 1;
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-12 15:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-06 6:37 [PATCH 19/22] mmc: sdhci-spear: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-12 15:05 ` Viresh Kumar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.