* [PATCH 0255/1285] Replace numeric parameter like 0444 with macro
@ 2016-08-02 10:53 ` Baole Ni
0 siblings, 0 replies; 4+ messages in thread
From: Baole Ni @ 2016-08-02 10:53 UTC (permalink / raw)
To: swise-ut6Up61K2wZBDgjK7y7TUQ, dledford-H+wXaHxf7aLQT0dZR+AlfA,
sean.hefty-ral2JQCrhuEAvxtiuMwx3w,
hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w, airlied-cv59FeDIM0c,
kgene-DgEjT+Ai2ygdnm+yROfE0A, k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ,
dougthompson-aS9lmoZGLiVWk0Htik3J/w, bp-Gina5bIWoIWzQB+pC5nmwQ
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
chuansheng.liu-ral2JQCrhuEAvxtiuMwx3w,
baolex.ni-ral2JQCrhuEAvxtiuMwx3w, hch-wEGCiKHe2LqWVfeAwA7xHQ,
matanb-VPRAkNaXOzVWk0Htik3J/w, markb-VPRAkNaXOzVWk0Htik3J/w,
jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/,
dean.luick-ral2JQCrhuEAvxtiuMwx3w
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Signed-off-by: Baole Ni <baolex.ni-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
drivers/infiniband/hw/cxgb4/device.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/infiniband/hw/cxgb4/device.c b/drivers/infiniband/hw/cxgb4/device.c
index ae2e8b2..e974afb 100644
--- a/drivers/infiniband/hw/cxgb4/device.c
+++ b/drivers/infiniband/hw/cxgb4/device.c
@@ -47,21 +47,21 @@ MODULE_LICENSE("Dual BSD/GPL");
MODULE_VERSION(DRV_VERSION);
static int allow_db_fc_on_t5;
-module_param(allow_db_fc_on_t5, int, 0644);
+module_param(allow_db_fc_on_t5, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(allow_db_fc_on_t5,
"Allow DB Flow Control on T5 (default = 0)");
static int allow_db_coalescing_on_t5;
-module_param(allow_db_coalescing_on_t5, int, 0644);
+module_param(allow_db_coalescing_on_t5, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(allow_db_coalescing_on_t5,
"Allow DB Coalescing on T5 (default = 0)");
int c4iw_wr_log = 0;
-module_param(c4iw_wr_log, int, 0444);
+module_param(c4iw_wr_log, int, S_IRUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(c4iw_wr_log, "Enables logging of work request timing data.");
static int c4iw_wr_log_size_order = 12;
-module_param(c4iw_wr_log_size_order, int, 0444);
+module_param(c4iw_wr_log_size_order, int, S_IRUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(c4iw_wr_log_size_order,
"Number of entries (log2) in the work request timing log.");
--
2.9.2
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 0255/1285] Replace numeric parameter like 0444 with macro
@ 2016-08-02 10:53 ` Baole Ni
0 siblings, 0 replies; 4+ messages in thread
From: Baole Ni @ 2016-08-02 10:53 UTC (permalink / raw)
To: swise, dledford, sean.hefty, hal.rosenstock, airlied, kgene,
k.kozlowski, dougthompson, bp
Cc: linux-rdma, linux-kernel, chuansheng.liu, baolex.ni, hch, matanb,
markb, jgunthorpe, dean.luick
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
drivers/infiniband/hw/cxgb4/device.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/infiniband/hw/cxgb4/device.c b/drivers/infiniband/hw/cxgb4/device.c
index ae2e8b2..e974afb 100644
--- a/drivers/infiniband/hw/cxgb4/device.c
+++ b/drivers/infiniband/hw/cxgb4/device.c
@@ -47,21 +47,21 @@ MODULE_LICENSE("Dual BSD/GPL");
MODULE_VERSION(DRV_VERSION);
static int allow_db_fc_on_t5;
-module_param(allow_db_fc_on_t5, int, 0644);
+module_param(allow_db_fc_on_t5, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(allow_db_fc_on_t5,
"Allow DB Flow Control on T5 (default = 0)");
static int allow_db_coalescing_on_t5;
-module_param(allow_db_coalescing_on_t5, int, 0644);
+module_param(allow_db_coalescing_on_t5, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(allow_db_coalescing_on_t5,
"Allow DB Coalescing on T5 (default = 0)");
int c4iw_wr_log = 0;
-module_param(c4iw_wr_log, int, 0444);
+module_param(c4iw_wr_log, int, S_IRUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(c4iw_wr_log, "Enables logging of work request timing data.");
static int c4iw_wr_log_size_order = 12;
-module_param(c4iw_wr_log_size_order, int, 0444);
+module_param(c4iw_wr_log_size_order, int, S_IRUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(c4iw_wr_log_size_order,
"Number of entries (log2) in the work request timing log.");
--
2.9.2
^ permalink raw reply related [flat|nested] 4+ messages in thread[parent not found: <20160802105346.30742-1-baolex.ni-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]
* RE: [PATCH 0255/1285] Replace numeric parameter like 0444 with macro
2016-08-02 10:53 ` Baole Ni
@ 2016-08-02 14:12 ` Steve Wise
-1 siblings, 0 replies; 4+ messages in thread
From: Steve Wise @ 2016-08-02 14:12 UTC (permalink / raw)
To: 'Baole Ni', swise-ut6Up61K2wZBDgjK7y7TUQ,
dledford-H+wXaHxf7aLQT0dZR+AlfA,
sean.hefty-ral2JQCrhuEAvxtiuMwx3w,
hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w, airlied-cv59FeDIM0c,
kgene-DgEjT+Ai2ygdnm+yROfE0A, k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ,
dougthompson-aS9lmoZGLiVWk0Htik3J/w, bp-Gina5bIWoIWzQB+pC5nmwQ
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
chuansheng.liu-ral2JQCrhuEAvxtiuMwx3w, hch-wEGCiKHe2LqWVfeAwA7xHQ,
matanb-VPRAkNaXOzVWk0Htik3J/w, markb-VPRAkNaXOzVWk0Htik3J/w,
jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/,
dean.luick-ral2JQCrhuEAvxtiuMwx3w
Acked-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH 0255/1285] Replace numeric parameter like 0444 with macro
@ 2016-08-02 14:12 ` Steve Wise
0 siblings, 0 replies; 4+ messages in thread
From: Steve Wise @ 2016-08-02 14:12 UTC (permalink / raw)
To: 'Baole Ni', swise, dledford, sean.hefty, hal.rosenstock,
airlied, kgene, k.kozlowski, dougthompson, bp
Cc: linux-rdma, linux-kernel, chuansheng.liu, hch, matanb, markb,
jgunthorpe, dean.luick
Acked-by: Steve Wise <swise@opengridcomputing.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-08-02 16:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-02 10:53 [PATCH 0255/1285] Replace numeric parameter like 0444 with macro Baole Ni
2016-08-02 10:53 ` Baole Ni
[not found] ` <20160802105346.30742-1-baolex.ni-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-08-02 14:12 ` Steve Wise
2016-08-02 14:12 ` Steve Wise
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.