From: "Steve Wise" <swise@opengridcomputing.com>
To: 'Colin King' <colin.king@canonical.com>,
'Steve Wise' <swise@chelsio.com>,
'Doug Ledford' <dledford@redhat.com>,
'Sean Hefty' <sean.hefty@intel.com>,
'Hal Rosenstock' <hal.rosenstock@gmail.com>,
linux-rdma@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: RE: [PATCH] RDMA/cxgb3: remove redundant first assignement of sqp
Date: Mon, 11 Sep 2017 14:28:14 +0000 [thread overview]
Message-ID: <006201d32b0a$341b5470$9c51fd50$@opengridcomputing.com> (raw)
In-Reply-To: <20170911114231.22893-1-colin.king@canonical.com>
>
> From: Colin Ian King <colin.king@canonical.com>
>
> sqp is being initialised when it is being declared and then updated
> a little later on making the first initialization redundant. Clean
> this up by initializing ptr and sqp at their declaration.
>
> Cleans up warning: "warning: Value stored to 'sqp' during its
> initialization is never read"
>
> Fixes: a58e58fafdff ("RDMA/cxgb3: Wrap the software send queue pointer as
> needed on flush")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Steve Wise <swise@opengridcomputing.com>
WARNING: multiple messages have this Message-ID (diff)
From: "Steve Wise" <swise@opengridcomputing.com>
To: 'Colin King' <colin.king@canonical.com>,
'Steve Wise' <swise@chelsio.com>,
'Doug Ledford' <dledford@redhat.com>,
'Sean Hefty' <sean.hefty@intel.com>,
'Hal Rosenstock' <hal.rosenstock@gmail.com>,
linux-rdma@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: RE: [PATCH] RDMA/cxgb3: remove redundant first assignement of sqp
Date: Mon, 11 Sep 2017 09:28:14 -0500 [thread overview]
Message-ID: <006201d32b0a$341b5470$9c51fd50$@opengridcomputing.com> (raw)
In-Reply-To: <20170911114231.22893-1-colin.king@canonical.com>
>
> From: Colin Ian King <colin.king@canonical.com>
>
> sqp is being initialised when it is being declared and then updated
> a little later on making the first initialization redundant. Clean
> this up by initializing ptr and sqp at their declaration.
>
> Cleans up warning: "warning: Value stored to 'sqp' during its
> initialization is never read"
>
> Fixes: a58e58fafdff ("RDMA/cxgb3: Wrap the software send queue pointer as
> needed on flush")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Steve Wise <swise@opengridcomputing.com>
WARNING: multiple messages have this Message-ID (diff)
From: "Steve Wise" <swise@opengridcomputing.com>
To: "'Colin King'" <colin.king@canonical.com>,
"'Steve Wise'" <swise@chelsio.com>,
"'Doug Ledford'" <dledford@redhat.com>,
"'Sean Hefty'" <sean.hefty@intel.com>,
"'Hal Rosenstock'" <hal.rosenstock@gmail.com>,
<linux-rdma@vger.kernel.org>
Cc: <kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] RDMA/cxgb3: remove redundant first assignement of sqp
Date: Mon, 11 Sep 2017 09:28:14 -0500 [thread overview]
Message-ID: <006201d32b0a$341b5470$9c51fd50$@opengridcomputing.com> (raw)
In-Reply-To: <20170911114231.22893-1-colin.king@canonical.com>
>
> From: Colin Ian King <colin.king@canonical.com>
>
> sqp is being initialised when it is being declared and then updated
> a little later on making the first initialization redundant. Clean
> this up by initializing ptr and sqp at their declaration.
>
> Cleans up warning: "warning: Value stored to 'sqp' during its
> initialization is never read"
>
> Fixes: a58e58fafdff ("RDMA/cxgb3: Wrap the software send queue pointer as
> needed on flush")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Steve Wise <swise@opengridcomputing.com>
next prev parent reply other threads:[~2017-09-11 14:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-11 11:42 [PATCH] RDMA/cxgb3: remove redundant first assignement of sqp Colin King
2017-09-11 11:42 ` Colin King
2017-09-11 11:42 ` Colin King
2017-09-11 14:28 ` Steve Wise [this message]
2017-09-11 14:28 ` Steve Wise
2017-09-11 14:28 ` Steve Wise
2017-09-27 13:11 ` Doug Ledford
2017-09-27 13:11 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='006201d32b0a$341b5470$9c51fd50$@opengridcomputing.com' \
--to=swise@opengridcomputing.com \
--cc=colin.king@canonical.com \
--cc=dledford@redhat.com \
--cc=hal.rosenstock@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sean.hefty@intel.com \
--cc=swise@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.