From: Paul Durrant <xadimgnik@gmail.com>
To: "'Jürgen Groß'" <jgross@suse.com>,
"'Olaf Hering'" <olaf@aepfle.de>,
"'Paul Durrant'" <xadimgnik@gmail.com>
Cc: xen-devel@lists.xenproject.org,
'Ian Jackson' <ian.jackson@eu.citrix.com>, 'Wei Liu' <wl@xen.org>,
'Tim Deegan' <tim@xen.org>
Subject: RE: [PATCH v1] kdd: remove zero-length arrays
Date: Tue, 9 Jun 2020 10:08:57 +0100 [thread overview]
Message-ID: <006301d63e3d$9c141fa0$d43c5ee0$@xen.org> (raw)
In-Reply-To: <e8976262-4406-eaca-6381-0a8c017b4727@suse.com>
> -----Original Message-----
> From: Jürgen Groß <jgross@suse.com>
> Sent: 09 June 2020 10:06
> To: paul@xen.org; 'Olaf Hering' <olaf@aepfle.de>; 'Paul Durrant' <xadimgnik@gmail.com>
> Cc: xen-devel@lists.xenproject.org; 'Ian Jackson' <ian.jackson@eu.citrix.com>; 'Wei Liu' <wl@xen.org>;
> 'Tim Deegan' <tim@xen.org>
> Subject: Re: [PATCH v1] kdd: remove zero-length arrays
>
> On 09.06.20 11:04, Paul Durrant wrote:
> >> -----Original Message-----
> >> From: Olaf Hering <olaf@aepfle.de>
> >> Sent: 09 June 2020 10:00
> >> To: Paul Durrant <xadimgnik@gmail.com>
> >> Cc: paul@xen.org; xen-devel@lists.xenproject.org; 'Ian Jackson' <ian.jackson@eu.citrix.com>; 'Tim
> >> Deegan' <tim@xen.org>; 'Wei Liu' <wl@xen.org>
> >> Subject: Re: [PATCH v1] kdd: remove zero-length arrays
> >>
> >> Am Tue, 9 Jun 2020 09:55:52 +0100
> >> schrieb Paul Durrant <xadimgnik@gmail.com>:
> >>
> >>> Is it not sufficient to just change the declaration of payload in kdd_pkt from [0] to []?
> >>
> >> AFAIR this lead to compile errors.
> >>
> >
> > OOI which compiler (might be worth mentioning in the commit comment too, for reference)? I'm not
> seeing a problem.
>
> We don't use array[] in public headers, but AFAIK using them internally
> is fine.
>
Yeah, we have XEN_FLEX_ARRAY_DIM for public headers.
Paul
>
> Juergen
next prev parent reply other threads:[~2020-06-09 9:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-08 20:38 [PATCH v1] kdd: remove zero-length arrays Olaf Hering
2020-06-09 8:55 ` Paul Durrant
2020-06-09 9:00 ` Olaf Hering
2020-06-09 9:04 ` Paul Durrant
2020-06-09 9:06 ` Jürgen Groß
2020-06-09 9:08 ` Paul Durrant [this message]
2020-06-09 9:37 ` Olaf Hering
2020-06-09 12:15 ` Tim Deegan
2020-06-09 13:22 ` Olaf Hering
2020-06-09 13:26 ` Ian Jackson
2020-06-09 13:32 ` Olaf Hering
2020-06-10 19:16 ` Tim Deegan
2020-06-11 19:10 ` Olaf Hering
2020-06-16 20:50 ` Christopher Clark
2020-06-17 8:21 ` Paul Durrant
2020-06-26 10:26 ` Wei Liu
2020-06-26 10:31 ` Paul Durrant
2020-06-26 10:33 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='006301d63e3d$9c141fa0$d43c5ee0$@xen.org' \
--to=xadimgnik@gmail.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jgross@suse.com \
--cc=olaf@aepfle.de \
--cc=paul@xen.org \
--cc=tim@xen.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.