From: Paul Durrant <xadimgnik@gmail.com>
To: "'Ian Jackson'" <ian.jackson@citrix.com>,
"'Paul Durrant'" <xadimgnik@gmail.com>
Cc: 'Samuel Thibault' <samuel.thibault@ens-lyon.org>,
'Olaf Hering' <olaf@aepfle.de>,
'xen-devel' <xen-devel@lists.xenproject.org>,
'Wei Liu' <wl@xen.org>, 'Jason Andryuk' <jandryuk@gmail.com>
Subject: RE: [XEN PATCH for-4.14 v1] stubdom/vtpm: add extern to function declarations
Date: Thu, 18 Jun 2020 17:01:46 +0100 [thread overview]
Message-ID: <006901d64589$c593c440$50bb4cc0$@xen.org> (raw)
In-Reply-To: <24299.36521.246994.731819@mariner.uk.xensource.com>
> -----Original Message-----
> From: Ian Jackson <ian.jackson@citrix.com>
> Sent: 18 June 2020 16:56
> To: Paul Durrant <xadimgnik@gmail.com>
> Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>; Jason Andryuk <jandryuk@gmail.com>; Olaf Hering
> <olaf@aepfle.de>; xen-devel <xen-devel@lists.xenproject.org>; Wei Liu <wl@xen.org>
> Subject: Re: [XEN PATCH for-4.14 v1] stubdom/vtpm: add extern to function declarations
>
> Samuel Thibault writes ("Re: [PATCH v1] stubdom/vtpm: add extern to function declarations"):
> > Jason Andryuk, le mer. 17 juin 2020 09:35:52 -0400, a ecrit:
> > > On Wed, Jun 17, 2020 at 2:10 AM Olaf Hering <olaf@aepfle.de> wrote:
> > > >
> > > > Code compiled with gcc10 will not link properly due to multiple definition of the same function.
> > > >
> > > > Signed-off-by: Olaf Hering <olaf@aepfle.de>
> > >
> > > Reviewed-by: Jason Andryuk <jandryuk@gmail.com>
> >
> > Acked-by: Samuel Thibault <samuel.thibaut@ens-lyon.org>
>
> Reviewed-by: Ian Jackson <ian.jackson@eu.citrix.com>
>
> Thanks. I have confirmed that these symbols look to be defined (in
> tpm/tpm_emulator_extern.c). So the patch is correct.
>
> I think this is 4.14 material. Paul ?
Agreed.
Release-acked-by: Paul Durrant <paul@xen.org>
>
> We should also consider it for backports. How far back do we need
> to go ?
>
> Ian.
next prev parent reply other threads:[~2020-06-18 16:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 6:08 [PATCH v1] stubdom/vtpm: add extern to function declarations Olaf Hering
2020-06-17 13:35 ` Jason Andryuk
2020-06-17 13:40 ` Samuel Thibault
2020-06-18 15:56 ` [XEN PATCH for-4.14 " Ian Jackson
2020-06-18 16:01 ` Paul Durrant [this message]
2020-06-18 16:05 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='006901d64589$c593c440$50bb4cc0$@xen.org' \
--to=xadimgnik@gmail.com \
--cc=ian.jackson@citrix.com \
--cc=jandryuk@gmail.com \
--cc=olaf@aepfle.de \
--cc=paul@xen.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.