From: Jingoo Han <jg1.han@samsung.com>
To: "'Maximilian Güntner'" <maximilian.guentner@gmail.com>
Cc: 'Bryan Wu' <cooloney@gmail.com>,
'Richard Purdie' <rpurdie@rpsys.net>,
'linux-kernel' <linux-kernel@vger.kernel.org>,
'linux-leds' <linux-leds@vger.kernel.org>,
'Jingoo Han' <jg1.han@samsung.com>
Subject: Re: [PATCH] leds: Added driver for the NXP PCA9685 I2C chip
Date: Tue, 15 Oct 2013 09:37:38 +0900 [thread overview]
Message-ID: <006b01cec93e$c00a2a10$401e7e30$%han@samsung.com> (raw)
In-Reply-To: <2819232.mPNW6mO2uH@titan>
On Tuesday, October 15, 2013 2:32 AM, Maximilian Guntner wrote:
>
> The NXP PCA9685 supports 16 channels/leds using a 12-bit PWM (4095
> levels of brightness)
> This driver supports configuration using platform_data.
>
> Signed-off-by: Maximilian Güntner <maximilian.guentner@gmail.com>
I added some nit-picking comments. :-)
> ---
> drivers/leds/Kconfig | 10 ++
> drivers/leds/Makefile | 1 +
> drivers/leds/leds-pca9685.c | 219 +++++++++++++++++++++++++++++
> include/linux/platform_data/leds-pca9685.h | 34 +++++
> 4 files changed, 264 insertions(+)
> create mode 100644 drivers/leds/leds-pca9685.c
> create mode 100644 include/linux/platform_data/leds-pca9685.h
>
[.....]
> +
> +#include <linux/module.h>
> +#include <linux/string.h>
> +#include <linux/delay.h>
> +#include <linux/ctype.h>
> +#include <linux/leds.h>
> +#include <linux/err.h>
> +#include <linux/i2c.h>
> +#include <linux/workqueue.h>
> +#include <linux/slab.h>
> +
> +#include <linux/platform_data/leds-pca9685.h>
Please, sort these header inclusions alphabetically for
better readability.
[.....]
> +#ifndef __LINUX_PCA9685_H
> +#define __LINUX_PCA9685_H
You can add one empty line here.
> +#include <linux/leds.h>
> +
Best regards,
Jingoo Han
--
To unsubscribe from this list: send the line "unsubscribe linux-leds" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Jingoo Han <jg1.han@samsung.com>
To: "'Maximilian Güntner'" <maximilian.guentner@gmail.com>
Cc: "'Bryan Wu'" <cooloney@gmail.com>,
"'Richard Purdie'" <rpurdie@rpsys.net>,
"'linux-kernel'" <linux-kernel@vger.kernel.org>,
"'linux-leds'" <linux-leds@vger.kernel.org>,
"'Jingoo Han'" <jg1.han@samsung.com>
Subject: Re: [PATCH] leds: Added driver for the NXP PCA9685 I2C chip
Date: Tue, 15 Oct 2013 09:37:38 +0900 [thread overview]
Message-ID: <006b01cec93e$c00a2a10$401e7e30$%han@samsung.com> (raw)
In-Reply-To: <2819232.mPNW6mO2uH@titan>
On Tuesday, October 15, 2013 2:32 AM, Maximilian Guntner wrote:
>
> The NXP PCA9685 supports 16 channels/leds using a 12-bit PWM (4095
> levels of brightness)
> This driver supports configuration using platform_data.
>
> Signed-off-by: Maximilian Güntner <maximilian.guentner@gmail.com>
I added some nit-picking comments. :-)
> ---
> drivers/leds/Kconfig | 10 ++
> drivers/leds/Makefile | 1 +
> drivers/leds/leds-pca9685.c | 219 +++++++++++++++++++++++++++++
> include/linux/platform_data/leds-pca9685.h | 34 +++++
> 4 files changed, 264 insertions(+)
> create mode 100644 drivers/leds/leds-pca9685.c
> create mode 100644 include/linux/platform_data/leds-pca9685.h
>
[.....]
> +
> +#include <linux/module.h>
> +#include <linux/string.h>
> +#include <linux/delay.h>
> +#include <linux/ctype.h>
> +#include <linux/leds.h>
> +#include <linux/err.h>
> +#include <linux/i2c.h>
> +#include <linux/workqueue.h>
> +#include <linux/slab.h>
> +
> +#include <linux/platform_data/leds-pca9685.h>
Please, sort these header inclusions alphabetically for
better readability.
[.....]
> +#ifndef __LINUX_PCA9685_H
> +#define __LINUX_PCA9685_H
You can add one empty line here.
> +#include <linux/leds.h>
> +
Best regards,
Jingoo Han
next prev parent reply other threads:[~2013-10-15 0:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-14 17:31 [PATCH] leds: Added driver for the NXP PCA9685 I2C chip Maximilian Güntner
2013-10-14 22:08 ` Bryan Wu
2013-10-14 22:08 ` Bryan Wu
2013-10-14 23:32 ` Maximilian Güntner
2013-10-14 23:32 ` Maximilian Güntner
2013-10-15 1:19 ` [PATCH v2] " Maximilian Güntner
2013-10-15 1:19 ` Maximilian Güntner
2013-10-15 17:39 ` Bryan Wu
2013-10-17 1:09 ` [PATCH v3] " Maximilian Güntner
2013-10-17 1:09 ` Maximilian Güntner
2013-10-17 22:37 ` Bryan Wu
2013-10-17 22:37 ` Bryan Wu
2013-10-17 23:00 ` Maximilian Güntner
2013-10-17 23:00 ` Maximilian Güntner
2013-10-14 22:38 ` [PATCH] " Peter Meerwald
2013-10-14 23:26 ` Maximilian Güntner
2013-10-15 0:37 ` Jingoo Han [this message]
2013-10-15 0:37 ` Jingoo Han
[not found] <525d89e8.CwG1bICTvwrMEEOp%fengguang.wu@intel.com>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='006b01cec93e$c00a2a10$401e7e30$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=cooloney@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=maximilian.guentner@gmail.com \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.