From: "chaithrika" <chaithrika@ti.com>
To: "'Russell King - ARM Linux'" <linux@arm.linux.org.uk>
Cc: <linux-media@vger.kernel.org>, <mchehab@infradead.org>,
<hverkuil@xs4all.nl>,
<davinci-linux-open-source@linux.davincidsp.com>,
"'Brijesh Jadav'" <brijesh.j@ti.com>,
"'Kevin Hilman'" <khilman@deeprootsystems.com>
Subject: RE: [PATCH v2] ARM: DaVinci: DM646x Video: Platform and board specific setup
Date: Mon, 20 Jul 2009 11:38:17 +0530 [thread overview]
Message-ID: <007d01ca0900$79b4c320$6d1e4960$@com> (raw)
In-Reply-To: <20090719104258.GR12062@n2100.arm.linux.org.uk>
> -----Original Message-----
> From: Russell King - ARM Linux [mailto:linux@arm.linux.org.uk]
> Sent: Sunday, July 19, 2009 4:13 PM
> To: Chaithrika U S
> Cc: linux-media@vger.kernel.org; mchehab@infradead.org;
> hverkuil@xs4all.nl; davinci-linux-open-source@linux.davincidsp.com;
> Manjunath Hadli; Brijesh Jadav; Kevin Hilman
> Subject: Re: [PATCH v2] ARM: DaVinci: DM646x Video: Platform and board
> specific setup
>
> On Tue, Jul 07, 2009 at 07:52:57AM -0400, Chaithrika U S wrote:
> > diff --git a/arch/arm/mach-davinci/include/mach/dm646x.h
> b/arch/arm/mach-davinci/include/mach/dm646x.h
> > index 0585484..1f247fb 100644
> > --- a/arch/arm/mach-davinci/include/mach/dm646x.h
> > +++ b/arch/arm/mach-davinci/include/mach/dm646x.h
> > @@ -26,4 +26,28 @@ void __init dm646x_init(void);
> > void __init dm646x_init_mcasp0(struct snd_platform_data *pdata);
> > void __init dm646x_init_mcasp1(struct snd_platform_data *pdata);
> >
> > +void dm646x_video_init(void);
> > +
> > +struct vpif_output {
> > + u16 id;
> > + const char *name;
> > +};
> > +
> > +struct subdev_info {
> > + unsigned short addr;
> > + const char *name;
> > +};
>
> 'subdev_info' is far too generic to have in platform header files.
> Please rename this to at least vpif_subdev_info.
>
> Other than that, patch looks fine.
OK. I will post an updated patch soon.
Regards,
Chaithrika
prev parent reply other threads:[~2009-07-20 6:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-07 11:52 [PATCH v2] ARM: DaVinci: DM646x Video: Platform and board specific setup Chaithrika U S
2009-07-15 4:15 ` chaithrika
2009-07-19 10:42 ` Russell King - ARM Linux
2009-07-20 6:08 ` chaithrika [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='007d01ca0900$79b4c320$6d1e4960$@com' \
--to=chaithrika@ti.com \
--cc=brijesh.j@ti.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=hverkuil@xs4all.nl \
--cc=khilman@deeprootsystems.com \
--cc=linux-media@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.