RE: [PATCH V11 2/7] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

[Byungho An <bh74.an@samsung.com>]

Vince Bridgers <vbridgers2013@gmail.com> :
> On Sat, Mar 22, 2014 at 1:23 AM, Byungho An <bh74.an@samsung.com> wrote:
> > From: Siva Reddy <siva.kallam@samsung.com>
> >
> > This patch adds support for Samsung 10Gb ethernet driver(sxgbe).

[snip]

> > +       /* Stop Advertising 1000BASE Capability if interface is not GMII
*/
> > +       if ((phy_iface == PHY_INTERFACE_MODE_MII) ||
> > +           (phy_iface == PHY_INTERFACE_MODE_RMII))
> > +               phydev->advertising &= ~(SUPPORTED_1000baseT_Half |
> > +                                        SUPPORTED_1000baseT_Full);
> 
> Your bindings document says sgmii and xgmii are possible. This code
> implies MII, RMII are possible (since you're checking for it). Is this
> needed?
As of now it is not needed, it is for future compatibility. anyway i'll remove
in this serise.

[sinp]

> > +               next_entry = (++priv->rxq[qnum]->cur_rx) % rxsize;
> > +               prefetch(priv->rxq[qnum]->dma_rx + next_entry);
> > +
> > +               /*TO DO read the status of the incoming frame */
> 
> Did you intend to leave a "TO DO" in a V11 submission?
it is not for this patch but for later patch.

> 
> 
> All the best,
> 
> Vince
> 
> >
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe netdev" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html