RE: [PATCH V11 2/7] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

[Byungho An <bh74.an@samsung.com>]

Vince Bridgers <vbridgers2013@gmail.com> :
> On Sat, Mar 22, 2014 at 1:23 AM, Byungho An <bh74.an@samsung.com> wrote:
> > From: Siva Reddy <siva.kallam@samsung.com>
> >
> > This patch adds support for Samsung 10Gb ethernet driver(sxgbe).
> >

[snip]

> > +static int sxgbe_init_rx_buffers(struct net_device *dev,
> > +                                struct sxgbe_rx_norm_desc *p, int i,
> > +                                unsigned int dma_buf_sz,
> > +                                struct sxgbe_rx_queue *rx_ring)
> > +{
> > +       struct sxgbe_priv_data *priv = netdev_priv(dev);
> > +       struct sk_buff *skb;
> > +
> > +       skb = __netdev_alloc_skb(dev, dma_buf_sz, GFP_KERNEL);
> > +       if (!skb)
> > +               return -ENOMEM;
> > +
> > +       skb_reserve(skb, NET_IP_ALIGN);
> 
> Considering using netdev_alloc_skb_ip_align here as well. Looks like
> it was changed in refill, but not here
OK. Thanks

> > --
> > To unsubscribe from this list: send the line "unsubscribe netdev" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html