All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Cezary Rojewski <cezary.rojewski@intel.com>, alsa-devel@alsa-project.org
Cc: upstream@semihalf.com, harshapriya.n@intel.com, rad@semihalf.com,
	tiwai@suse.com, hdegoede@redhat.com, broonie@kernel.org,
	amadeuszx.slawinski@linux.intel.com, cujomalainey@chromium.org,
	lma@semihalf.com
Subject: Re: [PATCH v2 00/17] ASoC: Intel: AVS - Audio DSP for cAVS
Date: Mon, 28 Feb 2022 11:23:53 -0600	[thread overview]
Message-ID: <00972101-2526-334e-c2ea-02558b93f5bf@linux.intel.com> (raw)
In-Reply-To: <20220228153343.2263412-1-cezary.rojewski@intel.com>


> Changes v2 -> v1:
> Almost all updates here are thanks to feedback from Pierre.

Can I ask for a bit of mercy on reviewers and specifically my time? I
sent my comments on Friday, I haven't had time to look at the answers
and there's a new version already?

> - several comments and few kernel-docs have been added in areas which
>   felt more or less unclear
> - avs_ipc_wait_busy_completion() now spins up to 'repeats_left' number
>   of times before giving up
> - 'adsp_ba' field of struct avs_dev has been renamed to 'dsp_ba'
> - 'dops' field of struct avs_spec has been renamed to 'dsp_ops'
> - IPC abstraction has been simplified: SKL_ADSP_REG_HIP* regs are used
>   directly
> - fixed allnoconfig with AVS enabled compilation issues
> - fixed code loading error paths: previously requested firmware is now
>   released before function return to the caller
> - code and function arguments tied to D0IX support have been removed
>   from this patchset and will be part of followup series adding that
>   feature instead
> - enriched dev_err() messages in avs_dsp_get_core() and
>   avs_dsp_put_core()
> - numerous wording fixes used in power/reset/stall DSP operations

  parent reply	other threads:[~2022-02-28 18:05 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-28 15:33 [PATCH v2 00/17] ASoC: Intel: AVS - Audio DSP for cAVS Cezary Rojewski
2022-02-28 15:33 ` [PATCH v2 01/17] ALSA: hda: Add helper macros for DSP capable devices Cezary Rojewski
2022-02-28 15:33 ` [PATCH v2 02/17] ASoC: Export DAI register and widget ctor and dctor functions Cezary Rojewski
2022-02-28 15:33 ` [PATCH v2 03/17] ASoC: Intel: Introduce AVS driver Cezary Rojewski
2022-02-28 15:33 ` [PATCH v2 04/17] ASoC: Intel: avs: Inter process communication Cezary Rojewski
2022-02-28 15:33 ` [PATCH v2 05/17] ASoC: Intel: avs: Add code loading requests Cezary Rojewski
2022-02-28 15:33 ` [PATCH v2 06/17] ASoC: Intel: avs: Add pipeline management requests Cezary Rojewski
2022-02-28 15:33 ` [PATCH v2 07/17] ASoC: Intel: avs: Add module " Cezary Rojewski
2022-02-28 15:33 ` [PATCH v2 08/17] ASoC: Intel: avs: Add power " Cezary Rojewski
2022-02-28 15:33 ` [PATCH v2 09/17] ASoC: Intel: avs: Add ROM requests Cezary Rojewski
2022-02-28 15:33 ` [PATCH v2 10/17] ASoC: Intel: avs: Add basefw runtime-parameter requests Cezary Rojewski
2022-02-28 15:33 ` [PATCH v2 11/17] ASoC: Intel: avs: Firmware resources management utilities Cezary Rojewski
2022-02-28 15:33 ` [PATCH v2 12/17] ASoC: Intel: avs: Declare module configuration types Cezary Rojewski
2022-02-28 15:33 ` [PATCH v2 13/17] ASoC: Intel: avs: Dynamic firmware resources management Cezary Rojewski
2022-02-28 15:33 ` [PATCH v2 14/17] ASoC: Intel: avs: General code loading flow Cezary Rojewski
2022-02-28 15:33 ` [PATCH v2 15/17] ASoC: Intel: avs: Implement CLDMA transfer Cezary Rojewski
2022-02-28 15:33 ` [PATCH v2 16/17] ASoC: Intel: avs: Code loading over CLDMA Cezary Rojewski
2022-02-28 15:33 ` [PATCH v2 17/17] ASoC: Intel: avs: Code loading over HDA Cezary Rojewski
2022-02-28 17:23 ` Pierre-Louis Bossart [this message]
2022-03-01 14:22   ` [PATCH v2 00/17] ASoC: Intel: AVS - Audio DSP for cAVS Cezary Rojewski
2022-03-01 18:01 ` Pierre-Louis Bossart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=00972101-2526-334e-c2ea-02558b93f5bf@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=amadeuszx.slawinski@linux.intel.com \
    --cc=broonie@kernel.org \
    --cc=cezary.rojewski@intel.com \
    --cc=cujomalainey@chromium.org \
    --cc=harshapriya.n@intel.com \
    --cc=hdegoede@redhat.com \
    --cc=lma@semihalf.com \
    --cc=rad@semihalf.com \
    --cc=tiwai@suse.com \
    --cc=upstream@semihalf.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.