RE: [PATCH V2] ARM: EXYNOS4: Add machine support for 7" LCD on ORIGEN

[Kukjin Kim <kgene.kim@samsung.com>]

Tushar Behera wrote:
> 
> ORIGEN board is fitted with 7" LCD panel HV070WSA. The pixel
> resolution of the LCD panel is 1024x600.
> 
> Also power domain device for LCD0 is registered.
> 
> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
> ---
> Changes for V2:
> 	* Added power domain device registration for LCD0
> 
> The patch is rebased on [1]. For proper working of LCD on ORIGEN,
> following patches are needed. These patches are already submitted to
> the mailing list.
> 
> a. ARM: EXYNOS4: Add PWM backlight support on Origen
> 	Author: Giridhar Maruthy

As I said, it is already in my tree.

> b. ARM: EXYNOS4: Configure MAX8997 PMIC for Origen
> 	Author: Inderpal Singh

Will review it.

(snip)

> +
> +static struct s3c_fb_pd_win origen_fb_win0 = {
> +	.win_mode = {
> +		.left_margin	= 64,
> +		.right_margin	= 16,
> +		.upper_margin	= 64,
> +		.lower_margin	= 16,
> +		.hsync_len	= 48,
> +		.vsync_len	= 3,
> +		.xres		= 1024,
> +		.yres		= 600,
> +		.refresh	= 60,

We don't need to add '.refresh' here because its default value is 60.

> +	},
> +	.max_bpp		= 32,
> +	.default_bpp		= 24,
> +};

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.