From: Tushar Behera <tushar.behera@linaro.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com,
linaro-dev@lists.linaro.org, patches@linaro.org
Subject: Re: [PATCH V2] ARM: EXYNOS4: Add machine support for 7" LCD on ORIGEN
Date: Thu, 15 Sep 2011 09:06:54 +0530 [thread overview]
Message-ID: <4E7172D6.4060601@linaro.org> (raw)
In-Reply-To: <CAOMZO5DmwKOkHk2+FQ00Jjfo-SJ_Te97Mmypm+0XH=YBd8KUAA@mail.gmail.com>
Hi Fabio Estevam,
On Wednesday 14 September 2011 06:09 PM, Fabio Estevam wrote:
> On Wed, Sep 14, 2011 at 9:07 AM, Tushar Behera<tushar.behera@linaro.org> wrote:
> ...
>
>> Will this be better?
>>
>> static void lcd_hv070wsa_set_power(struct plat_lcd_data *pd, \
>> unsigned int power)
>> {
>> int ret;
>> unsigned long flag = power ? GPIOF_OUT_INIT_HIGH : \
>> GPIOF_OUT_INIT_LOW;
>>
>> ret = gpio_request_one(EXYNOS4_GPE3(4), flag, "GPE3_4");
>>
>> if (ret)
>> printk(KERN_ERR "Could not request gpio for LCD power");
>> }
>
> Looks better. You can use pr_err instead of printk(KERN_ERR .
>
Thanks for your review comments. I will send the next version with these
changes.
> Regards,
>
> Fabio Estevam
--
Tushar Behera
next prev parent reply other threads:[~2011-09-15 3:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-14 11:01 [PATCH V2] ARM: EXYNOS4: Add machine support for 7" LCD on ORIGEN Tushar Behera
[not found] ` <1315998112-31395-1-git-send-email-tushar.behera-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-09-14 11:36 ` Fabio Estevam
2011-09-14 12:07 ` Tushar Behera
2011-09-14 12:39 ` Fabio Estevam
2011-09-15 3:36 ` Tushar Behera [this message]
2011-09-15 4:54 ` Kukjin Kim
2011-09-15 5:33 ` Tushar Behera
2011-09-15 4:50 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E7172D6.4060601@linaro.org \
--to=tushar.behera@linaro.org \
--cc=festevam@gmail.com \
--cc=kgene.kim@samsung.com \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.