From: Kukjin Kim <kgene.kim@samsung.com>
To: 'Marek Szyprowski' <m.szyprowski@samsung.com>,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: kyungmin.park@samsung.com, ben-linux@fluff.org
Subject: RE: [PATCH] ARM: Samsung S5P: Unify defines for both gpio interrupt types
Date: Thu, 30 Sep 2010 20:45:36 +0900 [thread overview]
Message-ID: <00a801cb6095$0212ef20$0638cd60$%kim@samsung.com> (raw)
In-Reply-To: <00e101cb6093$34f4d270$9ede7750$%szyprowski@samsung.com>
Marek Szyprowski wrote:
>
> Hello,
>
Hi,
(snip)
> >
> > Ok..firstly looks ok to me now.
> > But I don't know...in the future may have to revert back due to S5P64XX.
>
> Well, these defines are used only by plat-s5p/irq-{eint,gpioint}.c. These
generic
> functions cannot be used for S5P64XX anyway, because it has S3C64XX style
of
> gpio
> registers afair. IMHO this shouldn't be a problem. Just S5P64XX would need
to
> provide it's own code for gpio/ext interrupts (or share the code with
s3c64xx
> somehow).
>
Yes, you're right. It seems to have been useless worry.
However, it is likely to think of once again later.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
WARNING: multiple messages have this Message-ID (diff)
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Samsung S5P: Unify defines for both gpio interrupt types
Date: Thu, 30 Sep 2010 20:45:36 +0900 [thread overview]
Message-ID: <00a801cb6095$0212ef20$0638cd60$%kim@samsung.com> (raw)
In-Reply-To: <00e101cb6093$34f4d270$9ede7750$%szyprowski@samsung.com>
Marek Szyprowski wrote:
>
> Hello,
>
Hi,
(snip)
> >
> > Ok..firstly looks ok to me now.
> > But I don't know...in the future may have to revert back due to S5P64XX.
>
> Well, these defines are used only by plat-s5p/irq-{eint,gpioint}.c. These
generic
> functions cannot be used for S5P64XX anyway, because it has S3C64XX style
of
> gpio
> registers afair. IMHO this shouldn't be a problem. Just S5P64XX would need
to
> provide it's own code for gpio/ext interrupts (or share the code with
s3c64xx
> somehow).
>
Yes, you're right. It seems to have been useless worry.
However, it is likely to think of once again later.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
next prev parent reply other threads:[~2010-09-30 11:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-30 10:18 [PATCH] ARM: Samsung S5P: Unify defines for both gpio interrupt types Marek Szyprowski
2010-09-30 10:18 ` Marek Szyprowski
2010-09-30 11:23 ` Kukjin Kim
2010-09-30 11:23 ` Kukjin Kim
2010-09-30 11:32 ` Marek Szyprowski
2010-09-30 11:32 ` Marek Szyprowski
2010-09-30 11:45 ` Kukjin Kim [this message]
2010-09-30 11:45 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00a801cb6095$0212ef20$0638cd60$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=ben-linux@fluff.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.