From: "Alim Akhtar" <alim.akhtar@samsung.com>
To: "'Chanho Park'" <chanho61.park@samsung.com>,
"'Kishon Vijay Abraham I'" <kishon@ti.com>,
"'Vinod Koul'" <vkoul@kernel.org>,
"'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
"'Rob Herring'" <robh+dt@kernel.org>,
"'Krzysztof Kozlowski'" <krzysztof.kozlowski+dt@linaro.org>
Cc: <devicetree@vger.kernel.org>, <linux-phy@lists.infradead.org>,
<linux-samsung-soc@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH v4 5/5] phy: samsung: ufs: support secondary ufs phy
Date: Tue, 7 Jun 2022 22:42:48 +0530 [thread overview]
Message-ID: <00ab01d87a91$d1af41c0$750dc540$@samsung.com> (raw)
In-Reply-To: <20220607072907.127000-6-chanho61.park@samsung.com>
>-----Original Message-----
>From: Chanho Park [mailto:chanho61.park@samsung.com]
>Sent: Tuesday, June 7, 2022 12:59 PM
>To: Kishon Vijay Abraham I <kishon@ti.com>; Vinod Koul
><vkoul@kernel.org>; Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>;
>Alim Akhtar <alim.akhtar@samsung.com>; Rob Herring
><robh+dt@kernel.org>; Krzysztof Kozlowski
><krzysztof.kozlowski+dt@linaro.org>
>Cc: devicetree@vger.kernel.org; linux-phy@lists.infradead.org; linux-
>samsung-soc@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Chanho
>Park <chanho61.park@samsung.com>
>Subject: [PATCH v4 5/5] phy: samsung: ufs: support secondary ufs phy
>
>To support secondary ufs phy device, we need to get an offset for phy
>isolation from the syscon DT node. If the first index argument of the node is
>existing, we can read the offset value and set it as isol->offset.
>
>Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>Signed-off-by: Chanho Park <chanho61.park@samsung.com>
>---
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
> drivers/phy/samsung/phy-samsung-ufs.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/drivers/phy/samsung/phy-samsung-ufs.c
>b/drivers/phy/samsung/phy-samsung-ufs.c
>index 0c933e364064..206a79c69a6c 100644
>--- a/drivers/phy/samsung/phy-samsung-ufs.c
>+++ b/drivers/phy/samsung/phy-samsung-ufs.c
>@@ -288,6 +288,7 @@ static int samsung_ufs_phy_probe(struct
>platform_device *pdev)
> struct phy *gen_phy;
> struct phy_provider *phy_provider;
> const struct samsung_ufs_phy_drvdata *drvdata;
>+ u32 isol_offset;
> int err = 0;
>
> match = of_match_node(samsung_ufs_phy_match, dev->of_node);
>@@ -330,6 +331,10 @@ static int samsung_ufs_phy_probe(struct
>platform_device *pdev)
> phy->has_symbol_clk = drvdata->has_symbol_clk;
> memcpy(&phy->isol, &drvdata->isol, sizeof(phy->isol));
>
>+ if (!of_property_read_u32_index(dev->of_node, "samsung,pmu-
>syscon", 1,
>+ &isol_offset))
>+ phy->isol.offset = isol_offset;
>+
> phy->lane_cnt = PHY_DEF_LANE_CNT;
>
> phy_set_drvdata(gen_phy, phy);
>--
>2.36.1
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
WARNING: multiple messages have this Message-ID (diff)
From: "Alim Akhtar" <alim.akhtar@samsung.com>
To: "'Chanho Park'" <chanho61.park@samsung.com>,
"'Kishon Vijay Abraham I'" <kishon@ti.com>,
"'Vinod Koul'" <vkoul@kernel.org>,
"'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
"'Rob Herring'" <robh+dt@kernel.org>,
"'Krzysztof Kozlowski'" <krzysztof.kozlowski+dt@linaro.org>
Cc: <devicetree@vger.kernel.org>, <linux-phy@lists.infradead.org>,
<linux-samsung-soc@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH v4 5/5] phy: samsung: ufs: support secondary ufs phy
Date: Tue, 7 Jun 2022 22:42:48 +0530 [thread overview]
Message-ID: <00ab01d87a91$d1af41c0$750dc540$@samsung.com> (raw)
In-Reply-To: <20220607072907.127000-6-chanho61.park@samsung.com>
>-----Original Message-----
>From: Chanho Park [mailto:chanho61.park@samsung.com]
>Sent: Tuesday, June 7, 2022 12:59 PM
>To: Kishon Vijay Abraham I <kishon@ti.com>; Vinod Koul
><vkoul@kernel.org>; Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>;
>Alim Akhtar <alim.akhtar@samsung.com>; Rob Herring
><robh+dt@kernel.org>; Krzysztof Kozlowski
><krzysztof.kozlowski+dt@linaro.org>
>Cc: devicetree@vger.kernel.org; linux-phy@lists.infradead.org; linux-
>samsung-soc@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Chanho
>Park <chanho61.park@samsung.com>
>Subject: [PATCH v4 5/5] phy: samsung: ufs: support secondary ufs phy
>
>To support secondary ufs phy device, we need to get an offset for phy
>isolation from the syscon DT node. If the first index argument of the node is
>existing, we can read the offset value and set it as isol->offset.
>
>Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>Signed-off-by: Chanho Park <chanho61.park@samsung.com>
>---
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
> drivers/phy/samsung/phy-samsung-ufs.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/drivers/phy/samsung/phy-samsung-ufs.c
>b/drivers/phy/samsung/phy-samsung-ufs.c
>index 0c933e364064..206a79c69a6c 100644
>--- a/drivers/phy/samsung/phy-samsung-ufs.c
>+++ b/drivers/phy/samsung/phy-samsung-ufs.c
>@@ -288,6 +288,7 @@ static int samsung_ufs_phy_probe(struct
>platform_device *pdev)
> struct phy *gen_phy;
> struct phy_provider *phy_provider;
> const struct samsung_ufs_phy_drvdata *drvdata;
>+ u32 isol_offset;
> int err = 0;
>
> match = of_match_node(samsung_ufs_phy_match, dev->of_node);
>@@ -330,6 +331,10 @@ static int samsung_ufs_phy_probe(struct
>platform_device *pdev)
> phy->has_symbol_clk = drvdata->has_symbol_clk;
> memcpy(&phy->isol, &drvdata->isol, sizeof(phy->isol));
>
>+ if (!of_property_read_u32_index(dev->of_node, "samsung,pmu-
>syscon", 1,
>+ &isol_offset))
>+ phy->isol.offset = isol_offset;
>+
> phy->lane_cnt = PHY_DEF_LANE_CNT;
>
> phy_set_drvdata(gen_phy, phy);
>--
>2.36.1
WARNING: multiple messages have this Message-ID (diff)
From: "Alim Akhtar" <alim.akhtar@samsung.com>
To: "'Chanho Park'" <chanho61.park@samsung.com>,
"'Kishon Vijay Abraham I'" <kishon@ti.com>,
"'Vinod Koul'" <vkoul@kernel.org>,
"'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
"'Rob Herring'" <robh+dt@kernel.org>,
"'Krzysztof Kozlowski'" <krzysztof.kozlowski+dt@linaro.org>
Cc: <devicetree@vger.kernel.org>, <linux-phy@lists.infradead.org>,
<linux-samsung-soc@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH v4 5/5] phy: samsung: ufs: support secondary ufs phy
Date: Tue, 7 Jun 2022 22:42:48 +0530 [thread overview]
Message-ID: <00ab01d87a91$d1af41c0$750dc540$@samsung.com> (raw)
In-Reply-To: <20220607072907.127000-6-chanho61.park@samsung.com>
>-----Original Message-----
>From: Chanho Park [mailto:chanho61.park@samsung.com]
>Sent: Tuesday, June 7, 2022 12:59 PM
>To: Kishon Vijay Abraham I <kishon@ti.com>; Vinod Koul
><vkoul@kernel.org>; Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>;
>Alim Akhtar <alim.akhtar@samsung.com>; Rob Herring
><robh+dt@kernel.org>; Krzysztof Kozlowski
><krzysztof.kozlowski+dt@linaro.org>
>Cc: devicetree@vger.kernel.org; linux-phy@lists.infradead.org; linux-
>samsung-soc@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Chanho
>Park <chanho61.park@samsung.com>
>Subject: [PATCH v4 5/5] phy: samsung: ufs: support secondary ufs phy
>
>To support secondary ufs phy device, we need to get an offset for phy
>isolation from the syscon DT node. If the first index argument of the node is
>existing, we can read the offset value and set it as isol->offset.
>
>Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>Signed-off-by: Chanho Park <chanho61.park@samsung.com>
>---
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
> drivers/phy/samsung/phy-samsung-ufs.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/drivers/phy/samsung/phy-samsung-ufs.c
>b/drivers/phy/samsung/phy-samsung-ufs.c
>index 0c933e364064..206a79c69a6c 100644
>--- a/drivers/phy/samsung/phy-samsung-ufs.c
>+++ b/drivers/phy/samsung/phy-samsung-ufs.c
>@@ -288,6 +288,7 @@ static int samsung_ufs_phy_probe(struct
>platform_device *pdev)
> struct phy *gen_phy;
> struct phy_provider *phy_provider;
> const struct samsung_ufs_phy_drvdata *drvdata;
>+ u32 isol_offset;
> int err = 0;
>
> match = of_match_node(samsung_ufs_phy_match, dev->of_node);
>@@ -330,6 +331,10 @@ static int samsung_ufs_phy_probe(struct
>platform_device *pdev)
> phy->has_symbol_clk = drvdata->has_symbol_clk;
> memcpy(&phy->isol, &drvdata->isol, sizeof(phy->isol));
>
>+ if (!of_property_read_u32_index(dev->of_node, "samsung,pmu-
>syscon", 1,
>+ &isol_offset))
>+ phy->isol.offset = isol_offset;
>+
> phy->lane_cnt = PHY_DEF_LANE_CNT;
>
> phy_set_drvdata(gen_phy, phy);
>--
>2.36.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-07 17:13 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220607072937epcas2p4e3e1bf3258e021c20692b0d348abdd8b@epcas2p4.samsung.com>
2022-06-07 7:29 ` [PATCH v4 0/5] support secondary ufs for Exynos Auto v9 SoC Chanho Park
2022-06-07 7:29 ` Chanho Park
2022-06-07 7:29 ` Chanho Park
2022-06-07 7:29 ` [PATCH v4 1/5] dt-bindings: phy: samsung,ufs-phy: make pmu-syscon as phandle-array Chanho Park
2022-06-07 7:29 ` Chanho Park
2022-06-07 7:29 ` Chanho Park
2022-06-07 7:29 ` [PATCH v4 2/5] phy: samsung: ufs: rename cfg to cfgs for clarification Chanho Park
2022-06-07 7:29 ` Chanho Park
2022-06-07 7:29 ` Chanho Park
2022-06-07 17:08 ` Alim Akhtar
2022-06-07 17:08 ` Alim Akhtar
2022-06-07 17:08 ` Alim Akhtar
2022-06-07 7:29 ` [PATCH v4 3/5] phy: samsung: ufs: constify samsung_ufs_phy_cfg Chanho Park
2022-06-07 7:29 ` Chanho Park
2022-06-07 7:29 ` Chanho Park
2022-06-07 11:23 ` Krzysztof Kozlowski
2022-06-07 11:23 ` Krzysztof Kozlowski
2022-06-07 11:23 ` Krzysztof Kozlowski
2022-06-07 17:08 ` Alim Akhtar
2022-06-07 17:08 ` Alim Akhtar
2022-06-07 17:08 ` Alim Akhtar
2022-06-07 7:29 ` [PATCH v4 4/5] phy: samsung: ufs: remove drvdata from struct samsung_ufs_phy Chanho Park
2022-06-07 7:29 ` Chanho Park
2022-06-07 7:29 ` Chanho Park
2022-06-07 17:12 ` Alim Akhtar
2022-06-07 17:12 ` Alim Akhtar
2022-06-07 17:12 ` Alim Akhtar
2022-06-07 7:29 ` [PATCH v4 5/5] phy: samsung: ufs: support secondary ufs phy Chanho Park
2022-06-07 7:29 ` Chanho Park
2022-06-07 7:29 ` Chanho Park
2022-06-07 17:12 ` Alim Akhtar [this message]
2022-06-07 17:12 ` Alim Akhtar
2022-06-07 17:12 ` Alim Akhtar
2022-06-08 16:21 ` [PATCH v4 0/5] support secondary ufs for Exynos Auto v9 SoC Vinod Koul
2022-06-08 16:21 ` Vinod Koul
2022-06-08 16:21 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00ab01d87a91$d1af41c0$750dc540$@samsung.com' \
--to=alim.akhtar@samsung.com \
--cc=chanho61.park@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.